<table><tr><td style="">tcanabrava added a subscriber: apol.<br />tcanabrava added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16132">View Revision</a></tr></table><br /><div><div><p>Pino.</p>
<p>I understand that, also please understand that he's a newcomer and he's<br />
still learning the tools and being increasingly difficult to accept a<br />
review (that can be fixed in a follow-up review if the error is not<br />
blatant) is counter productive and demotivating.</p>
<p>We have no commits in kde edu for a while, IV found people to help, let the<br />
commits pass even if he closed the original review and opened a new one.<br />
The code is correct.</p>
<p>Em sex, 12 de out de 2018 às 07:23, Pino Toscano <<br />
noreply@phabricator.kde.org> escreveu:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>pino added a comment. View Revision <a href="https://phabricator.kde.org/D16132" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D16132</a></p>
<p>In <a href="https://phabricator.kde.org/D16132#341566" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D16132#341566</a> <a href="https://phabricator.kde.org/D16132#341566" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D16132#341566</a>,<br />
<a href="https://phabricator.kde.org/p/filipesaraiva/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@filipesaraiva</a> <a href="https://phabricator.kde.org/p/filipesaraiva/" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/p/filipesaraiva/</a> wrote:</p>
<p>This patch was splitted from <a href="https://phabricator.kde.org/D16120" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D16120</a> <a href="https://phabricator.kde.org/D16120" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D16120</a><br />
because he was trying to create different reviews for different changes.<br />
Were you asking for it, no?</p>
<p>In <a href="https://phabricator.kde.org/D16120" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D16120</a>: Changed old style casts <a href="https://phabricator.kde.org/D16120" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D16120</a> I<br />
asked to split changes which were not "fix old style casts", and <a href="https://phabricator.kde.org/D16140" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D16140</a>:<br />
Removed unreachable lines <a href="https://phabricator.kde.org/D16140" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D16140</a> does<br />
exactly that.<br />
This is basic commit hygene:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">have unrelated changes in different commits, so they can be reviewed & tested more easily</li>
<li class="remarkup-list-item">document properly what are the changes in a commit
<br /><br />
<a href="https://phabricator.kde.org/p/carlos_hdc/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@carlos_hdc</a> <a href="https://phabricator.kde.org/p/carlos_hdc/" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/p/carlos_hdc/</a> started <a href="https://phabricator.kde.org/D16120" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D16120</a>: Changed old style casts <a href="https://phabricator.kde.org/D16120" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D16120</a> (or actually <a href="https://phabricator.kde.org/D15690" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D15690</a>: Removed old style casts <a href="https://phabricator.kde.org/D15690" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D15690</a>, which was abandoned instead of just being fixed...) about "fix old style casts": that is good, so do not lump it with unrelated changes, such as whitespaces changes, remove unreacheable lines, and so forth.
<br /><br />
*REPOSITORY* <a href="https://phabricator.kde.org/source/kalzium/" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">R326</a> Kalzium
<br /><br />
*REVISION DETAIL* <a href="https://phabricator.kde.org/D16132" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D16132</a>
<br /><br />
*To: *carlos_hdc, tcanabrava, filipesaraiva, pino *Cc: *pino, kde-edu, narvaez, apol</li>
</ul></blockquote></div></div><br /><div><strong>REPOSITORY</strong><div><div>R326 Kalzium</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16132">https://phabricator.kde.org/D16132</a></div></div><br /><div><strong>To: </strong>carlos_hdc, tcanabrava, filipesaraiva, pino<br /><strong>Cc: </strong>apol, pino, kde-edu, narvaez<br /></div>