<table><tr><td style="">rizzitello requested changes to this revision.<br />rizzitello added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16143">View Revision</a></tr></table><br /><div><div><p>Check your Indentation you seam to have moved all your modified lines in a bit.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16143#inline-87648">View Inline</a><span style="color: #4b4d51; font-weight: bold;">editor.cpp:427</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">format</span> <span style="color: #aa2211">=</span> <span class="n">highlighter</span><span style="color: #aa2211">-></span><span class="n">tokenToFormat</span><span class="p">(</span><span class="n">token</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">    </span><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">format</span> <span style="color: #aa2211">!=</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright">        </span><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">format</span> <span style="color: #aa2211">!=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">      <span style="color: #aa4000">bool</span> <span class="n">bold</span> <span style="color: #aa2211">=</span> <span class="n">format</span><span style="color: #aa2211">-></span><span class="n">fontWeight</span><span class="p">()</span> <span style="color: #aa2211">></span> <span style="color: #601200">50</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">In this situation we can do this.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (pointer) {
    pointer is something
} else {
   pointer is null
}</pre></div>

<p style="padding: 0; margin: 8px;">since any non 0 value is true if your pointer has be initialized will be "true"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R337 KTurtle</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16143">https://phabricator.kde.org/D16143</a></div></div><br /><div><strong>To: </strong>Shroudmaster, tcanabrava, rizzitello<br /><strong>Cc: </strong>rizzitello, kde-edu, narvaez, apol<br /></div>