<table><tr><td style="">pino added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15690">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">again, please do not mix unrelated changes, just submit <em>separate</em> and <em>documented</em> review for them</li>
<li class="remarkup-list-item">please follow a bit more the existing coding style</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84763">View Inline</a><span style="color: #4b4d51; font-weight: bold;">isotope.cpp:97</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span> <span class="n">m_abundance</span><span class="p">.</span><span class="n">value</span><span class="p">().</span><span class="n">toString</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">return</span> <span style="color: #004012">QString</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84764">View Inline</a><span style="color: #4b4d51; font-weight: bold;">calculator.cpp:89</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">item</span> <span style="color: #aa2211">==</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0L</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">item</span> <span style="color: #aa2211">==</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84765">View Inline</a><span style="color: #4b4d51; font-weight: bold;">concCalculator.cpp:291</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">break</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">case</span> <span style="color: #601200">2</span><span style="color: #aa2211">:</span> <span style="color: #74777d">// molality specified</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84766">View Inline</a><span style="color: #4b4d51; font-weight: bold;">concCalculator.cpp:299</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">break</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">case</span> <span style="color: #601200">5</span><span style="color: #aa2211">:</span> <span style="color: #74777d">// mole fraction specified</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84767">View Inline</a><span style="color: #4b4d51; font-weight: bold;">concCalculator.cpp:331</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">break</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">case</span> <span style="color: #601200">1</span><span style="color: #aa2211">:</span> <span style="color: #74777d">// normality specified</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84768">View Inline</a><span style="color: #4b4d51; font-weight: bold;">concCalculator.cpp:341</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">break</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84769">View Inline</a><span style="color: #4b4d51; font-weight: bold;">concCalculator.cpp:371-372</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">error</span><span class="p">(</span><span class="n">INSUFFICIENT_DATA_SOLVENT</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">return</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">break</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// cannot be calculated (insufficient data)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span><span class="p">;<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// cannot be calculated (insufficient data)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">case</span> <span style="color: #601200">5</span><span style="color: #aa2211">:</span> <span style="color: #74777d">// mole fraction specified</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated changes</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84770">View Inline</a><span style="color: #4b4d51; font-weight: bold;">concCalculator.cpp:626</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">volume</span> <span style="color: #aa2211">=</span> <span class="n">massSolute</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">densitySolute</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">default</span><span style="color: #aa2211">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">good, but unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84771">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gasCalculator.cpp:337-338</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">ui</span><span class="p">.</span><span class="n">error</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Molar mass cannot be zero, please enter a non-zero value."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">default</span><span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84774">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:182</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">foreach</span> <span class="p">(</span><span class="n">QListWidgetItem</span> <span style="color: #aa2211">*</span><span class="n">element</span><span class="p">,</span> <span class="n">ui</span><span class="p">.</span><span class="n">elementListWidget</span><span style="color: #aa2211">-></span><span class="n">selectedItems</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ElementListEntry</span><span style="color: #aa2211">*</span> <span class="n">element_entry</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span> <span style="color: #aa2211"><</span><span class="n">ElementListEntry</span><span style="color: #aa2211">*></span> <span class="p">(</span><span class="n">element</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84775">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:188</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">foreach</span> <span class="p">(</span><span class="n">QListWidgetItem</span> <span style="color: #aa2211">*</span><span class="n">property</span><span class="p">,</span> <span class="n">ui</span><span class="p">.</span><span class="n">propertyListWidget</span><span style="color: #aa2211">-></span><span class="n">selectedItems</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">PropertyListEntry</span><span style="color: #aa2211">*</span> <span class="n">property_entry</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">PropertyListEntry</span><span style="color: #aa2211">*></span> <span class="p">(</span><span class="n">property</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84772">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:193</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211"><<</span> <span style="color: #766510">"</td></span><span style="color: #bb6622">\n</span><span style="color: #766510"><td class=</span><span style="color: #bb6622">\"</span><span style="color: #766510">value</span><span style="color: #bb6622">\"</span><span style="color: #766510">>"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa2211"><<</span> <span class="n">KalziumUtils</span><span style="color: #aa2211">::</span><span class="n">prettyUnit</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">((</span><span class="n">ElementListEntry</span><span style="color: #aa2211">*</span><span class="p">)</span> <span class="n">element</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">m_element</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">((</span><span class="n">PropertyListEntry</span><span style="color: #aa2211">*</span><span class="p">)</span> <span class="n">property</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">m_type</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">KalziumUtils</span><span style="color: #aa2211">::</span><span class="n">prettyUnit</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">element_entry</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">m_element</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"></span><span class="n"><span class="bright">property_entry</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">m_type</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211"><<</span> <span style="color: #766510">"</td></span><span style="color: #bb6622">\n</span><span style="color: #766510"></tr></span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, i.e missing space after comma</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84776">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:204</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">foreach</span> <span class="p">(</span><span class="n">QListWidgetItem</span> <span style="color: #aa2211">*</span><span class="n">element</span><span class="p">,</span> <span class="n">ui</span><span class="p">.</span><span class="n">elementListWidget</span><span style="color: #aa2211">-></span><span class="n">selectedItems</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ElementListEntry</span><span style="color: #aa2211">*</span> <span class="n">element_entry</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">ElementListEntry</span><span style="color: #aa2211">*></span> <span class="p">(</span><span class="n">element</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84777">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:210</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">foreach</span> <span class="p">(</span><span class="n">QListWidgetItem</span> <span style="color: #aa2211">*</span><span class="n">property</span><span class="p">,</span> <span class="n">ui</span><span class="p">.</span><span class="n">propertyListWidget</span><span style="color: #aa2211">-></span><span class="n">selectedItems</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">PropertyListEntry</span><span style="color: #aa2211">*</span> <span class="n">property_entry</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">PropertyListEntry</span><span style="color: #aa2211">*></span> <span class="p">(</span><span class="n">property</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84773">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:215</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211"><<</span> <span style="color: #766510">"</span><span style="color: #bb6622">\"</span><span style="color: #766510">>"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa2211"><<</span> <span class="n">KalziumUtils</span><span style="color: #aa2211">::</span><span class="n">prettyUnit</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">((</span><span class="n">ElementListEntry</span><span style="color: #aa2211">*</span><span class="p">)</span> <span class="n">element</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">m_element</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">((</span><span class="n">PropertyListEntry</span><span style="color: #aa2211">*</span><span class="p">)</span> <span class="n">property</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">m_type</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">KalziumUtils</span><span style="color: #aa2211">::</span><span class="n">prettyUnit</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">element_entry</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">m_element</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"></span><span class="n"><span class="bright">property_entry</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">m_type</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211"><<</span> <span style="color: #766510">"</property></span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, i.e missing space after comma</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84778">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:227</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">foreach</span> <span class="p">(</span><span class="n">QListWidgetItem</span> <span style="color: #aa2211">*</span><span class="n">property</span><span class="p">,</span> <span class="n">ui</span><span class="p">.</span><span class="n">propertyListWidget</span><span style="color: #aa2211">-></span><span class="n">selectedItems</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">PropertyListEntry</span><span style="color: #aa2211">*</span> <span class="n">property_entry</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">PropertyListEntry</span><span style="color: #aa2211">*></span> <span class="p">(</span><span class="n">property</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84779">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:236</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">foreach</span> <span class="p">(</span><span class="n">QListWidgetItem</span> <span style="color: #aa2211">*</span><span class="n">element</span><span class="p">,</span> <span class="n">ui</span><span class="p">.</span><span class="n">elementListWidget</span><span style="color: #aa2211">-></span><span class="n">selectedItems</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ElementListEntry</span><span style="color: #aa2211">*</span> <span class="n">element_entry</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">ElementListEntry</span><span style="color: #aa2211">*></span> <span class="p">(</span><span class="n">element</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84780">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:242</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">foreach</span> <span class="p">(</span><span class="n">QListWidgetItem</span> <span style="color: #aa2211">*</span><span class="n">property</span><span class="p">,</span> <span class="n">ui</span><span class="p">.</span><span class="n">propertyListWidget</span><span style="color: #aa2211">-></span><span class="n">selectedItems</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">PropertyListEntry</span><span style="color: #aa2211">*</span> <span class="n">property_entry</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">PropertyListEntry</span><span style="color: #aa2211">*></span> <span class="p">(</span><span class="n">property</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84781">View Inline</a><span style="color: #4b4d51; font-weight: bold;">exportdialog.cpp:245</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211">*</span><span class="n">m_outputStream</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">", </span><span style="color: #bb6622">\"</span><span style="color: #766510">"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa2211"><<</span> <span class="n">KalziumUtils</span><span style="color: #aa2211">::</span><span class="n">prettyUnit</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">((</span><span class="n">ElementListEntry</span><span style="color: #aa2211">*</span><span class="p">)</span> <span class="n">element</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">m_element</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">((</span><span class="n">PropertyListEntry</span><span style="color: #aa2211">*</span><span class="p">)</span> <span class="n">property</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">m_type</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">KalziumUtils</span><span style="color: #aa2211">::</span><span class="n">prettyUnit</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">element_entry</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">m_element</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"></span><span class="n"><span class="bright">property_entry</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">m_type</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211"><<</span> <span style="color: #766510">"</span><span style="color: #bb6622">\"</span><span style="color: #766510">"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, i.e missing space after comma</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84782">View Inline</a><span style="color: #4b4d51; font-weight: bold;">isotopeguideview.cpp:27</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_guidedView</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_guidedView</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_scale</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1.0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84783">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumviewimpl.cpp:75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211"><<</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">peak</span><span style="color: #aa2211">-></span><span class="n">intensity</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">items</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">QTreeWidgetItem</span><span class="p">((</span><span class="n">QTreeWidget</span><span style="color: #aa2211">*</span><span class="p">)</span><span style="color: #601200">0</span><span class="p">,</span> <span class="n">row</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span class="n"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">append</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">new</span></span><span class="bright"> </span><span class="n"><span class="bright">QTreeWidgetItem</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">QTreeWidget</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">row</span></span><span class="bright"></span><span class="p"><span class="bright">));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84784">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumwidget.cpp:155</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">wavelength_</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">floor</span><span class="p">(</span><span class="n">wavelength</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">wavelength_</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">floor</span><span class="p">(</span><span class="n">wavelength<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84785">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumwidget.cpp:206</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">// return qRound(m_intensityMax * pow(color*factor, m_gamma)); FIXME</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">return</span> <span class="n">m_intensityMax</span> <span style="color: #aa2211">*</span> <span class="n">color</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">m_intensityMax</span> <span style="color: #aa2211">*</span> <span class="n">color<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84786">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumwidget.cpp:219</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">//the total number of tickmarks to draw (small and long)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">numberOfTickmarks</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">floor<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">((</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">double</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>(</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">d</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">numberOfTickmarks</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">floor</span><span class="p">(</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">d</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84787">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumwidget.cpp:230</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">i</span> <span style="color: #aa2211">*</span> <span class="n">d</span> <span style="color: #aa2211"><</span> <span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">space</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">pos</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>(</span><span class="n">i</span> <span style="color: #aa2211">*</span> <span class="n">d</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">pos</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p">(</span><span class="n">i</span> <span style="color: #aa2211">*</span> <span class="n">d</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">p</span><span style="color: #aa2211">-></span><span class="n">fillRect</span><span class="p">(</span><span class="n">i</span> <span style="color: #aa2211">*</span> <span class="n">d</span> <span style="color: #aa2211">-</span> <span class="n">space</span><span class="p">,</span> <span class="n">m_realHeight</span> <span style="color: #aa2211">+</span> <span style="color: #601200">12</span><span class="p">,</span> <span style="color: #601200">2</span> <span style="color: #aa2211">*</span> <span class="n">space</span><span class="p">,</span> <span style="color: #601200">15</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">white</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84788">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumwidget.cpp:318</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">findPeakFromMouseposition</span><span class="p">(</span><span class="n">Wavelength</span><span class="p">(<span class="bright">(</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">e</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">findPeakFromMouseposition</span><span class="p">(</span><span class="n">Wavelength</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">e</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">(<span class="bright">)</span>)</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84789">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumwidget.cpp:324</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">qDebug</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"SpectrumWidget::findPeakFromMouseposition()"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">Spectrum</span><span style="color: #aa2211">::</span><span class="n">peak</span> <span style="color: #aa2211">*</span><span class="n">peak</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">NULL</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Spectrum</span><span style="color: #aa2211">::</span><span class="n">peak</span> <span style="color: #aa2211">*</span><span class="n">peak</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84790">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumwidget.cpp:361-362</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">e</span><span style="color: #aa2211">-></span><span class="n">button</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">LeftButton</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">left</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">Wavelength</span><span class="p">(<span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">double</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">m_LMBPointPress</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">right</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">Wavelength</span><span class="p">(<span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">double</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">e</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">left</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">Wavelength</span><span class="p">(</span><span class="n">m_LMBPointPress</span><span class="p">.</span><span class="n">x</span><span class="p">(<span class="bright">)</span>)</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">right</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">Wavelength</span><span class="p">(</span><span class="n">e</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">(<span class="bright">)</span>)</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84791">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tablesdialog.cpp:270</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QMenu</span><span style="color: #aa2211">*</span> <span class="n">menu</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QMenu</span><span class="p">(<span class="bright">(</span></span><span class="n">QWidget</span><span style="color: #aa2211">*<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="n">sender</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QMenu</span><span style="color: #aa2211">*</span> <span class="n">menu</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QMenu</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="n">QWidget</span><span style="color: #aa2211">*<span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">sender</span><span class="p">(<span class="bright">)</span>));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">menu</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"&Copy"</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">copyToClipboard</span><span class="p">()),</span> <span class="n">QKeySequence</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_C</span> <span style="color: #aa2211">|</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">CTRL</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">coding style, extra space between angle bracket and round bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84792">View Inline</a><span style="color: #4b4d51; font-weight: bold;">moleculeview.cpp:174</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_molecule</span><span class="p">.</span><span class="n">atomCount</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">0</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">disconnect</span><span class="p">(</span><span class="n">ui</span><span class="p">.</span><span class="n">glWidget</span><span style="color: #aa2211">-></span><span class="n">molecule</span><span class="p">(),</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">disconnect</span><span class="p">(</span><span class="n">ui</span><span class="p">.</span><span class="n">glWidget</span><span style="color: #aa2211">-></span><span class="n">molecule</span><span class="p">(),</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">ui</span><span class="p">.</span><span class="n">glWidget</span><span style="color: #aa2211">-></span><span class="n">setMolecule</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">m_molecule</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84793">View Inline</a><span style="color: #4b4d51; font-weight: bold;">obconverter.cpp:64</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">delete</span> <span class="n">OBConvObject</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">OBConvObject</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #304a96"><span class="bright">NULL</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">OBConvObject</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">unrelated change</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R326 Kalzium</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15690">https://phabricator.kde.org/D15690</a></div></div><br /><div><strong>To: </strong>carlos_hdc, tcanabrava, pino<br /><strong>Cc: </strong>pino, kde-edu, narvaez, apol<br /></div>