<table><tr><td style="">tcanabrava added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15690">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84705">View Inline</a><span style="color: #4b4d51; font-weight: bold;">concCalculator.cpp:626</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">volume</span> <span style="color: #aa2211">=</span> <span class="n">massSolute</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">densitySolute</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">break</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">default</span><span style="color: #aa2211">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This break seems meeded</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84706">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumwidget.cpp:219</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">//the total number of tickmarks to draw (small and long)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">numberOfTickmarks</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">floor</span><span class="p">(<span class="bright">(</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>(</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">d</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">numberOfTickmarks</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">floor</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p">(</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">d<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not everything that had old style casts should have a cast at all</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15690#inline-84707">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spectrumwidget.cpp:362</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">int</span> <span class="n">left</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">Wavelength</span><span class="p">(<span class="bright">(</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">m_LMBPointPress</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">int</span> <span class="n">right</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">Wavelength</span><span class="p">(<span class="bright">(</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">e</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">int</span> <span class="n">left</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">Wavelength</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">m_LMBPointPress</span><span class="p">.</span><span class="n">x</span><span class="p">()<span class="bright">)</span></span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">(<span class="bright">)</span>));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">int</span> <span class="n">right</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">Wavelength</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><</span></span><span style="color: #aa4000">double<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="n">e</span><span style="color: #aa2211">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">()<span class="bright">)</span></span> <span style="color: #aa2211">/</span> <span class="n">width</span><span class="p">(<span class="bright">)</span>));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">He careful not to make things yet more complex with the casts.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R326 Kalzium</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15690">https://phabricator.kde.org/D15690</a></div></div><br /><div><strong>To: </strong>carlos_hdc, tcanabrava<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>