<table><tr><td style="">tstibor created this revision.<br />tstibor added reviewers: mutlaqja, lancaster.<br />Herald added a project: KDE Edu.<br />Herald added a subscriber: kde-edu.<br />tstibor requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15314">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Fix tons of warning such as:</p>
<p>/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpack.c: In function ‘fp_get_param’:<br />
/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpack.c:39:21: warning: passing argument 1 of ‘fp_msg’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">fp_msg ("Error: internal initialization error\n"); exit (-1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~</pre></div>
<p>In file included from /home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpack.c:10:0:<br />
/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpack.h:188:5: note: expected ‘char *’ but argument is of type ‘const char *’<br />
int fp_msg (char *msg);</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">^~~~~~</pre></div>
<p>/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpack.c:59:12: warning: passing argument 1 of ‘fp_msg’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">fp_msg ("Error: multiple compression flags\n");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~</pre></div>
<p>In file included from /home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpack.c:10:0:<br />
/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpack.h:188:5: note: expected ‘char *’ but argument is of type ‘const char *’<br />
int fp_msg (char *msg);</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">^~~~~~</pre></div>
<p>/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpack.c:67:12: warning: passing argument 1 of ‘fp_msg’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">fp_msg ("Error: multiple compression flags\n");</pre></div>
<p>...<br />
....<br />
and</p>
<p>/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpackutil.c:722:13: warning: passing argument 1 of ‘fp_tmpnam’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">fp_tmpnam("Tmp1", infits, outfits);
^~~~~~</pre></div>
<p>/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpackutil.c:123:5: note: expected ‘char *’ but argument is of type ‘const char *’<br />
int fp_tmpnam(char *suffix, char *rootname, char *tmpnam)</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">^~~~~~~~~</pre></div>
<p>/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpackutil.c:737:13: warning: passing argument 1 of ‘fp_tmpnam’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">fp_tmpnam("Tmpfile1", "", tempfilename);</pre></div>
<p>...<br />
...<br />
and<br />
/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpackutil.c: In function ‘fp_test_table’:<br />
/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpackutil.c:1913:67: warning: unused parameter ‘outfptr2’ [-Wunused-parameter]<br />
int fp_test_table (fitsfile *infptr, fitsfile *outfptr, fitsfile *outfptr2,</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">^~~~~~~~</pre></div>
<p>/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpackutil.c:1914:10: warning: unused parameter ‘fpvar’ [-Wunused-parameter]</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">fpstate fpvar, int *status)
^~~~~</pre></div>
<p>/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpackutil.c: In function ‘abort_fpack’:<br />
/home/tstibor/dev/astronomy/kstars/kstars/fitsviewer/fpackutil.c:2367:22: warning: unused parameter ‘sig’ [-Wunused-parameter]<br />
void abort_fpack(int sig)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15314">https://phabricator.kde.org/D15314</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kstars/fitsviewer/fpack.c<br />
kstars/fitsviewer/fpack.h<br />
kstars/fitsviewer/fpackutil.c</div></div></div><br /><div><strong>To: </strong>tstibor, mutlaqja, lancaster<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>