<table><tr><td style="">pino requested changes to this revision.<br />pino added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14939">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79852">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:80-81</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">int</span> <span class="n">x</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">p</span>ix</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span class="n">width</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">x</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="bright"></span><span class="n"><span class="bright">p</span>ix</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">p</span><span class="p">.</span><span class="n">drawPixmap</span><span class="p">(</span><span class="n">x</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">p</span>ix</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_P</span>ix</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span class="n">width</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">x</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="bright"></span><span class="n"><span class="bright">m_P</span>ix</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">p</span><span class="p">.</span><span class="n">drawPixmap</span><span class="p">(</span><span class="n">x</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">m_P</span>ix</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Given what <tt style="background: #ebebeb; font-size: 13px;">resizeEvent()</tt> does, this looks effectively dead code.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79853">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:184-185</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">FOV</span> <span style="color: #aa2211">=</span> <span class="n">KStars</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">map</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">fov</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span class="n"><span class="bright">m_</span>FOV</span> <span style="color: #aa2211">=</span> <span class="n">KStars</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">map</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">fov</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">FOV</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span class="n"><span class="bright">m_</span>FOV</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It is already initialized to 0, so there is no need to set it explicitly.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79854">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:200-206</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">QStringList</span></span><span class="bright"> </span><span class="n"><span class="bright">objects</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">o</span>bjects</span> <span style="color: #aa2211"><<</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Sun</span>"</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"M<span class="bright">ercury"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Venus</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">o</span>bjects</span> <span style="color: #aa2211"><<</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Earth</span>"</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Moon</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">objects</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Mars"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Phobos"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Deimos</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">objects</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Jupiter"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Ganymede"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Io"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Callisto"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Europa</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">objects</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Saturn"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Titan"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Mimas"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Enceladus"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Tethys"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Dione"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Rhea"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Hyperion"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Iapetus"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Phoebe</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">objects</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Uranus"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Umbriel"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Ariel"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Miranda"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Titania"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Ober</span>on"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_ObjectNames</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Sun"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Mercury"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Venus"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_O</span>bject<span class="bright">Name</span>s</span> <span style="color: #aa2211"><<</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Earth</span>"</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"M<span class="bright">oon</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_O</span>bject<span class="bright">Name</span>s</span> <span style="color: #aa2211"><<</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Mars</span>"</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Phobos"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Deimos</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_ObjectNames</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Jupiter"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Ganymede"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Io"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Callisto"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Europa</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_ObjectNames</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Saturn"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Titan"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Mimas"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Enceladus"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Tethys"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Dione"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Rhea"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Hyperion"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Iapetus"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Phoebe</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_ObjectNames</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Uranus"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Umbriel"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Ariel"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Miranda"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Titania"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Oberon</span>"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_ObjectNames</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Neptune"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Trit</span>on"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As I mentioned already in the previous review, I'm pretty sure kstars knows about these names already. Isn't it possible to get them from KStarsData, instead of duplicating them?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79858">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:235-253</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">l</span>atDisplay</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLabel</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">l</span>atDisplay</span><span style="color: #aa2211">-></span><span class="n">setToolTip</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"XPlanet Latitude, only valid when viewing the object from the same object"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">l</span>atDisplay</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">lat</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">l</span>atDisplay</span><span style="color: #aa2211">-></span><span class="n">setDisabled</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">selectorsLayout</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">l</span>atDisplay</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_L</span>atDisplay</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLabel</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_L</span>atDisplay</span><span style="color: #aa2211">-></span><span class="n">setToolTip</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"XPlanet Latitude, only valid when viewing the object from the same object"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_L</span>atDisplay</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_</span>lat</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_L</span>atDisplay</span><span style="color: #aa2211">-></span><span class="n">setDisabled</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">selectorsLayout</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_L</span>atDisplay</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">selectorsLayout</span><span style="color: #aa2211">-></span><span class="n">addWidget</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">QLabel</span><span class="p">(</span><span style="color: #766510">","</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Instead of this sequence of 5 labels (two of which are static ","), it'd be much better to have a single label, updating its text at once. This way, the layout spacing wouldnot make them look like different strings, while in reality this is a single location string. Also, the "," labels are not disabled, making the whole set of widgets look awkward when m_latDisplay/etc are disabled.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79867">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:257-259</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">f</span>reeRotate</span><span style="color: #aa2211">-></span><span class="n">setAttribute</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">WA_LayoutUsesWidgetRect</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">f</span>reeRotate</span><span style="color: #aa2211">-></span><span class="n">setMaximumSize</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span style="color: #601200">32</span><span class="p">,</span><span style="color: #601200">32</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">f</span>reeRotate</span><span style="color: #aa2211">-></span><span class="n">setMinimumSize</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span style="color: #601200">32</span><span class="p">,</span><span style="color: #601200">32</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_F</span>reeRotate</span><span style="color: #aa2211">-></span><span class="n">setAttribute</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">WA_LayoutUsesWidgetRect</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_F</span>reeRotate</span><span style="color: #aa2211">-></span><span class="n">setMaximumSize</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span style="color: #601200">32</span><span class="p">,</span><span style="color: #601200">32</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_F</span>reeRotate</span><span style="color: #aa2211">-></span><span class="n">setMinimumSize</span><span class="p">(</span><span class="n">QSize</span><span class="p">(</span><span style="color: #601200">32</span><span class="p">,</span><span style="color: #601200">32</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As I mentioned already, hardcoding these attributes is a bad UI. Please remove these three lines in all the buttons, let the style decide (following user preferences, which include accessibility).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79855">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:390</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">XPlanetTimeDisplay</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">xp</span>lanetTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">",  "</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">xp</span>lanetTime</span><span class="p">.</span><span class="n">time</span><span class="p">().</span><span class="n">toString</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_</span>XPlanetTimeDisplay</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_XP</span>lanetTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">",  "</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">m_XP</span>lanetTime</span><span class="p">.</span><span class="n">time</span><span class="p">().</span><span class="n">toString</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs i18n(), since it is a UI string.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79866">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:412-413</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">t</span>imeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"hours"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">t</span>imeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"mins"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">t</span>imeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"secs"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">t</span>imeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">setCurrentIndex</span><span class="p">(</span><span class="n">MINS</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_T</span>imeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"hours"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_T</span>imeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"mins"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_T</span>imeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"secs"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_T</span>imeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">setCurrentIndex</span><span class="p">(</span><span class="n">MINS</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No contractions please.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79860">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:683</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">fifoImageLoadWatcher</span><span class="p">.</span><span class="n">setFuture</span><span class="p">(</span><span class="n">QtConcurrent</span><span style="color: #aa2211">::</span><span class="n">run</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">XPlanetImageViewer</span><span style="color: #aa2211">::</span><span class="n">loadImage</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">QTimer</span><span style="color: #aa2211">::</span><span class="n">singleShot</span><span class="p">(</span><span class="n">timeout</span><span class="p">,</span><span style="color: #aa2211">&</span><span class="n">fifoImageLoadWatcher</span><span class="p">,</span><span class="n">SLOT</span><span class="p">(</span><span class="n">cancel</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">connect</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">fifoImageLoadWatcher</span><span class="p">,</span><span class="n">SIGNAL</span><span class="p">(</span><span class="n">finished</span><span class="p">()),</span><span style="color: #aa4000">this</span><span class="p">,</span><span class="n">SLOT</span><span class="p">(</span><span class="n">showImage</span><span class="p">()));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">A single-shot timer here is a bad idea, you must track the timer to propertly stop it when the xplanet execution finishes. Otherwise you can have the following scenario:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">start a rendering, a single-shot timer is fired</li>
<li class="remarkup-list-item">the rendering ends, but the timer still runs</li>
<li class="remarkup-list-item">start a new rendering, a new single-shot timer is fired</li>
<li class="remarkup-list-item">immediately the first timer fires, the second rendering is cancelled</li>
</ul></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79871">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:722</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QString</span> <span class="n">text</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"XPlanet Failed to generate the image for object %1 before the timeout expired.  Perhaps you need a longer timeout or there is something wrong with your XPlanet installation?"</span><span class="p">,</span> <span class="n">m_ObjectName</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">error</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">text</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"failed"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79868">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:819</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">setXPlanetDate</span><span class="p">(</span><span class="n">shiftedXPlanetTime</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">d</span>ateText</span> <span style="color: #aa2211">=</span> <span class="n">shiftedXPlanetTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">",  "</span> <span style="color: #aa2211">+</span> <span class="n">shiftedXPlanetTime</span><span class="p">.</span><span class="n">time</span><span class="p">().</span><span class="n">toString</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">t</span>imeEdit</span><span style="color: #aa2211">-></span><span class="n">setValue</span><span class="p">(</span><span class="n">timeShift</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_D</span>ateText</span> <span style="color: #aa2211">=</span> <span class="n">shiftedXPlanetTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">",  "</span> <span style="color: #aa2211">+</span> <span class="n">shiftedXPlanetTime</span><span class="p">.</span><span class="n">time</span><span class="p">().</span><span class="n">toString</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_T</span>imeEdit</span><span style="color: #aa2211">-></span><span class="n">setValue</span><span class="p">(</span><span class="n">timeShift</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs i18n(), since it is a UI string.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79869">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:854-857</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">newLat</span> <span style="color: #aa2211">></span> <span style="color: #601200">90</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">newLat</span> <span style="color: #aa2211">=</span> <span style="color: #601200">90</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">newLat</span> <span style="color: #aa2211"><</span> <span style="color: #aa2211">-</span><span style="color: #601200">90</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">newLat</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">-</span><span style="color: #601200">90</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can use qBound here...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79872">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:902-918</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">KStarsDateTime</span> <span class="n">utTime</span> <span style="color: #aa2211">=</span> <span class="n">KStarsData</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">geo</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">LTtoUT</span><span class="p">(</span><span class="n">time</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QString</span> <span class="n">year</span><span class="p">,</span> <span class="n">month</span><span class="p">,</span> <span class="n">day</span><span class="p">,</span> <span class="n">hour</span><span class="p">,</span> <span class="n">minute</span><span class="p">,</span> <span class="n">second</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">year</span><span class="p">.</span><span class="n">setNum</span><span class="p">(</span><span class="n">utTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">year</span><span class="p">()).</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">year</span><span class="p">.</span><span class="n">push_front</span><span class="p">(</span><span style="color: #766510">'0'</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">month</span><span class="p">.</span><span class="n">setNum</span><span class="p">(</span><span class="n">utTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">month</span><span class="p">()).</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">month</span><span class="p">.</span><span class="n">push_front</span><span class="p">(</span><span style="color: #766510">'0'</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As I said in the previous review, this whole method can use <tt style="background: #ebebeb; font-size: 13px;">toString()</tt> provided by KStarsDateTime.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79856">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:956</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright"></span><span class="n"><span class="bright">xp</span>lanetTime</span> <span style="color: #aa2211">=</span> <span class="n">timedialog</span><span style="color: #aa2211">-></span><span class="n">selectedDateTime</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">XPlanetTimeDisplay</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">xp</span>lanetTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">",  "</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">xp</span>lanetTime</span><span class="p">.</span><span class="n">time</span><span class="p">().</span><span class="n">toString</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span class="n"><span class="bright">m_XP</span>lanetTime</span> <span style="color: #aa2211">=</span> <span class="n">timedialog</span><span style="color: #aa2211">-></span><span class="n">selectedDateTime</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span class="n"><span class="bright">m_</span>XPlanetTimeDisplay</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_XP</span>lanetTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">",  "</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">m_XP</span>lanetTime</span><span class="p">.</span><span class="n">time</span><span class="p">().</span><span class="n">toString</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">int</span> <span class="n">timeShift</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs i18n(), since it is a UI string.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79857">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:970</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">xp</span>lanetTime</span> <span style="color: #aa2211">=</span> <span class="n">KStarsData</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">lt</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">XPlanetTimeDisplay</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">xp</span>lanetTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">",  "</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">xp</span>lanetTime</span><span class="p">.</span><span class="n">time</span><span class="p">().</span><span class="n">toString</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_XP</span>lanetTime</span> <span style="color: #aa2211">=</span> <span class="n">KStarsData</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">lt</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">m_</span>XPlanetTimeDisplay</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_XP</span>lanetTime</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">toString</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">",  "</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">m_XP</span>lanetTime</span><span class="p">.</span><span class="n">time</span><span class="p">().</span><span class="n">toString</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">int</span> <span class="n">timeShift</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs i18n(), since it is a UI string.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79848">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:1112-1113</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">new<span class="bright">URL</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">toLocal</span>File<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span>.</span><span class="n">endsWith</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">".png"</span><span class="p">))</span> <span style="color: #aa2211">==</span> <span style="color: #304a96">false</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">           <span class="n">new<span class="bright">URL</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">setPath</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">newURL</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">toLocal</span>File<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span> <span style="color: #aa2211">+</span> <span style="color: #766510">".png"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">newFile<span class="bright">Name</span></span><span class="p">.</span><span class="n">endsWith</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">".png"</span><span class="p">))</span> <span style="color: #aa2211">==</span> <span style="color: #304a96">false</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">           <span class="n">newFile<span class="bright">Name</span></span> <span style="color: #aa2211">+</span> <span style="color: #766510">".png"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is not needed, QFileDialog can do that already, see <tt style="background: #ebebeb; font-size: 13px;">setDefaultSuffix()</tt>; this means you cannot use the static method though.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79849">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:1118-1124</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">int</span> <span class="n">r</span> <span style="color: #aa2211">=</span> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">warningContinueCancel</span><span class="p">(</span><span class="n">parentWidget</span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                                                       <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"A file named </span><span style="color: #bb6622">\"</span><span style="color: #766510">%1</span><span style="color: #bb6622">\"</span><span style="color: #766510"> already exists. "</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                                                            <span style="color: #766510">"Overwrite it?"</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                                                            <span class="n">new<span class="bright">URL</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">f</span>ileName<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span>),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                                            <span class="n">new<span class="bright">F</span>ileName</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                                                       <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Overwrite File?"</span><span class="p">),</span> <span class="n">KStandardGuiItem</span><span style="color: #aa2211">::</span><span class="n">overwrite</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">r</span> <span style="color: #aa2211">==</span> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">Cancel</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QFileDialog does that by default (provided the file name is not changed).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79767">View Inline</a><span style="color: #4b4d51; font-weight: bold;">lancaster</span> wrote in <span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:688</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Yes, you are correct, it should be int.</p>

<p style="padding: 0; margin: 8px;">I think it is important to make it configurable because I have found that xplanet can take anywhere from a few milliseconds to several seconds to complete.  The time is not just dependent on the image size, a lot of it is due to the complexity of a rendering.  Jupiter is often very quickly rendered, except when it has a transit of one of its moons, then xplanet takes significantly longer to complete.  And we don't know when such events will occur in KStars currently.  The other issue would be computers, some computers could take longer to render complex images.  I think the user should be allowed to set the timeout based on personal preference.  They might want to give a complicated conjunction or transit time to render.  Or they might want it to stop before it spends too long trying to calculate a complicated one because it slows down their animation.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sure, and this is why I said that kstars can have a longer timeout on its own.<br />
Why e.g. 1 minute as timeout would not be enough, for example? Or make it 5 minutes -- still better than letting the user decide, which means that they can break the rendering for no reason...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79775">View Inline</a><span style="color: #4b4d51; font-weight: bold;">lancaster</span> wrote in <span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:749</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Nope, I just went back and checked.  fd here is not a leaked object, it is simply an int, the return value of a computation.  It isn't the file or the filename.  If it is 0, that means the command succeeded and -1 means it failed.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Then please rename the <tt style="background: #ebebeb; font-size: 13px;">fd</tt> variable to something else, since it is clearly not a file descriptor.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79865">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">//Image related</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QPixmap</span> <span class="bright"></span><span class="n"><span class="bright">pix</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QImage</span> <span class="n">m_Image</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QPixmap</span> <span class="bright"></span><span class="n"><span class="bright">m_Pix</span></span><span class="bright"> </span><span class="p"><span class="bright">{}</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QImage</span> <span class="n">m_Image<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">{}</span>;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This explicit {} initializer is not needed for Qt classes, since most of them (at least all the ones used here) have a default constructor already.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79821">View Inline</a><span style="color: #4b4d51; font-weight: bold;">lancaster</span> wrote in <span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:148-155</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Except that I used the enum values in a couple of places, particularly for Earth.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is not what I said. The enum is not referenced anywhere in this .h file, so it can be declared locally in the .cpp file.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79862">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kstars.kcfg:1086</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">      </entry>
</div><div style="padding: 0 8px; margin: 0 4px; ">      <entry name="XplanetAnimationDelay" type="String">
</div><div style="padding: 0 8px; margin: 0 4px; ">         <label>XPlanet Animation Delay</label>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">UInt here too</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79863">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kstars.kcfg:1091</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">      </entry>
</div><div style="padding: 0 8px; margin: 0 4px; ">      <entry name="XplanetWidth" type="String">
</div><div style="padding: 0 8px; margin: 0 4px; ">         <label>Width of xplanet window</label>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ditto</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79864">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kstars.kcfg:1096</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">      </entry>
</div><div style="padding: 0 8px; margin: 0 4px; ">      <entry name="XplanetHeight" type="String">
</div><div style="padding: 0 8px; margin: 0 4px; ">         <label>Height of xplanet window</label>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ditto</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79600">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mutlaqja</span> wrote in <span style="color: #4b4d51; font-weight: bold;">opsxplanet.ui:431</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">As noted previously, Requires Maps --> requires maps</p>

<p style="padding: 0; margin: 8px;">Also at least on Linux, there is xplanet-images package, is there more to it than that?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">As noted previously, Requires Maps --> requires maps</p></blockquote>

<p style="padding: 0; margin: 8px;">Still not changed (yet the comment was marked as "done"...).</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">Also at least on Linux, there is xplanet-images package, is there more to it than that?</p></blockquote>

<p style="padding: 0; margin: 8px;">This package split exists only on Debian, and derivatives.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14939">https://phabricator.kde.org/D14939</a></div></div><br /><div><strong>To: </strong>lancaster, yurchor, pino, mutlaqja, kde-edu<br /><strong>Cc: </strong>kde-edu, mutlaqja, pino, yurchor, narvaez, apol<br /></div>