<table><tr><td style="">pino requested changes to this revision.<br />pino added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14939">View Revision</a></tr></table><br /><div><div><p>I have more notes, but no time right now.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79576">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:688</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span class="n"><span class="bright">xplanetRunning</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">true</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">succeeded</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">xplanetProc</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">waitForFinished</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">Options</span><span style="color: #aa2211">::</span><span class="n">xplanetTimeout</span><span class="p">().</span><span class="n">toInt</span><span class="p">(<span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">int</span></span><span class="bright"> </span><span class="n"><span class="bright">timeout</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n">Options</span><span style="color: #aa2211">::</span><span class="n">xplanetTimeout</span><span class="p">().</span><span class="n">toInt</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/D14813" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D14813: Adding XPlanet Viewer</a> adds this option... as string?! if it's a number, then just use the proper type, i.e. <tt style="background: #ebebeb; font-size: 13px;">Int</tt>.</p>
<p style="padding: 0; margin: 8px;">Also, what is the use case to make this configurable? Why should users change/edit it?<br />
Ideally, kstars should just use a proper timeout on its own, possibly doing some estimation based on the data provided to xplanet (i.e. wait more if requesting a bigger image).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79577">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:708-712</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">while</span><span class="p">(</span><span class="n">fifoImageLoadWatcher</span><span class="p">.</span><span class="n">isRunning</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">time</span> <span style="color: #aa2211"><</span> <span class="n">timeout</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">time</span> <span style="color: #aa2211">+=</span> <span style="color: #601200">10</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QThread</span><span style="color: #aa2211">::</span><span class="n">msleep</span><span class="p">(</span><span style="color: #601200">10</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is synchronous, and ugly.</p>
<p style="padding: 0; margin: 8px;">Instead, use the signal of QFutureWatcher to know when it finishes. To implement a timeout, use a separate QTimer, to start when starting the computation, and stop when the future finishes -- if the timer fires, then cancel the future.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79578">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:749</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">int</span> <span class="n">fd</span> <span style="color: #aa2211">=</span><span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">((</span><span class="n">fd</span> <span style="color: #aa2211">=</span> <span class="n">mkfifo</span><span class="p">(</span><span class="n">file</span><span class="p">.</span><span class="n">fileName</span><span class="p">().</span><span class="n">toLatin1</span><span class="p">(),</span> <span class="n">S_IRUSR</span> <span style="color: #aa2211">|</span> <span class="n">S_IWUSR</span><span class="p">)</span> <span style="color: #aa2211"><</span> <span style="color: #601200">0</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">fd is leaked. Most probably you want to set it for the QFile object? (see <tt style="background: #ebebeb; font-size: 13px;">QFile::open()</tt> that takes a fd.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14939#inline-79579">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:148-155</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">typedef</span> <span style="color: #aa4000">enum</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">SUN</span><span class="p">,</span><span class="n">MERCURY</span><span class="p">,</span><span class="n">VENUS</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">EARTH</span><span class="p">,</span><span class="n">MOON</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">MARS</span><span class="p">,</span><span class="n">PHOBOS</span><span class="p">,</span><span class="n">DEIMOS</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">JUPITER</span><span class="p">,</span><span class="n">GANYMEDE</span><span class="p">,</span><span class="n">IO</span><span class="p">,</span><span class="n">CALLISTO</span><span class="p">,</span><span class="n">EUROPA</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">SATURN</span><span class="p">,</span><span class="n">TITAN</span><span class="p">,</span><span class="n">MIMAS</span><span class="p">,</span><span class="n">ENCELADUS</span><span class="p">,</span><span class="n">TETHYS</span><span class="p">,</span><span class="n">DIONE</span><span class="p">,</span><span class="n">RHEA</span><span class="p">,</span><span class="n">HYPERION</span><span class="p">,</span><span class="n">IAPETUS</span><span class="p">,</span><span class="n">PHOEBE</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">URANUS</span><span class="p">,</span><span class="n">UMBRIEL</span><span class="p">,</span><span class="n">ARIEL</span><span class="p">,</span><span class="n">MIRANDA</span><span class="p">,</span><span class="n">TITANIA</span><span class="p">,</span><span class="n">OBERON</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No need to have it as class member, just move it to the cpp file.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14939">https://phabricator.kde.org/D14939</a></div></div><br /><div><strong>To: </strong>lancaster, yurchor, pino, mutlaqja, kde-edu<br /><strong>Cc: </strong>kde-edu, mutlaqja, pino, yurchor, narvaez, apol<br /></div>