<table><tr><td style="">pino requested changes to this revision.<br />pino added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14813">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">all the visible UI strings <strong>must</strong> be translatable using i18n & friends</li>
<li class="remarkup-list-item">please cleanup the commit message, all the "merge branch" bits are not helpful (and beside that, the canonical location of kstars is git.kde.org, not github); also, please write more details on what is the feature, which code changes were done (e.g. code that was moved away form <tt style="background: #ebebeb; font-size: 13px;">SkyMap</tt>), etc</li>
<li class="remarkup-list-item">all the <tt style="background: #ebebeb; font-size: 13px;">this-></tt> stuff are not needed</li>
</ul>
<p>Also, IMHO a good idea is to use Designer to create the .ui file for the dialog, so it is easier to edit.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78500">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:49-50</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setSizePolicy</span><span class="p">(</span><span class="n">QSizePolicy</span><span style="color: #aa2211">::</span><span class="n">Preferred</span><span class="p">,</span> <span class="n">QSizePolicy</span><span style="color: #aa2211">::</span><span class="n">Expanding</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setFrameStyle</span><span class="p">(</span><span class="n">QFrame</span><span style="color: #aa2211">::</span><span class="n">StyledPanel</span> <span style="color: #aa2211">|</span> <span class="n">QFrame</span><span style="color: #aa2211">::</span><span class="n">Plain</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setLineWidth</span><span class="p">(</span><span style="color: #601200">2</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You are setting a non-empty frame, but then you are neither taking this into account when calculating the actual size in <tt style="background: #ebebeb; font-size: 13px;">resizeEvent</tt>, nor avoid to painting on the frame.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78498">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:70</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">XPlanetImageLabel</span><span style="color: #aa2211">::</span><span class="n">paintEvent</span><span class="p">(</span><span class="n">QPaintEvent</span> <span style="color: #aa2211">*</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can use the paint even object to know which parts were "damaged", and thus limit the <tt style="background: #ebebeb; font-size: 13px;">drawPixmap</tt> below to the interested region(s). This will speed up drawing a bit.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78497">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:75-77</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">x</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">pix</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span class="n">width</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">x</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">pix</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Considering that <tt style="background: #ebebeb; font-size: 13px;">resizeEvent</tt> resizes the pixmap to the window size, then this code is effectively dead...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78487">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:88</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">size</span><span class="p">().</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">w</span> <span style="color: #aa2211">&&</span> <span class="n">event</span><span style="color: #aa2211">-></span><span class="n">size</span><span class="p">().</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">h</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Just compare the sizes, eg</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="c++" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">event</span><span style="color: #aa2211">-></span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">pix</span><span class="p">.</span><span class="n">size</span><span class="p">())</span></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78488">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:132</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">objectSelector</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"Sun"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No way to get all the objects from some other kstars API, instead of hardcoding them all?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78490">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:139</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">objectSelector</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"Earth"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">objectSelector</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">" Moon"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is not exactly an ideal way to indent, and it will not work with some languages (beside that, translators can think the extra spaces are typos, and ingore them).<br />
Most probably you can get a similar effect by playing with the item model of the combobox, adding children to the top-level items.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78491">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:225</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">timeEdit</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLineEdit</span><span class="p">(</span><span style="color: #766510">"0"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">timeEdit</span><span style="color: #aa2211">-></span><span class="n">setMaximumWidth</span><span class="p">(</span><span style="color: #601200">50</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If this is supposed to be an integer value, then use the proper widget for it: QSpinBox.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78480">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:234-239</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">timeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"years"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">timeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"months"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">timeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"days"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">timeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"hours"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">timeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"mins"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">timeUnitsSelect</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"secs"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why not just use an enum for the time scale, adding each item to the combobox with its enum value?<br />
String comparison is not very efficient, and this will break with translations anyway.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78499">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:259</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">rotateEdit</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QLineEdit</span><span class="p">(</span><span style="color: #766510">"0"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">rotateEdit</span><span style="color: #aa2211">-></span><span class="n">setMaximumWidth</span><span class="p">(</span><span style="color: #601200">50</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QSpinBox...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78501">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:296-299</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">//If the caption is wider than the image, try to shrink the font a bit</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QFont</span> <span class="n">capFont</span> <span style="color: #aa2211">=</span> <span class="n">m_Caption</span><span style="color: #aa2211">-></span><span class="n">font</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">capFont</span><span class="p">.</span><span class="n">setPointSize</span><span class="p">(</span><span class="n">capFont</span><span class="p">.</span><span class="n">pointSize</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">2</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_Caption</span><span style="color: #aa2211">-></span><span class="n">setFont</span><span class="p">(</span><span class="n">capFont</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Playing with fonts is not a good idea, since it could make things unreadable.<br />
You might want to look at KSqueezedTextLabel (part of the KWidgetAddons framework).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78492">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:340</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Create xplanet process</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QProcess</span> <span style="color: #aa2211">*</span><span class="n">xplanetProc</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QProcess</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is leaked at every invocation.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78493">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:496</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">//qDebug() << "Run:" << xplanetProc->program() << args.join(" ");</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">xplanetProc</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is always true.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78504">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:499</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">xplanetProc</span><span style="color: #aa2211">-></span><span class="n">waitForFinished</span><span class="p">(</span><span style="color: #601200">1000</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">FOV</span> <span style="color: #aa2211">==</span> <span style="color: #766510">""</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_Caption</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span style="color: #766510">"XPlanet View: "</span> <span style="color: #aa2211">+</span> <span class="n">object</span> <span style="color: #aa2211">+</span> <span style="color: #766510">", "</span> <span style="color: #aa2211">+</span> <span class="n">dateText</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">isEmpty()</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78481">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:555-570</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">year</span><span class="p">,</span> <span class="n">month</span><span class="p">,</span> <span class="n">day</span><span class="p">,</span> <span class="n">hour</span><span class="p">,</span> <span class="n">minute</span><span class="p">,</span> <span class="n">second</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">year</span><span class="p">.</span><span class="n">setNum</span><span class="p">(</span><span class="n">time</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">year</span><span class="p">()).</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">year</span><span class="p">.</span><span class="n">push_front</span><span class="p">(</span><span style="color: #766510">'0'</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">month</span><span class="p">.</span><span class="n">setNum</span><span class="p">(</span><span class="n">time</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">month</span><span class="p">()).</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">month</span><span class="p">.</span><span class="n">push_front</span><span class="p">(</span><span style="color: #766510">'0'</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">day</span><span class="p">.</span><span class="n">setNum</span><span class="p">(</span><span class="n">time</span><span class="p">.</span><span class="n">date</span><span class="p">().</span><span class="n">day</span><span class="p">()).</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I see this was copied from skymap.cpp, but it is ugly and inefficient anyway.<br />
Since KStarsDateTime is a QDateTime, then just use its <tt style="background: #ebebeb; font-size: 13px;">toString()</tt> method to format this properly.</p>
<p style="padding: 0; margin: 8px;">Also, <tt style="background: #ebebeb; font-size: 13px;">date</tt> is used only as argument for xplanet in <tt style="background: #ebebeb; font-size: 13px;">startXplanet()</tt>, so just create & use it there directly, without storing it as class variable.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78482">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:675</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">error</span><span class="p">(</span><span style="color: #aa4000">nullptr</span><span class="p">,</span> <span class="n">file</span><span class="p">.</span><span class="n">errorString</span><span class="p">(),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Image Viewer"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">A bit more verbose text for the error mesage box would be useful, otherwise users just get e.g. "Input/output error" and that's it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78505">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:732-734</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">bool</span> <span class="n">initialLoad</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">isVisible</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #304a96">false</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">initialLoad</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="c++" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">const</span> <span style="color: #aa4000">bool</span> <span class="n">initialLoad</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">!</span><span class="n">isVisible</span><span class="p">();</span></pre></div>
<p style="padding: 0; margin: 8px;">much easier...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78479">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:748-749</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">resize</span><span class="p">(</span><span class="n">w</span><span class="p">,</span> <span class="n">image</span><span class="p">.</span><span class="n">height</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">resize</span><span class="p">(</span><span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">,</span> <span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">resize</span><span class="p">(</span><span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">,</span> <span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why this sequence of resize()?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78484">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:766</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QUrl</span> <span class="n">newURL</span> <span style="color: #aa2211">=</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">dialog</span><span class="p">.</span><span class="n">getSaveFileUrl</span><span class="p">(</span><span class="n">KStars</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">(),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Save Image"</span><span class="p">),</span> <span class="n">lastURL</span><span class="p">);</span> <span style="color: #74777d">// save-dialog with default filename</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Considering non-local URLs as save destination are not supported, then just use file paths (and QString) instead of urls (and QUrl). This will be less confusing, and simplify things a bit.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78483">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:767</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QUrl</span> <span class="n">newURL</span> <span style="color: #aa2211">=</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">dialog</span><span class="p">.</span><span class="n">getSaveFileUrl</span><span class="p">(</span><span class="n">KStars</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">(),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Save Image"</span><span class="p">),</span> <span class="n">lastURL</span><span class="p">);</span> <span style="color: #74777d">// save-dialog with default filename</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">newURL</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">getSaveFileUrl()</tt> is static, so call it as such, instead of constructing a QFileDialog on the stack (that won't be used, anyway).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78506">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.cpp:774</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">r</span> <span style="color: #aa2211">=</span> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">warningContinueCancel</span><span class="p">(</span><span style="color: #aa4000">static_cast</span><span style="color: #aa2211"><</span><span class="n">QWidget</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">parent</span><span class="p">()),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"A file named </span><span style="color: #bb6622">\"</span><span style="color: #766510">%1</span><span style="color: #bb6622">\"</span><span style="color: #766510"> already exists. "</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why the static_cast? Just use <tt style="background: #ebebeb; font-size: 13px;">parentWidget()</tt> instead.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78507">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:43</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QImage</span> <span class="n">m_Image</span><span class="p">;</span> <span style="color: #74777d">// XPlanetImageViewer needs access to the image in order to modify it</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #a0a000">protected</span><span class="p">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It does not, since there is <tt style="background: #ebebeb; font-size: 13px;">setImage()</tt> already.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78485">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">/** Create xplanet image viewer from Object */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">explicit</span> <span class="n">XPlanetImageViewer</span><span class="p">(</span><span class="n">QString</span> <span class="n">obj</span><span class="p">,</span> <span class="n">QWidget</span> <span style="color: #aa2211">*</span><span class="n">parent</span> <span style="color: #aa2211">=</span> <span class="n">nullptr</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">const QString &</tt> please.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78502">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:106</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QUrl</span> <span class="n">m_ImageUrl</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">bool</span> <span class="n">fileIsImage</span> <span class="p">{</span> <span style="color: #304a96">false</span> <span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is not set anywhere...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78486">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:115-116</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Share among image viewers</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">static</span> <span class="n">QUrl</span> <span class="n">lastURL</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why should different viewers share their last save location?</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">I open a viewer, and save to some location</li>
<li class="remarkup-list-item">I open another view, and save to a different location</li>
<li class="remarkup-list-item">now if I go back to the first viewer, and try to save again, I get the location of the second, which looks odd to me</li>
</ul></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78503">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:143-144</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">/** Saves file to disc. */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">saveFileToDisc</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">FYI, "disc" is usually the CD/DVD-ROM. The hard drive is "disk".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78494">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:151</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">updateXPlanetDate</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">timeShift</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">updateXPlanetObject</span><span class="p">(</span><span class="n">QString</span> <span class="n">obj</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">updateXPlanetTimeUnits</span><span class="p">(</span><span class="n">QString</span> <span class="n">units</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">const QString &</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14813#inline-78495">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xplanetimageviewer.h:152</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">updateXPlanetObject</span><span class="p">(</span><span class="n">QString</span> <span class="n">obj</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">updateXPlanetTimeUnits</span><span class="p">(</span><span class="n">QString</span> <span class="n">units</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">updateXPlanetTimeEdit</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">const QString &</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14813">https://phabricator.kde.org/D14813</a></div></div><br /><div><strong>To: </strong>lancaster, mutlaqja, pino<br /><strong>Cc: </strong>pino, mutlaqja, kde-edu, narvaez, apol<br /></div>