<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14653">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77428">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AdvancedTimer.qml:21</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span> <span style="color: #601200">2.1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Controls</span> <span style="color: #601200">1.0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">2.6</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77429">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NoteNames.qml:53</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// If the key pressed matches the note, pass the correct answer as parameter, else pass a wrong answer.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">event</span><span class="p">.</span><span style="color: #004012">key</span> <span style="color: #aa2211">===</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">Key_1</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">Activity</span><span class="p">.</span><span style="color: #004012">newNotesSequence</span><span class="p">[</span><span style="color: #004012">Activity</span><span class="p">.</span><span style="color: #004012">currentNoteIndex</span><span class="p">][</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">===</span> <span style="color: #766510">'C'</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">code should be factorised</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77430">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NoteNames.qml:57</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Activity</span><span class="p">.</span><span style="color: #004012">checkAnswer</span><span class="p">(</span><span style="color: #766510">"Z"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why Z? Isn't there a cleaner way to have an error?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77431">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NoteNames.qml:240</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #aa4000">percentage:</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">readonly</span> <span style="color: #004012">property</span> <span style="color: #004012">string</span> <span style="color: #aa4000">message:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"%1%"</span><span class="p">).</span><span style="color: #004012">arg</span><span class="p">(</span><span style="color: #004012">value</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">need a translator comment to understand the string</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77432">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NoteNames.qml:313</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Piano</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: piano2</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">width:</span> <span style="color: #004012">piano</span><span class="p">.</span><span style="color: #004012">width</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">should have a better id than piano2.<br />
And a comment to tell why you need 2 pianos, and not only one.<br />
Can using a Repeater here be better?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77433">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NoteNames.qml:341</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: shiftKeyboardLeft</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">source:</span> <span style="color: #766510">"qrc:/gcompris/src/core/resource/bar_next.svg"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">sourceSize.width:</span> <span style="color: #004012">piano</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">/</span> <span style="color: #601200">7</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">shouldn't it be bar_previous?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77434">View Inline</a><span style="color: #4b4d51; font-weight: bold;">note_names.js:22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">.</span><span style="color: #004012">pragma</span> <span style="color: #004012">library</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">.</span><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span> <span style="color: #601200">2.0</span> <span style="color: #004012">as</span> <span style="color: #004012">Quick</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">.</span><span style="color: #304a96">import</span> <span style="color: #766510">"qrc:/gcompris/src/core/core.js"</span> <span style="color: #004012">as</span> <span style="color: #004012">Core</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">version</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77435">View Inline</a><span style="color: #4b4d51; font-weight: bold;">note_names.js:43</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">var</span> <span style="color: #004012">objective</span> <span style="color: #aa2211">=</span> <span style="color: #004012">dataset</span><span class="p">.</span><span style="color: #004012">objective</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">objective</span> <span style="color: #aa2211">+=</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"<br>Note: Reference notes are red in color"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">introMessage</span><span class="p">.</span><span style="color: #004012">intro</span> <span style="color: #aa2211">=</span> <span class="p">[</span><span style="color: #004012">objective</span><span class="p">]</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you should never use += for appending strings as the order can change depending on the language.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77436">View Inline</a><span style="color: #4b4d51; font-weight: bold;">note_names.js:59</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">piano</span><span class="p">.</span><span style="color: #004012">coloredKeyLabels</span> <span style="color: #aa2211">=</span> <span style="color: #004012">dataset</span><span class="p">.</span><span style="color: #004012">referenceNotes</span><span class="p">[</span><span style="color: #004012">levels</span><span class="p">[</span><span style="color: #004012">currentLevel</span><span class="p">][</span><span style="color: #766510">"clef"</span><span class="p">]]</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">background</span><span class="p">.</span><span style="color: #004012">clefType</span> <span style="color: #aa2211">=</span> <span style="color: #004012">levels</span><span class="p">[</span><span style="color: #004012">currentLevel</span><span class="p">][</span><span style="color: #766510">"clef"</span><span class="p">]</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">piano</span><span class="p">.</span><span style="color: #004012">currentOctaveNb</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">first compute items.background.clefType and use it in items.piano.coloredKeyLabels</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77437">View Inline</a><span style="color: #4b4d51; font-weight: bold;">note_names.js:87</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">targetNotes</span> <span style="color: #aa2211">=</span> <span style="color: #004012">JSON</span><span class="p">.</span><span style="color: #004012">parse</span><span class="p">(</span><span style="color: #004012">JSON</span><span class="p">.</span><span style="color: #004012">stringify</span><span class="p">(</span><span style="color: #004012">levels</span><span class="p">[</span><span style="color: #004012">currentLevel</span><span class="p">][</span><span style="color: #766510">"sequence"</span><span class="p">]))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">i</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span style="color: #004012">i</span> <span style="color: #aa2211"><</span> <span style="color: #004012">currentLevel</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">newNotesSequence</span><span class="p">.</span><span style="color: #004012">length</span> <span style="color: #aa2211"><</span> <span style="color: #601200">25</span><span class="p">;</span> <span style="color: #004012">i</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">levels</span><span class="p">[</span><span style="color: #004012">currentLevel</span><span class="p">][</span><span style="color: #766510">"clef"</span><span class="p">]</span> <span style="color: #aa2211">===</span> <span style="color: #004012">levels</span><span class="p">[</span><span style="color: #004012">i</span><span class="p">][</span><span style="color: #766510">"clef"</span><span class="p">])</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">hardcoded 25, 50 is not good</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77438">View Inline</a><span style="color: #4b4d51; font-weight: bold;">note_names.js:125</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">progressBar</span><span class="p">.</span><span style="color: #004012">percentage</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">progressBar</span><span class="p">.</span><span style="color: #004012">percentage</span> <span style="color: #aa2211">-</span> <span style="color: #601200">4</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">multipleStaff</span><span class="p">.</span><span style="color: #004012">resumeNoteAnimation</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">4 is harcoded</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14653#inline-77439">View Inline</a><span style="color: #4b4d51; font-weight: bold;">note_names.js:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">multipleStaff</span><span class="p">.</span><span style="color: #004012">resumeNoteAnimation</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">progressBar</span><span class="p">.</span><span style="color: #004012">percentage</span> <span style="color: #aa2211">+=</span> <span style="color: #601200">2</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">progressBar</span><span class="p">.</span><span style="color: #004012">percentage</span> <span style="color: #aa2211">===</span> <span style="color: #601200">100</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">hardcode</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14653">https://phabricator.kde.org/D14653</a></div></div><br /><div><strong>To: </strong>amankumargupta, GCompris: Activities<br /><strong>Cc: </strong>jjazeix, kde-edu, GCompris: Activities, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin<br /></div>