<table><tr><td style="">asemke added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12949">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12949#inline-66965">View Inline</a><span style="color: #4b4d51; font-weight: bold;">expression.cpp:174</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">connect</span><span class="p">(</span><span class="n">renderer</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">LatexRenderer</span><span style="color: #aa2211">::</span><span class="n">done</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">this</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">Expression</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">latexRendered</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">connect</span><span class="p">(</span><span class="n">renderer</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">LatexRenderer</span><span style="color: #aa2211">::</span><span class="n">error</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">this</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">Expression</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">latexRendered</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">renderer</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">LatexRenderer</span><span style="color: #aa2211">::</span><span class="n">done</span><span class="p">,</span> <span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span><span class="bright"> </span><span class="n">latexRendered<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">renderer</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">result</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span><span class="bright"> </span><span class="p"><span class="bright">}</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">renderer</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">LatexRenderer</span><span style="color: #aa2211">::</span><span class="n">error</span><span class="p">,</span> <span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span><span class="bright"> </span><span class="n">latexRendered<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">renderer</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">result</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span><span class="bright"> </span><span class="p"><span class="bright">}</span>);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why do we need these connects here at all? The rendering is blocking the GUI anyway if I see it correctly. Why not to simply call renderer->render() and then process the result in the same function? With this we can also create LatexRenderer on the stack, no need for new and deleteLater().</p>

<p style="padding: 0; margin: 8px;">Ideally the rendering of the result shouldn't be blocking. Do you see what is blocking here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12949#inline-66966">View Inline</a><span style="color: #4b4d51; font-weight: bold;">expression.cpp:207</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">delete</span> <span class="n">result</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why this delete here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12949#inline-66964">View Inline</a><span style="color: #4b4d51; font-weight: bold;">expression.h:28</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#include</span> <span class="cpf">"cantor_export.h"</span><span style="color: #304a96"></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#include</span> <span class="cpf">"latexrenderer.h"</span><span style="color: #304a96"></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">In case we really need the renderer in that function, you can use forward declaration here.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12949">https://phabricator.kde.org/D12949</a></div></div><br /><div><strong>To: </strong>sirgienko, asemke<br /><strong>Cc: </strong>kde-edu, asemke, narvaez, apol<br /></div>