<table><tr><td style="">sirgienko added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12074">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12074#252465" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12074#252465</a>, <a href="https://phabricator.kde.org/p/asemke/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@asemke</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12074#252018" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12074#252018</a>, <a href="https://phabricator.kde.org/p/sirgienko/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@sirgienko</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Well, it's better, but we still have problems:<br />
[...]</p></div>
</blockquote>
<p>I cannot reproduce this with lua 5.2.4. All commands in your test project file produce a correct output with my patch.<br />
<a href="https://phabricator.kde.org/F5819582" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F5819582: cantor_lua_multi_line.png</a></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">The problems seem to be either version dependent or there are some other timing issues involved here.</pre></div></div>
</blockquote>
<p>I have <tt style="background: #ebebeb; font-size: 13px;">Lua 5.2.4</tt> too. And I agree, that this is timing thing, because results time dependent.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;">
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I think, you also should change condition <tt style="background: #ebebeb; font-size: 13px;">if(m_currentExpression && !m_output.isEmpty() && m_output.trimmed().endsWith(QLatin1String(">")))</tt> in <tt style="background: #ebebeb; font-size: 13px;">luasession.cpp</tt>, because sometimes lua prints <tt style="background: #ebebeb; font-size: 13px;">> </tt> <strong>before</strong> ends work, and as you see, lua backend finishs work with command too early and lua output added to next entries.</p></blockquote>
<p>Did you try this? Does it work for you? Can you please provide the outputs in LuaExpression.cpp:70 for one of such multi-line commands where you still have problems with?</p></blockquote>
<p>Did you test with 'Reevaluate Entries automatically' option?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12074">https://phabricator.kde.org/D12074</a></div></div><br /><div><strong>To: </strong>sirgienko, Cantor, asemke<br /><strong>Cc: </strong>Cantor, KDE Edu, narvaez, apol<br /></div>