<table><tr><td style="">rishabhg added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12188">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12188#inline-61796">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in <span style="color: #4b4d51; font-weight: bold;">AddUpdateUser.qml:46</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">they are all strings?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">right, they are. <br />
Missed it some how</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12188#inline-61797">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in <span style="color: #4b4d51; font-weight: bold;">AddUpdateUser.qml:54</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">empy log?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ah! mistake</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12188#inline-61799">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in <span style="color: #4b4d51; font-weight: bold;">AddUpdateUser.qml:282</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">why do you need an empty user?<br />
If it is for: "NOTE: The first user created does not get saved until the focus from 'Date of birth' column is explicitly changed. Could not figure the reason for this", we should find the reason and fix it (force the focus change?)</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">why do we need an empty user ?</p></blockquote>
<p style="padding: 0; margin: 8px;">We need to have something in our model so that our delegates get displayed. Maybe a better solution exists <br />
I'll try something on my end.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">If it is for: "NOTE: The first user created does not get saved until the focus from 'Date of birth' column is explicitly changed. Could not figure the reason for this",</p></blockquote>
<p style="padding: 0; margin: 8px;">No. Also, just found out that this is the case for every user that's created.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">we should find the reason and fix it (force the focus change?)</p></blockquote>
<p style="padding: 0; margin: 8px;">forcing the focus change solves the problem.</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12188">https://phabricator.kde.org/D12188</a></div></div><br /><div><strong>To: </strong>rishabhg, jjazeix, timotheegiet<br /><strong>Cc: </strong>KDE Edu, narvaez, apol<br /></div>