<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12188">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12188#inline-61796">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AddUpdateUser.qml:46</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #004012">string</span> <span style="color: #aa4000">name:</span> <span style="color: #766510">""</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span style="color: #aa4000">dateOfBirth:</span> <span style="color: #766510">""</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span style="color: #aa4000">password:</span> <span style="color: #766510">""</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">they are all strings?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12188#inline-61797">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AddUpdateUser.qml:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">console</span><span class="p">.</span><span style="color: #004012">log</span><span class="p">(</span><span style="color: #766510">"name of the user: "</span><span class="p">,</span> <span style="color: #004012">name</span><span class="p">,</span> <span style="color: #766510">"date of birth of the user: "</span><span class="p">,</span> <span style="color: #004012">dateOfBirth</span><span class="p">,</span> <span style="color: #766510">"password : "</span><span class="p">,</span> <span style="color: #004012">password</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">console</span><span class="p">.</span><span style="color: #004012">log</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">empy log?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12188#inline-61799">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AddUpdateUser.qml:282</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">onClicked:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">user<span class="bright">ToUpdateModel</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">append</span></span><span class="bright"></span><span class="p"><span class="bright">({</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"name"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">""</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"dateOfBirth"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">""</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"password"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">""</span></span><span class="bright"></span><span class="p"><span class="bright">})</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #74777d"><span class="bright">// add empty </span>user<span class="bright"> at first index. The first user is always going to be empty</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">userToUpdateModel</span><span class="p">.</span><span style="color: #004012">insert</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span class="p">{</span><span style="color: #766510">"name"</span><span style="color: #aa2211">:</span> <span style="color: #766510">""</span><span class="p">,</span> <span style="color: #766510">"dateOfBirth"</span><span style="color: #aa2211">:</span> <span style="color: #766510">""</span><span class="p">,</span> <span style="color: #766510">"password"</span><span style="color: #aa2211">:</span> <span style="color: #766510">""</span><span class="p">})</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why do you need an empty user?<br />
If it is for: "NOTE: The first user created does not get saved until the focus from 'Date of birth' column is explicitly changed. Could not figure the reason for this", we should find the reason and fix it (force the focus change?)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12188#inline-61683">View Inline</a><span style="color: #4b4d51; font-weight: bold;">rishabhg</span> wrote in <span style="color: #4b4d51; font-weight: bold;">AddUpdateUser.qml:101</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">can you elaborate more ?<br />
change 'pc' to passwordColumn ?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">yes the aim is to understand the variable when we read them on the code. pc will mean nothing for a new person that will read the code where passwordColumn will tell him that it corresponds to the password column of the table</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12188">https://phabricator.kde.org/D12188</a></div></div><br /><div><strong>To: </strong>rishabhg, jjazeix, timotheegiet<br /><strong>Cc: </strong>KDE Edu, narvaez, apol<br /></div>