<table><tr><td style="">sirgienko added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11588">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>As to the fix of the actual problem you mentioned here, did you check the two lines I wrote in my previous comment? Can you please validate it also solves the problem on your side?</p></blockquote>
<p>No, it don't fix the problem. The problem is that we call <tt style="background: #ebebeb; font-size: 13px;">syntaxHighlighter</tt> in the <tt style="background: #ebebeb; font-size: 13px;">Worksheet</tt> constructor, which calls the <tt style="background: #ebebeb; font-size: 13px;">OctaveHighliter</tt> constructor, which calls the <tt style="background: #ebebeb; font-size: 13px;">OctaveSession::evaluateExpression</tt>, inside which a attempt is made to access the m_process method, which is initialized with nullptr (from <tt style="background: #ebebeb; font-size: 13px;">OctaveSession</tt> constructor).<br />
So, for Octave, we *need* call <tt style="background: #ebebeb; font-size: 13px;">login</tt> before <tt style="background: #ebebeb; font-size: 13px;">OctaveHighliter::constructor</tt>, or we have seg. fault.<br />
Or, We can add new state to Session::Status, because after Session constructor and before login calling status equals Status::Done and it incorrect state, I think (because session starts <tt style="background: #ebebeb; font-size: 13px;">evaluateExpression</tt>, if it isn't in Status::Running state, even if <tt style="background: #ebebeb; font-size: 13px;">login</tt> calling don't done and m_process equals <tt style="background: #ebebeb; font-size: 13px;">nullptr</tt>).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11588">https://phabricator.kde.org/D11588</a></div></div><br /><div><strong>To: </strong>sirgienko, Cantor<br /><strong>Cc: </strong>asemke, Cantor, KDE Edu, narvaez, apol<br /></div>