<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9360" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9360#inline-43081" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LetterInWord.qml:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #004012">alias</span> <span style="color: #aa4000">wordsModel:</span> <span style="color: #004012">wordsModel</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #004012">bool</span> <span style="color: #004012">isCaps</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #aa4000">currentMode:</span> <span style="color: #004012">normalModeWordCount</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">not a good variable name</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9360#inline-42659" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LetterInWord.qml:143</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">width:</span> <span style="color: #004012">column</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">-</span> <span style="color: #601200">50</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">isCaps</span> <span style="color: #aa2211">?</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Change to small letters"</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Change to capital letters"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">checked:</span> <span class="p">(</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">isCaps</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">true :</span> <span style="color: #000a65">false</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We can have a combobox with the 3 possible values instead: lowercase, uppercase and mixed (we randomly choose if lower or upper) and we can be more precise telling it's only the letter to find that will be in lower/uppercase (the words won't be affected by this setting).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9360#inline-43083" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LetterInWord.qml:152</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Activity</span><span class="p">.</span><span style="color: #004012">initLevel</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you should only reload the level on onSaveData where you need to store the value</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9360#inline-43085" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">letter-in-word.js:121</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">currentLetter</span> <span style="color: #aa2211">=</span> <span style="color: #004012">questions</span><span class="p">[</span><span style="color: #004012">currentSubLevel</span><span class="p">];</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">question</span> <span style="color: #aa2211">=</span> <span style="color: #004012">currentLetter</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">question</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">isCaps</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">currentLetter</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">toUpperCase</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #004012">currentLetter<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">animateX</span><span class="p">.</span><span style="color: #004012">restart</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if I'm not wrong (I didn't tested), there is a global configuration option to set all the texts in uppercase.<br />
If we choose lowercase for this activity (but there is uppercase in global configuration), we should check here that the letter is displayed in lowercase</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9360" rel="noreferrer">https://phabricator.kde.org/D9360</a></div></div><br /><div><strong>To: </strong>rohitdas, GCompris, GCompris: Improvements, jjazeix<br /><strong>Cc: </strong>jjazeix, KDE Edu, narvaez, apol<br /></div>