<table><tr><td style="">jjazeix requested changes to this revision.<br />jjazeix added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8349" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I think this fix should be part of the rework of the activity in <a href="https://phabricator.kde.org/T5935" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/T5935</a>. I'm not sure this fix would stay the same after it so it would be better to first rework the activity and apply this one if needed once the rework has been done.<br />
I guess we can attach this diff to the other fix (adding a note that it may be useful in case) and close the task currently associated to this diff.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8349#inline-35888" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LetterInWord.qml:292</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">anchors.topMargin:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">10</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">ApplicationInfo</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">ratio</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">anchors.topMargin:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">background</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">itemWidth</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0.5</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">anchors.leftMargin:</span> <span style="color: #601200">15</span> <span style="color: #aa2211">*</span> <span style="color: #004012">ApplicationInfo</span><span class="p">.</span><span style="color: #004012">ratio</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">anchors.rightMargin:</span> <span class="bright"></span><span style="color: #601200"><span class="bright">15</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">ApplicationInfo</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">ratio</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">anchors.rightMargin:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">repeatItem</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">width</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0.6</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the other one?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8349" rel="noreferrer">https://phabricator.kde.org/D8349</a></div></div><br /><div><strong>To: </strong>amankumargupta, jjazeix<br /><strong>Cc: </strong>jjazeix, KDE Edu, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin<br /></div>