<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127717/">https://git.reviewboard.kde.org/r/127717/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Mai 1st, 2016, 1:27 nachm. UTC, <b>Andreas Cord-Landwehr</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems to me that you try a too complicated approach. Using QTest like done for the automatic unit tests in /autotests is much more convenient.
In particular that includes the test in the ctest list and will be executed on the CI system automatically.
At least, for now I do not see anything in your test that really prevents using QTest.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By convention, automatic unit tests should go to autotests/ while in tests/ only special test applications should be located, e.g. for testing GUI interactions for specific components.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for your explanations, Andreas!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I now moved everything to autotests and found a much more elegant way to capture the qWarning output from the library. Besides this approach works fine with QTest.</p></pre>
<br />
<p>- Hartmut</p>
<br />
<p>On Mai 3rd, 2016, 3:46 nachm. UTC, Hartmut Riesenbeck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated Mai 3, 2016, 3:46 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When a KEduVocDocument which was constructed by the default constructor
becomes destructed, the error message "QFile::remove: Empty or null
file name" is given on stderr.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since the file name of the KAutoSaveFile was not set in the default
constructor, the KAutoSaveFile::remove() method in ~KEduVocDocument()
have given this error message. Removed this method call and the
following KAutoSaveFile::releaseLock(), because they are called in the
KAutoSaveFile destructor as well but with check for file name.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added unit test emptydocumenttest to proof the bugfix.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since I'm not a cmake expert, I hope the test was added in the right way. I would be thankful for improvements.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unit test emptydocumenttest</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/autotests/CMakeLists.txt <span style="color: grey">(05580b6c5e8ad88fd15971cc6194aa4c22ffb558)</span></li>
<li>keduvocdocument/autotests/emptydocumenttest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>keduvocdocument/keduvocdocument.cpp <span style="color: grey">(e8e48e90ef70477e18559936c3cb36fed492d543)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127717/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>