<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127591/">https://git.reviewboard.kde.org/r/127591/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 7th, 2016, 2:45 a.m. UTC, <b>Alexander Semke</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127591/diff/1/?file=455677#file455677line409" style="color: black; font-weight: bold; text-decoration: underline;">src/kdefrontend/spreadsheet/RandomValuesDialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">398</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">enableButton</span><span class="p">(</span><span class="n">KDialog</span><span class="o">::</span><span class="n">Ok</span><span class="p">,</span> <span class="nb">false</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">409</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QPushButton</span> <span class="o">*</span><span class="n">ok_button</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QPushButton</span><span class="p">(</span><span class="s">"&OK"</span><span class="p">,</span> <span class="k">this</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do you really want to create a new PushButton each time the user deletes or types in a new character for the parameter? Why not to get the button from the buttonBox and to disable it like it was done before?</p></pre>
</blockquote>
<p>On April 7th, 2016, 7:36 a.m. UTC, <b>Garvit Khatri</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All these problems are fixed in the new fix.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The issues are solved in the new fix. The new patch is at review request 127596 https://git.reviewboard.kde.org/r/127596/</p></pre>
<br />
<p>- Anu</p>
<br />
<p>On April 6th, 2016, 4:40 p.m. UTC, Anu Mittal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and Alexander Semke.</div>
<div>By Anu Mittal.</div>
<p style="color: grey;"><i>Updated April 6, 2016, 4:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
labplot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Removing obsolete functions and porting to Qt5 (KDialog to QDialog)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Successfully built.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdefrontend/datasources/FileInfoDialog.h <span style="color: grey">(111d1ba)</span></li>
<li>src/kdefrontend/datasources/FileInfoDialog.cpp <span style="color: grey">(69246d3)</span></li>
<li>src/kdefrontend/datasources/ImportFileDialog.h <span style="color: grey">(2d0f31c)</span></li>
<li>src/kdefrontend/datasources/ImportFileDialog.cpp <span style="color: grey">(395906b)</span></li>
<li>src/kdefrontend/datasources/ImportFileWidget.cpp <span style="color: grey">(29ada09)</span></li>
<li>src/kdefrontend/spreadsheet/RandomValuesDialog.h <span style="color: grey">(3f0f1f6)</span></li>
<li>src/kdefrontend/spreadsheet/RandomValuesDialog.cpp <span style="color: grey">(712ea60)</span></li>
<li>src/kdefrontend/spreadsheet/SortDialog.h <span style="color: grey">(9b519d3)</span></li>
<li>src/kdefrontend/spreadsheet/SortDialog.cpp <span style="color: grey">(d97b2c2)</span></li>
<li>src/kdefrontend/worksheet/ExportWorksheetDialog.cpp <span style="color: grey">(e24b87b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127591/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>