<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127558/">https://git.reviewboard.kde.org/r/127558/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated April 5, 2016, 8:14 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did refactoring for EntryFilter class. Separated the dialog code from EntryFilter into a new EntryFilterDialog class.
This has in my opinion some advantages:
+ Separation of filter class code from user interface code
+ Simplifies EntryFilter class
+ Because new dialog is crated on stack - automatic resource releasing
+ Fix coverty scan issue</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One integer member m_numSets was initilized with 0 and two pointer
members were removed by refactoring the EntryFilter class.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The code for a dialog window (where the two former pointers was used
for) was moved into a new created class EntyFilterDialog. The dialog
is now created as a stack object and will be removed properly when
goes out of scope.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(43fa66085d1694049898a76433d94c66c4442239)</span></li>
<li>src/collection/collection.cpp <span style="color: grey">(37b6b2e2cad56de9e6bdcead89f88063f8dde8d9)</span></li>
<li>src/collection/entryfilter.h <span style="color: grey">(ed49e6d642d4d12903d4ee0f384872c371d21e8d)</span></li>
<li>src/collection/entryfilter.cpp <span style="color: grey">(d332020da9cae17d221bd211950eb6349988a8e5)</span></li>
<li>src/collection/entryfilter.ui <span style="color: grey">(c5f3e4e2d3865dd2234474dd23328c25c5f3b029)</span></li>
<li>src/collection/entryfilterdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/collection/entryfilterdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/collection/entryfilterdialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127558/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>