<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127155/">https://git.reviewboard.kde.org/r/127155/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Andreas Cord-Landwehr</p>
<br />
<p>On Februar 29th, 2016, 10:03 nachm. UTC, Hartmut Riesenbeck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated Feb. 29, 2016, 10:03 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=350887">350887</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To make practice conjugations work two bugs had to be fixed:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The first bug was caused by uninitialized member variable m_toTranslation
in EntryFilter constructor. This caused that DocumentSettings could
not be loaded and EntryFilter::m_tenses was empty (later in
EntryFilter::cleanupInvalid method). Changed constructor to init
m_toTranslation from Prefs::learningLanguage() and m_fromTranslation
from Prefs::knownLanguage(). The second was not necessary to load the
document settings, but was inserted for the sake of order.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The member m_tenses is used in EntryFilter::cleanupInvalid method to
remove entries which don't have any of the tenses which are configured
for practice. Now that document settings was not loaded propperly before,
m_tenses is empty. Because m_tenses was empty, all entries were removed
and the error dialog was shown.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After this was fixed, it came out that the conjugation prcatice widget
didn't dispaly the verbs to_translation and from_translation. This was
causd by an incomplete initialisation of TestEntry objects in
EntryFilter::conjugationTestEntries method. This was fixed by init the
To- and From-Language of each new test enty from m_toTranslation and
m_fromTranslation of EntryFilter.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/collection/entryfilter.cpp <span style="color: grey">(5264226f9f9cf69d6c77fefd498ffbbc744b56e7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127155/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>