<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127156/">https://git.reviewboard.kde.org/r/127156/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated März 1, 2016, 8:43 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree to that the collectEntries() now does not reflect its complete
behavior. But from my understanding the expiring should be done before the
sorting into the filtered sets, because the change of grade and practice date
in expireEntries() would change the filter results in blockedEntries() and
minMaxGradeEntries().
So my suggestion is to introduce a new method named setupFilteredEntries() and
move the filtering part of collect entries into that. The order of method
calls in EntryFilter::entries() reflects now the logical sequence of operation.
Get all entries from the document, expire long time not trained vocables and
sort them into the different filter sets.
The method collectEntries() changed now in that way, that it only collects all
valid entries drom the document. But thad behavior refelcts now, for my opinion
its name.
By the way an unused debug function was commented out wich made compiler
warnings.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In EntryFilter::expireEntries() the set
EntryFilter::m_entries is checked for entries
which hasn't practiced for a defined amount of
time and decreases the grad if this was expired.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But at time of calling expireEntries() this could
not work because m_entries was not intialisised
and empty. The method call was moved to a place
where m_entries is filled and cleaned of invalid
entries.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/collection/entryfilter.h <span style="color: grey">(8eacf188d0d549c535efc55c22102d8a6aa88c62)</span></li>
<li>src/collection/entryfilter.cpp <span style="color: grey">(5264226f9f9cf69d6c77fefd498ffbbc744b56e7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127156/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>