<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124168/">https://git.reviewboard.kde.org/r/124168/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 24th, 2015, 9:35 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124168/diff/1/?file=381231#file381231line8" style="color: black; font-weight: bold; text-decoration: underline;">src/assistants/differentiate/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">8</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">kcoreaddons_desktop_to_json</span><span class="p">(</span><span class="s">cantor_differentiateassistant</span> <span class="s">differentiateassistant.desktop</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suggest just using json, rather than translating at compile-time. It doesn't buy you anything.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also you can consider using kcoreaddons_add_plugin macro.</p></pre>
</blockquote>
<p>On June 24th, 2015, 9:46 p.m. CEST, <b>Filipe Saraiva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suggest just using json, rather than translating at compile-time. It doesn't buy you anything.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks Aleix, but is it recommended? I did this way because the <a href="http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-guts/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">sebas's post</a> says: "You usually want to run this at build time, and not put it in your repo, since otherwise, changes to the .desktop file, for example translations, will not be picked up".</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's not the case anymore, l10n works. The desktop file can be dropped now, it's not needed anymore.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's what we did on KDevelop, KDE Connect, Purpose, etc.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On June 24th, 2015, 9:06 p.m. CEST, Filipe Saraiva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, and Sebastian Kügler.</div>
<div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated June 24, 2015, 9:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is a new way to load plugins in KDE Frameworks 5 way. I ported Cantor plugins support to it. Now Cantor is using K_PLUGIN_FACTORY_WITH_JSON, the plugin path is the same of Qt5 ($QT_PLUGIN_PATH) and different types of Cantor plugins are installed in different subdirectories (backends in backends in ${KDE_INSTALL_PLUGINDIR}/cantor/backends, assistants in ${KDE_INSTALL_PLUGINDIR}/cantor/assistants, and panels in ${KDE_INSTALL_PLUGINDIR}/cantor/panels). KPluginInfo was changed to KPluginMetaData too.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To do it I followed the documentation and <a href="http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-guts/" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">this post</a> about KDE Frameworks 5 plugins by sebas.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Build ok;</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The plugins are loaded correctly;</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Select some backend and see the Cantor loading assistants and panels;</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Utilized some assistants, panels and backends, looks like correct.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(50f26be)</span></li>
<li>src/assistants/advancedplot/CMakeLists.txt <span style="color: grey">(53da352)</span></li>
<li>src/assistants/advancedplot/advancedplotassistant.cpp <span style="color: grey">(a1a21ae)</span></li>
<li>src/assistants/differentiate/CMakeLists.txt <span style="color: grey">(3c722a1)</span></li>
<li>src/assistants/differentiate/differentiateassistant.cpp <span style="color: grey">(c8bafb1)</span></li>
<li>src/assistants/importpackage/CMakeLists.txt <span style="color: grey">(3db01e2)</span></li>
<li>src/assistants/importpackage/importpackageassistant.cpp <span style="color: grey">(e0a9b50)</span></li>
<li>src/assistants/integrate/CMakeLists.txt <span style="color: grey">(23d97fc)</span></li>
<li>src/assistants/integrate/integrateassistant.cpp <span style="color: grey">(601c6b2)</span></li>
<li>src/assistants/linearalgebra/creatematrix/CMakeLists.txt <span style="color: grey">(8829d06)</span></li>
<li>src/assistants/linearalgebra/creatematrix/creatematrixassistant.cpp <span style="color: grey">(3336604)</span></li>
<li>src/assistants/linearalgebra/eigenvalues/CMakeLists.txt <span style="color: grey">(b487099)</span></li>
<li>src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.cpp <span style="color: grey">(e4f0cd9)</span></li>
<li>src/assistants/linearalgebra/eigenvectors/CMakeLists.txt <span style="color: grey">(4c6d086)</span></li>
<li>src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.cpp <span style="color: grey">(d8e02b2)</span></li>
<li>src/assistants/linearalgebra/invertmatrix/CMakeLists.txt <span style="color: grey">(7e19591)</span></li>
<li>src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.cpp <span style="color: grey">(9799c6d)</span></li>
<li>src/assistants/plot2d/CMakeLists.txt <span style="color: grey">(2b02874)</span></li>
<li>src/assistants/plot2d/plot2dassistant.cpp <span style="color: grey">(11d9db8)</span></li>
<li>src/assistants/plot3d/CMakeLists.txt <span style="color: grey">(bbcac18)</span></li>
<li>src/assistants/plot3d/plot3dassistant.cpp <span style="color: grey">(6b2e764)</span></li>
<li>src/assistants/runscript/CMakeLists.txt <span style="color: grey">(280a237)</span></li>
<li>src/assistants/runscript/runscriptassistant.cpp <span style="color: grey">(bb8147d)</span></li>
<li>src/assistants/solve/CMakeLists.txt <span style="color: grey">(2c25598)</span></li>
<li>src/assistants/solve/solveassistant.cpp <span style="color: grey">(7ad1254)</span></li>
<li>src/backends/R/CMakeLists.txt <span style="color: grey">(5e44b3c)</span></li>
<li>src/backends/R/rbackend.cpp <span style="color: grey">(a0d9e6a)</span></li>
<li>src/backends/kalgebra/CMakeLists.txt <span style="color: grey">(46a5440)</span></li>
<li>src/backends/kalgebra/kalgebrabackend.cpp <span style="color: grey">(5d7fac9)</span></li>
<li>src/backends/lua/CMakeLists.txt <span style="color: grey">(082f37b)</span></li>
<li>src/backends/lua/luabackend.cpp <span style="color: grey">(30e258e)</span></li>
<li>src/backends/maxima/CMakeLists.txt <span style="color: grey">(ca48d90)</span></li>
<li>src/backends/maxima/maximabackend.cpp <span style="color: grey">(86843ef)</span></li>
<li>src/backends/null/CMakeLists.txt <span style="color: grey">(69ffff3)</span></li>
<li>src/backends/null/nullbackend.cpp <span style="color: grey">(602fd49)</span></li>
<li>src/backends/octave/CMakeLists.txt <span style="color: grey">(ee3ea92)</span></li>
<li>src/backends/octave/octavebackend.cpp <span style="color: grey">(9842364)</span></li>
<li>src/backends/python2/CMakeLists.txt <span style="color: grey">(02115ee)</span></li>
<li>src/backends/python2/python2backend.cpp <span style="color: grey">(61662ff)</span></li>
<li>src/backends/python3/CMakeLists.txt <span style="color: grey">(6937480)</span></li>
<li>src/backends/python3/python3backend.cpp <span style="color: grey">(c83f631)</span></li>
<li>src/backends/qalculate/CMakeLists.txt <span style="color: grey">(e0f1c3a)</span></li>
<li>src/backends/qalculate/plotassistant/CMakeLists.txt <span style="color: grey">(efdd2d2)</span></li>
<li>src/backends/qalculate/plotassistant/qalculateplotassistant.cpp <span style="color: grey">(1d0ae83)</span></li>
<li>src/backends/qalculate/qalculatebackend.cpp <span style="color: grey">(da866ab)</span></li>
<li>src/backends/sage/CMakeLists.txt <span style="color: grey">(131ad07)</span></li>
<li>src/backends/sage/sagebackend.cpp <span style="color: grey">(b1a1ef5)</span></li>
<li>src/backends/scilab/CMakeLists.txt <span style="color: grey">(4ce8200)</span></li>
<li>src/backends/scilab/scilabbackend.cpp <span style="color: grey">(0d47595)</span></li>
<li>src/cantor_part.cpp <span style="color: grey">(2e3d36d)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(9e33924)</span></li>
<li>src/lib/assistant.h <span style="color: grey">(f337591)</span></li>
<li>src/lib/assistant.cpp <span style="color: grey">(60c521f)</span></li>
<li>src/lib/backend.cpp <span style="color: grey">(5e64fe7)</span></li>
<li>src/lib/panelplugin.h <span style="color: grey">(ebb02fe)</span></li>
<li>src/lib/panelplugin.cpp <span style="color: grey">(1fa61d0)</span></li>
<li>src/lib/panelpluginhandler.cpp <span style="color: grey">(8c73405)</span></li>
<li>src/panelplugins/helppanel/CMakeLists.txt <span style="color: grey">(d8f785f)</span></li>
<li>src/panelplugins/helppanel/helppanelplugin.cpp <span style="color: grey">(4611576)</span></li>
<li>src/panelplugins/variablemgr/CMakeLists.txt <span style="color: grey">(88f66d1)</span></li>
<li>src/panelplugins/variablemgr/variablemanagerplugin.cpp <span style="color: grey">(6a7b448)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124168/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>