<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123825/">https://git.reviewboard.kde.org/r/123825/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.</div>
<div>By Filipe Saraiva.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KStandardDirs is deprecated for KF5. The library was ported to QStandardPaths. I used <a href="https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">porting notes page</a> about KStandardDirs to do it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests performed:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Maxima keywords loaded;
</em> Can find Python 3 executable and can run it;
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Sage keywords loaded;
</em> Open examples;
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> Process latex entries correctly;
</em> Export to latex format working correctly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Missing tests:
* Run and find R executable (I do not have R in my machine).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/R/rbackend.cpp <span style="color: grey">(e128520)</span></li>
<li>src/backends/R/rsession.cpp <span style="color: grey">(1d1aeac)</span></li>
<li>src/backends/maxima/maximakeywords.cpp <span style="color: grey">(1ea1a5c)</span></li>
<li>src/backends/maxima/maximasession.cpp <span style="color: grey">(a150194)</span></li>
<li>src/backends/maxima/testmaxima.cpp <span style="color: grey">(65111aa)</span></li>
<li>src/backends/python/pythonextensions.cpp <span style="color: grey">(665a628)</span></li>
<li>src/backends/python/pythonkeywords.cpp <span style="color: grey">(e3e425c)</span></li>
<li>src/backends/python3/python3session.cpp <span style="color: grey">(5846ba1)</span></li>
<li>src/backends/sage/sagekeywords.cpp <span style="color: grey">(2b6f763)</span></li>
<li>src/backends/scilab/scilabkeywords.cpp <span style="color: grey">(0ac8003)</span></li>
<li>src/cantor.cpp <span style="color: grey">(25d15b6)</span></li>
<li>src/latexentry.cpp <span style="color: grey">(0b8321d)</span></li>
<li>src/lib/expression.cpp <span style="color: grey">(2fb9286)</span></li>
<li>src/lib/latexrenderer.cpp <span style="color: grey">(75f7cda)</span></li>
<li>src/loadedexpression.cpp <span style="color: grey">(02c8790)</span></li>
<li>src/worksheet.cpp <span style="color: grey">(9ff8cf1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123825/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>