<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122412/">https://git.reviewboard.kde.org/r/122412/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Laszlo Papp and Rahul Chowdhury.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2015, 7:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khangman
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Default to "notes" theme from the harmattan ui.
Add theme choosing in the bottom toolbar.
Remove unused categoriesList method.
Install themes into khangman/themes/ rather than khangman/pics.
Added notes theme to standardthemes.xml file.
Changed background image from TileVertically to default Stretch.
Added new properties in khangman class as needed for currenttheme, themes
and backgroundUrl.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">TODO: Use theme letter colors and possibly placement also.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds, runs and theme changing works as far as I've checked. I've tried every theme and tried with no ~/.config/khangmanrc in place.
I would like to add the author of the notes theme, I think it was Eugene, but can't tell from the git log.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>themes/sea/CMakeLists.txt <span style="color: grey">(9cf46fce4f93f1e7b0860fdc0763b5bb1f3317bf)</span></li>
<li>themes/standardthemes.xml <span style="color: grey">(3134a9cb19f83a876084f1173a886af3f0b03cd3)</span></li>
<li>themes/winter/CMakeLists.txt <span style="color: grey">(9f1fe312d108a66cb0782c2ef09326820fda2d1f)</span></li>
<li>themes/desert/CMakeLists.txt <span style="color: grey">(c25958125998b841c54e1c5e9576bb051501bebd)</span></li>
<li>themes/notes/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qml/GamePage.qml <span style="color: grey">(7d60baad978d93198a0778bae48ee64c1240ac9d)</span></li>
<li>src/qml/khangman-background-landscape.png <span style="color: grey">()</span></li>
<li>src/qml/khangman-background-portrait.png <span style="color: grey">()</span></li>
<li>src/qml/main.qml <span style="color: grey">(05163836caa636f383a964d7dc7dfb4324447938)</span></li>
<li>themes/CMakeLists.txt <span style="color: grey">(f2a58a5758e3fa6cb3c70f56e9075ad57732a674)</span></li>
<li>themes/bees/CMakeLists.txt <span style="color: grey">(c127574d41b105c64513c13b926b9b3ed25b01ae)</span></li>
<li>src/khangman.h <span style="color: grey">(481fb5bd5f8ea8577f14fd4b7e2a26e14c6fedcc)</span></li>
<li>src/khangman.cpp <span style="color: grey">(094c20ec1a0e21b52ede6c4500a5649fa572bcda)</span></li>
<li>src/khangman.kcfg <span style="color: grey">(d4f402351881d2777a6f5a2dd25129fee571ed80)</span></li>
<li>src/khmthemefactory.cpp <span style="color: grey">(3e1a15f923ef31a8dede30456037f0209f2f3c81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122412/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>