<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122297/">https://git.reviewboard.kde.org/r/122297/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Inge Wallin, Rahul Chowdhury, and Souvik Das.</div>
<div>By Jeremy Whiting.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kanagram
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I took Sayan's SoK patch and updated it to work and added keyboard handling. It works pretty well in my opinion, but I wanted to get a second opinion before merging to master. This is what's on the letterbuttons branch in kanagram currently if you'd like to check it out from there to build and try it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It makes kanagram's letters buttons that are clickable to move up and down to create the answer from. It also adds keyboard handling like the previous lineinput worked. typing keys, backspace, etc. work fine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Enter isn't handled since if all the letters aren't used it's obviously going to be wrong. Solution checking is only done when all letters are used up this way. Makes it somewhat easier, imo.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, runs, plays fine in my testing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kanagramgame.cpp <span style="color: grey">(3d50cc7)</span></li>
<li>src/ui/Blackboard.qml <span style="color: grey">(ac5f356)</span></li>
<li>src/ui/LetterButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ui/main.qml <span style="color: grey">(ab52c34)</span></li>
<li>src/kanagramgame.h <span style="color: grey">(a236d47)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122297/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>