<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120254/">https://git.reviewboard.kde.org/r/120254/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On novembre 9th, 2014, 10:08 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So how are we going to proceed here? Is anyone willing to take reposnsability of the full commit? Should I ask for split reviews for the things i feel confident merging?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nobody seems to want to take care of this big chunk so i'm going to discard the change, as said i feel confident with some others but not with all of them, if you want to propose them separately i'll review them as i can.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On setembre 20th, 2014, 1:39 a.m. UTC, Martin Walch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Martin Walch.</div>
<p style="color: grey;"><i>Updated set. 20, 2014, 1:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">src/calculator/titrationCalculator.cpp:</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">replace</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if (!texto) {
QMessageBox::critical(this, "Error", "Unable to open " + file);
}
if (texto) {</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if (!texto) {
QMessageBox::critical(this, "Error", "Unable to open " + file);
} else {</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">to emphasize that they are logically alternative</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">src/calculator/titrationCalculator.cpp:
Fix "warning: 'cn' may be used uninitialized in this function".
As far as I see, this has no proper initialization at all and should
horribly fail. However, in all my tests it behaved as if it was properly
initialized with 0.0. Maybe there is some compiler (gcc) magic at work.
Nevermind. Just fix it.</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">libscience/spectrum.cpp:
this line goes wrong</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">double newInt = p->intensity * 1000 / maxInt;
because all three of p->intensity, 1000, and maxInt are Integers. Fix it
with floating point number 1000.0. (The method is not used anywhere in
Kalzium, but it is part of the libscience library)</p>
</blockquote>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">further cleanup of includes:</p>
</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">replace</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">#include <qclass.h></p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">#include <QtModule/QClass></p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">replace</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">#include <QtModule/QClass></p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">#include <QClass></p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">replace</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">#include <kclass.h></p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">#include <KClass></p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">replace</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">#include <QtModule></p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with the classes of QtModule that are actually necessary.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use forward declarations and move includes into cpp files</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">remove duplicate or unused includes</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(As a side note: single threaded build time reduced by roughly 5%)</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Drop C bindings in favor of explicit C++ bindings
(e.g. include cctype, not ctype.h and use std namespace)</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Replace abs() and isfinite() with their corresponding Qt equivalents
qAbs() and qIsFinite().</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Replace M_PI with const double PI = 3.141... as M_PI is bad for
portability.</p>
</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">compiling</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">running program</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>compoundviewer/kalziumglpart.h <span style="color: grey">(0881df1)</span></li>
<li>compoundviewer/kalziumglpart.cpp <span style="color: grey">(001399d)</span></li>
<li>compoundviewer/openbabel2wrapper.cpp <span style="color: grey">(85406e1)</span></li>
<li>libscience/chemicaldataobject.h <span style="color: grey">(55a40dc)</span></li>
<li>libscience/chemicaldataobject.cpp <span style="color: grey">(8fac92c)</span></li>
<li>libscience/element.h <span style="color: grey">(43979d9)</span></li>
<li>libscience/element.cpp <span style="color: grey">(762462f)</span></li>
<li>libscience/elementparser.h <span style="color: grey">(f3a8130)</span></li>
<li>libscience/elementparser.cpp <span style="color: grey">(7c5ecaf)</span></li>
<li>libscience/isotope.cpp <span style="color: grey">(91db538)</span></li>
<li>src/psetable/elementitem.cpp <span style="color: grey">(a2b238c)</span></li>
<li>src/psetable/numerationitem.h <span style="color: grey">(5cf8afb)</span></li>
<li>src/psetable/numerationitem.cpp <span style="color: grey">(574f74f)</span></li>
<li>src/psetable/periodictablescene.h <span style="color: grey">(c89044b)</span></li>
<li>src/psetable/periodictablescene.cpp <span style="color: grey">(5ea99c0)</span></li>
<li>src/psetable/periodictablestates.h <span style="color: grey">(f8258c3)</span></li>
<li>src/psetable/periodictablestates.cpp <span style="color: grey">(501b75e)</span></li>
<li>src/psetable/periodictableview.h <span style="color: grey">(366480e)</span></li>
<li>src/psetable/periodictableview.cpp <span style="color: grey">(9669e5b)</span></li>
<li>src/psetable/statemachine.h <span style="color: grey">(0cad142)</span></li>
<li>src/psetable/statemachine.cpp <span style="color: grey">(9ce8d58)</span></li>
<li>src/rsdialog.h <span style="color: grey">(930276c)</span></li>
<li>src/rsdialog.cpp <span style="color: grey">(64a6b60)</span></li>
<li>src/search.h <span style="color: grey">(83bcf66)</span></li>
<li>src/search.cpp <span style="color: grey">(7ff6464)</span></li>
<li>src/isotopetable/isotopeitem.h <span style="color: grey">(5b7840b)</span></li>
<li>src/isotopetable/isotopeitem.cpp <span style="color: grey">(b98155d)</span></li>
<li>src/isotopetable/isotopescene.cpp <span style="color: grey">(18f6a54)</span></li>
<li>src/isotopetable/isotopetabledialog.h <span style="color: grey">(4f075c5)</span></li>
<li>src/isotopetable/isotopetabledialog.cpp <span style="color: grey">(83fb000)</span></li>
<li>src/isotopetable/isotopeview.h <span style="color: grey">(54d3d97)</span></li>
<li>src/isotopetable/isotopeview.cpp <span style="color: grey">(dd6bc8e)</span></li>
<li>src/kalzium.h <span style="color: grey">(86e4a6d)</span></li>
<li>src/kalzium.cpp <span style="color: grey">(2e85cf8)</span></li>
<li>src/kalziumdataobject.h <span style="color: grey">(0d88856)</span></li>
<li>src/kalziumdataobject.cpp <span style="color: grey">(e962670)</span></li>
<li>src/kalziumelementproperty.h <span style="color: grey">(f8b3a67)</span></li>
<li>src/kalziumelementproperty.cpp <span style="color: grey">(c42ecd5)</span></li>
<li>src/kalziumgradienttype.cpp <span style="color: grey">(5130f85)</span></li>
<li>src/kalziumnumerationtype.cpp <span style="color: grey">(52275d0)</span></li>
<li>src/kalziumschemetype.h <span style="color: grey">(a6447d5)</span></li>
<li>src/kalziumschemetype.cpp <span style="color: grey">(d35a97c)</span></li>
<li>src/kalziumutils.h <span style="color: grey">(0938b34)</span></li>
<li>src/kalziumutils.cpp <span style="color: grey">(bae9c54)</span></li>
<li>src/kdeeduglossary.h <span style="color: grey">(3b47aee)</span></li>
<li>src/kdeeduglossary.cpp <span style="color: grey">(f561568)</span></li>
<li>src/legendwidget.h <span style="color: grey">(9794f07)</span></li>
<li>src/legendwidget.cpp <span style="color: grey">(b0a7ba0)</span></li>
<li>src/main.cpp <span style="color: grey">(ff492f0)</span></li>
<li>src/molcalcwidget.h <span style="color: grey">(a0581a0)</span></li>
<li>src/molcalcwidget.cpp <span style="color: grey">(784928a)</span></li>
<li>src/orbitswidget.cpp <span style="color: grey">(d94ccf1)</span></li>
<li>src/psetable/elementitem.h <span style="color: grey">(7dd7e30)</span></li>
<li>src/searchwidget.cpp <span style="color: grey">(17edc1b)</span></li>
<li>src/spectrumviewimpl.h <span style="color: grey">(881609f)</span></li>
<li>src/spectrumviewimpl.cpp <span style="color: grey">(f9c0488)</span></li>
<li>src/spectrumwidget.h <span style="color: grey">(4caecb4)</span></li>
<li>src/spectrumwidget.cpp <span style="color: grey">(2264590)</span></li>
<li>src/tableinfowidget.h <span style="color: grey">(dcfeea7)</span></li>
<li>src/tableinfowidget.cpp <span style="color: grey">(48eb865)</span></li>
<li>src/tablesdialog.h <span style="color: grey">(a04f4ad)</span></li>
<li>src/tablesdialog.cpp <span style="color: grey">(6dd126e)</span></li>
<li>src/tools/moleculeview.h <span style="color: grey">(73bf9b8)</span></li>
<li>src/tools/moleculeview.cpp <span style="color: grey">(7a6c9f3)</span></li>
<li>src/tools/obconverter.cpp <span style="color: grey">(04b557d)</span></li>
<li>src/unitsettingsdialog.h <span style="color: grey">(04d5cf0)</span></li>
<li>src/unitsettingsdialog.cpp <span style="color: grey">(4f50aca)</span></li>
<li>src/detailedgraphicaloverview.cpp <span style="color: grey">(5fb716b)</span></li>
<li>src/detailinfodlg.h <span style="color: grey">(e81802b)</span></li>
<li>src/detailinfodlg.cpp <span style="color: grey">(5932a7f)</span></li>
<li>src/elementdataviewer.h <span style="color: grey">(dba156e)</span></li>
<li>src/elementdataviewer.cpp <span style="color: grey">(49a2a18)</span></li>
<li>src/eqchemview.h <span style="color: grey">(59d3384)</span></li>
<li>src/eqchemview.cpp <span style="color: grey">(ebce0be)</span></li>
<li>src/exportdialog.h <span style="color: grey">(7aa5543)</span></li>
<li>src/exportdialog.cpp <span style="color: grey">(a21dc26)</span></li>
<li>src/gradientwidget_impl.h <span style="color: grey">(0521765)</span></li>
<li>src/gradientwidget_impl.cpp <span style="color: grey">(622717a)</span></li>
<li>src/isotopetable/isotopeguideview.h <span style="color: grey">(560f3ba)</span></li>
<li>src/isotopetable/isotopeguideview.cpp <span style="color: grey">(d96ce80)</span></li>
<li>plasmoid/applet/psePlasmoid/Periodictable.cpp <span style="color: grey">(5b75778)</span></li>
<li>plasmoid/engine/kalzium_engine.h <span style="color: grey">(3e46481)</span></li>
<li>plasmoid/engine/kalzium_engine.cpp <span style="color: grey">(36fce6f)</span></li>
<li>src/calculator/calculator.h <span style="color: grey">(cda195d)</span></li>
<li>src/calculator/calculator.cpp <span style="color: grey">(efe57aa)</span></li>
<li>src/calculator/concCalculator.h <span style="color: grey">(54c1fa1)</span></li>
<li>src/calculator/concCalculator.cpp <span style="color: grey">(785e77a)</span></li>
<li>src/calculator/gasCalculator.h <span style="color: grey">(4cbcecf)</span></li>
<li>src/calculator/gasCalculator.cpp <span style="color: grey">(adef7f5)</span></li>
<li>src/calculator/nuclearCalculator.h <span style="color: grey">(f0230f8)</span></li>
<li>src/calculator/nuclearCalculator.cpp <span style="color: grey">(488bd38)</span></li>
<li>src/calculator/titrationCalculator.h <span style="color: grey">(9880ebe)</span></li>
<li>src/calculator/titrationCalculator.cpp <span style="color: grey">(6c67887)</span></li>
<li>src/detailedQmlView.h <span style="color: grey">(6c30912)</span></li>
<li>src/detailedQmlView.cpp <span style="color: grey">(50321f5)</span></li>
<li>src/detailedgraphicaloverview.h <span style="color: grey">(49d9980)</span></li>
<li>plasmoid/applet/didyouknow/didyouknow.h <span style="color: grey">(4f402fe)</span></li>
<li>plasmoid/applet/didyouknow/didyouknow.cpp <span style="color: grey">(11a04a8)</span></li>
<li>plasmoid/applet/gasPlasmoid/gasCalculator.h <span style="color: grey">(f552742)</span></li>
<li>plasmoid/applet/gasPlasmoid/gasCalculator.cpp <span style="color: grey">(de78078)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/kalziumdataobject.h <span style="color: grey">(9189dea)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp <span style="color: grey">(e802100)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/nuclearCalculator.h <span style="color: grey">(d6ced65)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp <span style="color: grey">(dfcbc6d)</span></li>
<li>plasmoid/applet/psePlasmoid/Molmasscalculator.h <span style="color: grey">(ccd80e5)</span></li>
<li>plasmoid/applet/psePlasmoid/Molmasscalculator.cpp <span style="color: grey">(4b6acbe)</span></li>
<li>plasmoid/applet/psePlasmoid/Periodictable.h <span style="color: grey">(5c130cc)</span></li>
<li>libscience/isotopeparser.h <span style="color: grey">(c59aff4)</span></li>
<li>libscience/isotopeparser.cpp <span style="color: grey">(0e646c1)</span></li>
<li>libscience/moleculeparser.h <span style="color: grey">(3a41b8b)</span></li>
<li>libscience/moleculeparser.cpp <span style="color: grey">(35321cc)</span></li>
<li>libscience/parser.h <span style="color: grey">(9c9e209)</span></li>
<li>libscience/parser.cpp <span style="color: grey">(e34f189)</span></li>
<li>libscience/psetables.cpp <span style="color: grey">(d7e12a0)</span></li>
<li>libscience/spectrum.h <span style="color: grey">(3d43d6f)</span></li>
<li>libscience/spectrum.cpp <span style="color: grey">(9ce97a5)</span></li>
<li>libscience/spectrumparser.h <span style="color: grey">(1e60a1c)</span></li>
<li>libscience/spectrumparser.cpp <span style="color: grey">(c89c114)</span></li>
<li>libscience/tests/xmlreadingtest.cpp <span style="color: grey">(90a0e25)</span></li>
<li>plasmoid/applet/bodr/kalzium_plasma.h <span style="color: grey">(94083e2)</span></li>
<li>plasmoid/applet/bodr/kalzium_plasma.cpp <span style="color: grey">(6f312b3)</span></li>
<li>plasmoid/applet/concentrationPlasmoid/concentrationCalculator.h <span style="color: grey">(5c27286)</span></li>
<li>plasmoid/applet/concentrationPlasmoid/concentrationCalculator.cpp <span style="color: grey">(ac7f55b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120254/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>