<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121758/">https://git.reviewboard.kde.org/r/121758/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121758/diff/1/?file=337294#file337294line35" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">find_package</span><span class="p">(</span><span class="s">KDE4</span> <span class="s">4.6.80</span> <span class="s">REQUIRED</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"><span class="hl">#</span>find_package(KDE4 4.6.80 REQUIRED)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why commenting out code?
If it's of no use, remove it.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121758/diff/1/?file=337297#file337297line12" style="color: black; font-weight: bold; text-decoration: underline;">compoundviewer/widgets/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="err"><span class="hl">kde4_</span>add_<span class="hl">plugin</span>(kalziumuiwidgets</span> <span class="err">${kalziumui_PART_SRCS})</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_<span class="hl">library</span></span><span class="p">(</span><span class="s">kalziumuiwidgets</span> <span class="o">${</span><span class="nv">kalziumui_PART_SRCS</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should be:
add_library(kalziumuiwidgets MODULE...</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121758/diff/1/?file=337297#file337297line14" style="color: black; font-weight: bold; text-decoration: underline;">compoundviewer/widgets/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kalziumuiwidgets</span> <span class="o">${</span><span class="nv">OPENBABEL2_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">Q<span class="hl">T_QTDESIGNER_LIBRARY</span></span><span class="o">}</span> <span class="o">${</span><span class="nv">K<span class="hl">DE4_KDECORE_LIBS</span></span><span class="o">}</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kalziumuiwidgets</span> <span class="o">${</span><span class="nv">OPENBABEL2_LIBRARIES</span><span class="o">}</span> <span class="o">${</span><span class="nv">Q<span class="hl">t5::Designer</span></span><span class="o">}</span> <span class="o">${</span><span class="nv">K<span class="hl">F5::Core</span></span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should be Qt5::Designer rather than ${Qt5::Designer}.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And so on.</p></pre>
</div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There's plenty of new files, I think these are just renames, make sure the patch recognizes the other ones as removed. Also you can use the --find-copies-harder (or -M80) for better detection of those.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also most of this won't ever work, like I pointed out in a couple of places. Can you go through the C++ code as well? I don't think it's different steps really.</p></pre>
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On December 30th, 2014, 6:13 p.m. UTC, Anu Mittal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and Aleix Pol Gonzalez.</div>
<div>By Anu Mittal.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2014, 6:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kalzium CMakeLists.txt files updated to KF5</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">cmake.. gives</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Configuration done.
Generation done.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>compoundviewer/CMakeLists.txt <span style="color: grey">(0971248)</span></li>
<li>compoundviewer/widgets/CMakeLists.txt <span style="color: grey">(32f200a)</span></li>
<li>data/icons/CMakeLists.txt <span style="color: grey">(779ced5)</span></li>
<li>data/icons/hi16-actions-calculate.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-chemical.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-elempic.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-energies.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-eqchem.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-glossary.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-isotopemap.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-kalzium_molviewer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-kalzium_rs.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-kalzium_tables.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-legend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-misc.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-numbers.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-orbits.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-overview.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-plot.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-sidebar.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-spectrum.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-statematter.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-timeline.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi16-actions-tooltip.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-calculate.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-chemical.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-elempic.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-energies.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-eqchem.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-glossary.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-isotopemap.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-kalzium_molviewer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-kalzium_rs.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-kalzium_tables.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-legend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-numbers.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-orbits.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-overview.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(f4ab27b)</span></li>
<li>KalziumConfigureChecks.cmake <span style="color: grey">(e3197ac)</span></li>
<li>data/icons/hi22-actions-plot.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-sidebar.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-spectrum.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-statematter.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-timeline.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi22-actions-tooltip.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-calculate.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-chemical.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-elempic.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-energies.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-eqchem.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-glossary.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-isotopemap.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-kalzium_molviewer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-kalzium_rs.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-kalzium_tables.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-legend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-misc.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-numbers.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-orbits.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-overview.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-plot.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-sidebar.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-spectrum.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-statematter.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-timeline.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi32-actions-tooltip.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-calculate.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-chemical.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-energies.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-eqchem.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-glossary.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-isotopemap.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-kalzium_molviewer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-kalzium_rs.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-kalzium_tables.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-legend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-misc.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-numbers.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-orbits.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-overview.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-plot.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-sidebar.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-spectrum.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-statematter.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-timeline.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi48-actions-tooltip.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi64-actions-kalzium_molviewer.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi64-actions-kalzium_rs.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi64-actions-kalzium_tables.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hi64-actions-numbers.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-calculate.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-chemical.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-elempic.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-energies.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-eqchem.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-glossary.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-isotopemap.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-kalzium_molviewer.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-kalzium_rs.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-kalzium_tables.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-misc.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-numbers.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-orbits.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-overview.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-plot.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-sidebar.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-spectrum.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-statematter.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-timeline.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/icons/hisc-actions-tooltip.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(f04a92b)</span></li>
<li>libscience/CMakeLists.txt <span style="color: grey">(ac66132)</span></li>
<li>libscience/tests/CMakeLists.txt <span style="color: grey">(21c4f85)</span></li>
<li>plasmoid/applet/bodr/CMakeLists.txt <span style="color: grey">(e3ed33e)</span></li>
<li>plasmoid/applet/concentrationPlasmoid/CMakeLists.txt <span style="color: grey">(32ea556)</span></li>
<li>plasmoid/applet/didyouknow/CMakeLists.txt <span style="color: grey">(f6ca9e3)</span></li>
<li>plasmoid/applet/gasPlasmoid/CMakeLists.txt <span style="color: grey">(7d199bb)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/CMakeLists.txt <span style="color: grey">(4acfab6)</span></li>
<li>plasmoid/applet/psePlasmoid/CMakeLists.txt <span style="color: grey">(58da62f)</span></li>
<li>plasmoid/engine/CMakeLists.txt <span style="color: grey">(534a56d)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(3cefc58)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121758/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>