<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121374/">https://git.reviewboard.kde.org/r/121374/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 14th, 2014, 2:19 p.m. UTC, <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding the newly added python/pythonutils.h header: it would be better to make it just with declarations of helper functions, and do the actual implementations in python2/pythonutils.cpp and python3/pythonutils.cpp (to comple in each of them).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There you could add functions like:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">dbgPrefix()</code> -> returning "python2" in the python2 backend, etc
</em> <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">PyObjectToQString()</code> -> convert a <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">PyObject*</code> containing a Unicode string to QString</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All the code motion changes that touch python2 only stuff should be sent as separate RR.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have removed pythonutils.h now :)</p></pre>
<br />
<p>- Minh</p>
<br />
<p>On December 28th, 2014, 5:03 p.m. UTC, Minh Ngo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Minh Ngo.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2014, 5:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have meda some fixes in cmake files to find python3 correctly...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1)
a = 1
b = 2
print(a + b)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2)
import numpy as np
a = np.array([1, 2, 3])
print(a)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/python2/python2backend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/python3/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/python3/cantor_python3.knsrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/python3/python3backend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/python3/python3backend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/python3/python3backend.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/FindPythonLibs3.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/CMakeLists.txt <span style="color: grey">(e27c84d)</span></li>
<li>src/backends/R/cantor_r.knsrc <span style="color: grey">(02f9a1e)</span></li>
<li>src/backends/kalgebra/cantor_kalgebra.knsrc <span style="color: grey">(d0103eb)</span></li>
<li>src/backends/lua/cantor_lua.knsrc <span style="color: grey">(25165d0)</span></li>
<li>src/backends/maxima/cantor_maxima.knsrc <span style="color: grey">(7cccce8)</span></li>
<li>src/backends/octave/cantor_octave.knsrc <span style="color: grey">(735739a)</span></li>
<li>src/backends/python/pythonbackend.h <span style="color: grey">(553eef0)</span></li>
<li>src/backends/python/pythonbackend.cpp <span style="color: grey">(3f66f39)</span></li>
<li>src/backends/python/pythoncompletionobject.h <span style="color: grey">(1c220a5)</span></li>
<li>src/backends/python/pythonexpression.h <span style="color: grey">(aa34258)</span></li>
<li>src/backends/python/pythonexpression.cpp <span style="color: grey">(883c3ea)</span></li>
<li>src/backends/python/pythonsession.h <span style="color: grey">(3e716bc)</span></li>
<li>src/backends/python/pythonsession.cpp <span style="color: grey">(c252572)</span></li>
<li>src/backends/python2/CMakeLists.txt <span style="color: grey">(260c2f0)</span></li>
<li>src/backends/python2/cantor_python2.knsrc <span style="color: grey">(7ec699c)</span></li>
<li>src/backends/python2/python2backend.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121374/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>