<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121026/">https://git.reviewboard.kde.org/r/121026/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2014, 7:54 p.m. MST, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It looks good but takes a bit to rebase, conflicts with what's in master, mostly because of qt4->qt5 and kdelibs -> kf5 changes. Since this will go to master when it's ready we should probably rebase it right then review. I can try to finish rebasing it tomorrow if needed, otherwise I can push what I have if you want to finish it.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, I rebased it all and it builds and runs, but you should definitely take a look at what I changed. I pushed to collection-class-rebased branch. When I run I see "300 words left" on the dashboard, what other ui changes should I be looking for/at?</p></pre>
<br />
<p>- Jeremy</p>
<br />
<p>On November 6th, 2014, 5:34 p.m. MST, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and Jeremy Whiting.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2014, 5:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch fixes the so far non-working "due words" feature, which lets the user know how many words are due to practice in each collection in the dashboard.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As usual, testing on real-world data in my own studies.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>TODO <span style="color: grey">(3a694f5)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(3be2282)</span></li>
<li>src/collection/collection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/collection/collection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/collection/entryfilter.h <span style="color: grey">(72cf026)</span></li>
<li>src/collection/entryfilter.cpp <span style="color: grey">(4668e6f)</span></li>
<li>src/collection/testentry.h <span style="color: grey">(572cb26)</span></li>
<li>src/collection/testentry.cpp <span style="color: grey">(04ba8b9)</span></li>
<li>src/dashboard/barwidget.h <span style="color: grey">(bcefa6f)</span></li>
<li>src/dashboard/barwidget.cpp <span style="color: grey">(593cd71)</span></li>
<li>src/dashboard/collectionwidget.h <span style="color: grey">(814ece6)</span></li>
<li>src/dashboard/collectionwidget.cpp <span style="color: grey">(573e928)</span></li>
<li>src/dashboard/dashboard.h <span style="color: grey">(ac16592)</span></li>
<li>src/dashboard/dashboard.cpp <span style="color: grey">(55413fc)</span></li>
<li>src/practice/sessionmanagerbase.cpp <span style="color: grey">(b45e591)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121026/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>