<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120300/">https://git.reviewboard.kde.org/r/120300/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and Alexander Rieder.</div>
<div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated Oct. 1, 2014, 1:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is the first step to port of Cantor to Qt5/KF5. Folders of assistants, backends, and panelplugins are commented.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After apply this patch you can compile Cantor, but the binary have a seg fault.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some doubts to be investigated:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">CMakeLists need review -- maybe it is missing something;</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Verify if the <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">set_target_properties</em> in src/CMakeLists.txt is correct (see <a href="https://community.kde.org/Frameworks/Porting_Notes#Build_System" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Porting Notes reference</a>)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Is kdemacros.h (in src/lib/cantor_macros.h and src/lib/cantor_export.h) available in KF5?</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">What do I do with <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">setComponentData</em> in src/cantor_part.cpp:73? Is it deprecated (see <a href="https://community.kde.org/Frameworks/Porting_Notes#KComponentData" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Porting Notes reference</a>)?</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Maybe KParts::ReadWriteParts in src/cantor_part.h:53 is referencing the old KDELibs4 version, not KF5. (Maybe a problem with my installation).</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, let's work in this review and I will fix the errors.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Thank you.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just apply the patch and compile Cantor.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/latexentry.h <span style="color: grey">(96eec0b)</span></li>
<li>src/latexentry.cpp <span style="color: grey">(e0fb7dd)</span></li>
<li>src/backends/CMakeLists.txt <span style="color: grey">(687e5d6)</span></li>
<li>src/cantor.h <span style="color: grey">(b401a9c)</span></li>
<li>src/cantor.cpp <span style="color: grey">(3278b59)</span></li>
<li>src/cantor.kcfg <span style="color: grey">(9698efb)</span></li>
<li>src/cantor_part.h <span style="color: grey">(3141c1f)</span></li>
<li>src/cantor_part.cpp <span style="color: grey">(9bb4be6)</span></li>
<li>src/commandentry.h <span style="color: grey">(4e4a186)</span></li>
<li>src/commandentry.cpp <span style="color: grey">(1ff93b4)</span></li>
<li>src/epsrenderer.cpp <span style="color: grey">(df9b47d)</span></li>
<li>src/imageentry.h <span style="color: grey">(2dc906d)</span></li>
<li>src/imageentry.cpp <span style="color: grey">(66480c1)</span></li>
<li>src/imageresultitem.h <span style="color: grey">(dd90bed)</span></li>
<li>src/imageresultitem.cpp <span style="color: grey">(f5adef5)</span></li>
<li>src/imagesettingsdialog.h <span style="color: grey">(73e9fd6)</span></li>
<li>src/imagesettingsdialog.cpp <span style="color: grey">(c12487b)</span></li>
<li>icons/hi32-app-cantor.png <span style="color: grey">(3f6bb9e733ed87bebc6e67497e19e73d1cc9548a)</span></li>
<li>icons/hi32-apps-cantor.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-app-cantor.png <span style="color: grey">(4bd7f0cb1ce177bcfda77d905fe81f960dfd7e1e)</span></li>
<li>icons/hi48-app-luabackend.png <span style="color: grey">(a41e6a93eb92a80fadfe085a96c81f6a80d8325e)</span></li>
<li>icons/hi48-app-maximabackend.png <span style="color: grey">(1438cdb635792253cc1cc416f6cab3e92a28d52b)</span></li>
<li>icons/hi48-app-octavebackend.png <span style="color: grey">(1e0b4edf147e6c180707795689699758fe1303f3)</span></li>
<li>icons/hi48-app-pythonbackend.png <span style="color: grey">(0dcbc64798ab5dd8b22742fc26a27c8b24ecc5e7)</span></li>
<li>icons/hi48-app-qalculatebackend.png <span style="color: grey">(88f56d31124aa8b89d734188b5abecf4123b3a09)</span></li>
<li>icons/hi48-app-rbackend.png <span style="color: grey">(ecd3601730f17289fcdb620cd7fd75d77840e80f)</span></li>
<li>icons/hi48-app-sagebackend.png <span style="color: grey">(3f44edea657b16b0905e75508037098ca49708e3)</span></li>
<li>icons/hi48-app-scilabbackend.png <span style="color: grey">(638d6f7feae1cd347fbcf08871c688e889f4818b)</span></li>
<li>icons/hi48-apps-cantor.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-apps-luabackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-apps-maximabackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-apps-octavebackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-apps-pythonbackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-apps-qalculatebackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-apps-rbackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-apps-sagebackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-apps-scilabbackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(c41bd26)</span></li>
<li>src/actionbar.h <span style="color: grey">(0e9ff55)</span></li>
<li>src/actionbar.cpp <span style="color: grey">(3633a57)</span></li>
<li>src/animation.h <span style="color: grey">(386b480)</span></li>
<li>src/animation.cpp <span style="color: grey">(b40ee8a)</span></li>
<li>src/animationresultitem.h <span style="color: grey">(a81217b)</span></li>
<li>src/animationresultitem.cpp <span style="color: grey">(8308997)</span></li>
<li>src/backendchoosedialog.h <span style="color: grey">(70d2144)</span></li>
<li>src/backendchoosedialog.cpp <span style="color: grey">(7162698)</span></li>
<li>CMakeLists.txt <span style="color: grey">(f712483)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(a232d13)</span></li>
<li>icons/CMakeLists.txt <span style="color: grey">(7affd27)</span></li>
<li>icons/hi16-app-cantor.png <span style="color: grey">(3d812df9c1b2b522afcdde169b368a549073ac1a)</span></li>
<li>icons/hi16-apps-cantor.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(3c6b84e)</span></li>
<li>src/lib/animationresult.cpp <span style="color: grey">(4874088)</span></li>
<li>src/lib/latexresult.cpp <span style="color: grey">(7e68a9b)</span></li>
<li>src/lib/panelplugin.h <span style="color: grey">(96639d0)</span></li>
<li>src/lib/panelplugin.cpp <span style="color: grey">(a65e9ca)</span></li>
<li>src/lib/panelpluginhandler.h <span style="color: grey">(d768c47)</span></li>
<li>src/lib/panelpluginhandler.cpp <span style="color: grey">(974a469)</span></li>
<li>src/lib/result.h <span style="color: grey">(904c149)</span></li>
<li>src/lib/result.cpp <span style="color: grey">(c9f3971)</span></li>
<li>src/lib/session.h <span style="color: grey">(0d83cbf)</span></li>
<li>src/lib/syntaxhelpobject.h <span style="color: grey">(fcde82c)</span></li>
<li>src/panelplugins/helppanel/CMakeLists.txt <span style="color: grey">(25110a7)</span></li>
<li>src/panelplugins/helppanel/helppanelplugin.h <span style="color: grey">(f180dea)</span></li>
<li>src/panelplugins/helppanel/helppanelplugin.cpp <span style="color: grey">(2fcb848)</span></li>
<li>src/panelplugins/variablemgr/CMakeLists.txt <span style="color: grey">(4b85fe4)</span></li>
<li>src/panelplugins/variablemgr/variablemanagerplugin.cpp <span style="color: grey">(39a9215)</span></li>
<li>src/panelplugins/variablemgr/variablemanagerwidget.h <span style="color: grey">(a24db45)</span></li>
<li>src/panelplugins/variablemgr/variablemanagerwidget.cpp <span style="color: grey">(fe2fda1)</span></li>
<li>src/placeholderentry.h <span style="color: grey">(0e306a6)</span></li>
<li>src/resultitem.cpp <span style="color: grey">(8502371)</span></li>
<li>src/scripteditorwidget.h <span style="color: grey">(0ab0930)</span></li>
<li>src/scripteditorwidget.cpp <span style="color: grey">(83e9510)</span></li>
<li>src/searchbar.h <span style="color: grey">(7e0bf3d)</span></li>
<li>src/searchbar.cpp <span style="color: grey">(e3a55f4)</span></li>
<li>src/textentry.h <span style="color: grey">(0dc6c5b)</span></li>
<li>src/textentry.cpp <span style="color: grey">(7ecfd81)</span></li>
<li>src/textresultitem.h <span style="color: grey">(e657203)</span></li>
<li>src/textresultitem.cpp <span style="color: grey">(4c89736)</span></li>
<li>src/worksheet.h <span style="color: grey">(087ecff)</span></li>
<li>src/worksheet.cpp <span style="color: grey">(1c64a48)</span></li>
<li>src/worksheetentry.h <span style="color: grey">(33cd4b4)</span></li>
<li>src/worksheetentry.cpp <span style="color: grey">(549f8fb)</span></li>
<li>src/worksheetimageitem.h <span style="color: grey">(7bbfe2f)</span></li>
<li>src/worksheetimageitem.cpp <span style="color: grey">(d239b43)</span></li>
<li>src/worksheettextitem.h <span style="color: grey">(dc468d2)</span></li>
<li>src/worksheettextitem.cpp <span style="color: grey">(fef2c33)</span></li>
<li>src/worksheettoolbutton.h <span style="color: grey">(74668fb)</span></li>
<li>src/worksheettoolbutton.cpp <span style="color: grey">(d3d0556)</span></li>
<li>src/worksheetview.h <span style="color: grey">(92eee43)</span></li>
<li>src/worksheetview.cpp <span style="color: grey">(ec79897)</span></li>
<li>src/lib/test/CMakeLists.txt <span style="color: grey">(4bf1742)</span></li>
<li>src/lib/test/backendtest.h <span style="color: grey">(d74bcd7)</span></li>
<li>src/lib/textresult.cpp <span style="color: grey">(c40896a)</span></li>
<li>src/loadedexpression.h <span style="color: grey">(f4dbf47)</span></li>
<li>src/loadedexpression.cpp <span style="color: grey">(715d16e)</span></li>
<li>src/main.cpp <span style="color: grey">(87e2f63)</span></li>
<li>src/pagebreakentry.h <span style="color: grey">(12520f6)</span></li>
<li>src/pagebreakentry.cpp <span style="color: grey">(9f71984)</span></li>
<li>src/lib/latexrenderer.h <span style="color: grey">(b28de5c)</span></li>
<li>src/lib/latexrenderer.cpp <span style="color: grey">(1952f8e)</span></li>
<li>src/lib/assistant.h <span style="color: grey">(969d820)</span></li>
<li>src/lib/assistant.cpp <span style="color: grey">(e2318a1)</span></li>
<li>src/lib/backend.h <span style="color: grey">(7f30420)</span></li>
<li>src/lib/backend.cpp <span style="color: grey">(db3c2c9)</span></li>
<li>src/lib/cantor_libs.kcfg <span style="color: grey">(fed5704)</span></li>
<li>src/lib/cantor_macros.h <span style="color: grey">(4b88958)</span></li>
<li>src/lib/completionobject.h <span style="color: grey">(60e2027)</span></li>
<li>src/lib/completionobject.cpp <span style="color: grey">(67275ea)</span></li>
<li>src/lib/defaulthighlighter.h <span style="color: grey">(ab5b232)</span></li>
<li>src/lib/defaulthighlighter.cpp <span style="color: grey">(ee49c2c)</span></li>
<li>src/lib/defaultvariablemodel.cpp <span style="color: grey">(e8c0f42)</span></li>
<li>src/lib/directives/plotdirectives.cpp <span style="color: grey">(9555d14)</span></li>
<li>src/lib/epsresult.h <span style="color: grey">(da85acc)</span></li>
<li>src/lib/epsresult.cpp <span style="color: grey">(1ff8fcd)</span></li>
<li>src/lib/expression.cpp <span style="color: grey">(f564546)</span></li>
<li>src/lib/extension.h <span style="color: grey">(c817443)</span></li>
<li>src/lib/extension.cpp <span style="color: grey">(e633139)</span></li>
<li>src/lib/helpresult.cpp <span style="color: grey">(e082171)</span></li>
<li>src/lib/imageresult.h <span style="color: grey">(70b8259)</span></li>
<li>src/lib/imageresult.cpp <span style="color: grey">(a147b59)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120300/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>