<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120292/">https://git.reviewboard.kde.org/r/120292/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and Aleix Pol Gonzalez.</div>
<div>By Marko Käning.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
analitza
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Insert a cast in free() call on OSX in order to avoid this:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Building CXX object analitzaplot<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>AnalitzaPlot.dir<span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">private</span><span style="color: #666666">/</span>utils<span style="color: #666666">/</span>marchingcubes.cpp.o
<span style="color: #BC7A00">[</span> <span style="color: #666666">65%</span><span style="color: #BC7A00">]</span> <span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>analitza<span style="color: #666666">/</span>calgebra<span style="color: #666666">/</span>main.cpp<span style="color: #666666">:157:3:</span> error<span style="color: #666666">:</span> no matching <span style="color: #008000; font-weight: bold">function</span> <span style="color: #008000; font-weight: bold">for</span> call to <span style="color: #BA2121">'free'</span>
free(he<span style="color: #666666">-></span>line);
<span style="color: #666666">^~~~</span>
<span style="border: 1px solid #FF0000">/usr/include/stdlib.h:143:7: note: candidate function not viable: no known conversion from 'const char *' to 'void *' for 1st argument; take the address of the argument with &</span>
<span style="color: #008000; font-weight: bold">void</span> free(<span style="color: #008000; font-weight: bold">void</span> <span style="color: #666666">*</span>);
<span style="color: #666666">^</span>
Building CXX object analitzaplot<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>AnalitzaPlot.dir<span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">private</span><span style="color: #666666">/</span>abstractplotitem.cpp.o
<span style="color: #666666">1</span> error generated.
make<span style="color: #BC7A00">[</span><span style="color: #666666">2</span><span style="color: #BC7A00">]</span><span style="color: #666666">:</span> <span style="color: #666666">***</span> <span style="color: #BC7A00">[</span>calgebra/CMakeFiles/calgebra.dir/main.cpp.o<span style="color: #BC7A00">]</span> <span style="color: #008000">Error</span> <span style="color: #666666">1</span>
make<span style="color: #BC7A00">[</span><span style="color: #666666">1</span><span style="color: #BC7A00">]</span><span style="color: #666666">:</span> <span style="color: #666666">***</span> <span style="color: #BC7A00">[</span>calgebra/CMakeFiles/calgebra.dir/<span style="color: #008000">all</span><span style="color: #BC7A00">]</span> <span style="color: #008000">Error</span> <span style="color: #666666">2</span>
make<span style="color: #BC7A00">[</span><span style="color: #666666">1</span><span style="color: #BC7A00">]</span><span style="color: #666666">:</span> <span style="color: #666666">***</span> Waiting <span style="color: #008000; font-weight: bold">for</span> unfinished jobs....
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">analitza builds fine w/o error</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wondering though, why HAVE_FREE_HISTORY_ENTRY is undefined...<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
(Does readline get properly detected on OSX?)</p>
</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>calgebra/main.cpp <span style="color: grey">(ddb5ab0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120292/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>