<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120238/">https://git.reviewboard.kde.org/r/120238/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Martin Walch.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2014, 9:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Across the project there are many coding styles with lots of different indentation patterns. There are three different tabs to space conversions (1:2, 1:4, 1:8), even mixed within individual files. This makes the code unnecessarily hard to read and to edit.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In the hope that I do not offend anybody: unify code style.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Roughly apply the style from kdelibs:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">get rid of all tabs</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">indentation is four spaces</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">unify includes and include guards</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">less blank lines</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">one space after "if", "for", etc.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">no space after cast</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">prefix operators ("++", "--") instead of postfix where applicable</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">pointers: preferably single space before "*" (same for "&")</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">opening curly braces on same line except for implementations</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">no whitespace after opening parenthesis "(" or before closing ones ")"</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">no single line "if", "for", "else", etc. (always curly braces)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">indent "case" to same level as corresponding "switch"</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">at least in some files adjust line wraps to a limit of 100 chars</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">exactly one newline at EOF</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also some formatting to copyright statements (I hope this is legally ok)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Additionally:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> fix some spelling errors<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
</em> constify& some foreach loops (suggested by krazy2)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
* replace some single char strings with chars (suggested by krazy2)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This whole patch fixes between 15 and 20 krazy2 warnings.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">compiling</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">starting the program (did not test all features)</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tablesdialog.cpp <span style="color: grey">(271d37c)</span></li>
<li>src/tools/moleculeview.h <span style="color: grey">(f58d69f)</span></li>
<li>src/tools/moleculeview.cpp <span style="color: grey">(c8af4f3)</span></li>
<li>src/tools/moleculewidgetplugin.h <span style="color: grey">(1b2b392)</span></li>
<li>src/tools/obconverter.h <span style="color: grey">(bb296b6)</span></li>
<li>src/tools/obconverter.cpp <span style="color: grey">(4f32302)</span></li>
<li>src/unitsettingsdialog.h <span style="color: grey">(5e6d5cf)</span></li>
<li>src/unitsettingsdialog.cpp <span style="color: grey">(5492860)</span></li>
<li>compoundviewer/kalziumglpart.h <span style="color: grey">(bb1fdc4)</span></li>
<li>compoundviewer/kalziumglpart.cpp <span style="color: grey">(749520d)</span></li>
<li>src/spectrumwidget.cpp <span style="color: grey">(db08cf6)</span></li>
<li>src/tableinfowidget.h <span style="color: grey">(01a93b1)</span></li>
<li>src/tableinfowidget.cpp <span style="color: grey">(d9ed673)</span></li>
<li>src/tablesdialog.h <span style="color: grey">(f6d4678)</span></li>
<li>plasmoid/applet/psePlasmoid/Periodictable.h <span style="color: grey">(5ec255e)</span></li>
<li>plasmoid/applet/psePlasmoid/Periodictable.cpp <span style="color: grey">(b9e0519)</span></li>
<li>plasmoid/engine/kalzium_engine.cpp <span style="color: grey">(301ab5d)</span></li>
<li>qml/Cell2.qml <span style="color: grey">(92969ae)</span></li>
<li>qml/CenterInformation.qml <span style="color: grey">(ca6c46c)</span></li>
<li>src/CMakeOCamlInstructions.cmake <span style="color: grey">(aa2b21a)</span></li>
<li>src/calculator/calculator.h <span style="color: grey">(2d3728f)</span></li>
<li>src/calculator/calculator.cpp <span style="color: grey">(96044a5)</span></li>
<li>src/calculator/concCalculator.h <span style="color: grey">(1e10fba)</span></li>
<li>src/calculator/concCalculator.cpp <span style="color: grey">(268077f)</span></li>
<li>src/calculator/gasCalculator.h <span style="color: grey">(2bba31a)</span></li>
<li>src/calculator/gasCalculator.cpp <span style="color: grey">(645c34f)</span></li>
<li>src/calculator/nuclearCalculator.h <span style="color: grey">(4b4882c)</span></li>
<li>src/calculator/nuclearCalculator.cpp <span style="color: grey">(1df965e)</span></li>
<li>src/calculator/titrationCalculator.h <span style="color: grey">(51a8d69)</span></li>
<li>src/calculator/titrationCalculator.cpp <span style="color: grey">(5738644)</span></li>
<li>src/detailedQmlView.h <span style="color: grey">(738b368)</span></li>
<li>src/detailedQmlView.cpp <span style="color: grey">(d55fc53)</span></li>
<li>src/detailedgraphicaloverview.h <span style="color: grey">(ba13a7b)</span></li>
<li>src/detailedgraphicaloverview.cpp <span style="color: grey">(d9c3173)</span></li>
<li>src/detailinfodlg.h <span style="color: grey">(64c2a8c)</span></li>
<li>src/detailinfodlg.cpp <span style="color: grey">(f3cdce3)</span></li>
<li>src/elementdataviewer.h <span style="color: grey">(eb8c776)</span></li>
<li>src/elementdataviewer.cpp <span style="color: grey">(ccb1195)</span></li>
<li>src/eqchemview.h <span style="color: grey">(1872a11)</span></li>
<li>src/eqchemview.cpp <span style="color: grey">(0e36a82)</span></li>
<li>src/exportdialog.h <span style="color: grey">(e0b95b2)</span></li>
<li>src/exportdialog.cpp <span style="color: grey">(aa2e789)</span></li>
<li>src/gradientwidget_impl.h <span style="color: grey">(4f27186)</span></li>
<li>src/gradientwidget_impl.cpp <span style="color: grey">(f33695f)</span></li>
<li>src/isotopetable/informationitem.h <span style="color: grey">(a247f3e)</span></li>
<li>src/isotopetable/informationitem.cpp <span style="color: grey">(bb14ec5)</span></li>
<li>src/isotopetable/isotopeguideview.h <span style="color: grey">(1557924)</span></li>
<li>src/isotopetable/isotopeguideview.cpp <span style="color: grey">(b833150)</span></li>
<li>src/isotopetable/isotopeitem.h <span style="color: grey">(39287c1)</span></li>
<li>src/isotopetable/isotopeitem.cpp <span style="color: grey">(5b416ab)</span></li>
<li>src/isotopetable/isotopescene.h <span style="color: grey">(e3a226c)</span></li>
<li>src/isotopetable/isotopescene.cpp <span style="color: grey">(8bbfdbd)</span></li>
<li>src/isotopetable/isotopetabledialog.h <span style="color: grey">(385b77b)</span></li>
<li>src/isotopetable/isotopetabledialog.cpp <span style="color: grey">(1f6f544)</span></li>
<li>src/isotopetable/isotopeview.h <span style="color: grey">(c16f99a)</span></li>
<li>src/isotopetable/isotopeview.cpp <span style="color: grey">(47c552d)</span></li>
<li>src/kalzium.h <span style="color: grey">(5d315e8)</span></li>
<li>src/kalzium.cpp <span style="color: grey">(265b38b)</span></li>
<li>src/kalziumdataobject.h <span style="color: grey">(98cae27)</span></li>
<li>src/kalziumdataobject.cpp <span style="color: grey">(931f3a3)</span></li>
<li>src/kalziumelementproperty.h <span style="color: grey">(2c24221)</span></li>
<li>src/kalziumelementproperty.cpp <span style="color: grey">(9062f6f)</span></li>
<li>src/kalziumgradienttype.h <span style="color: grey">(e68eec5)</span></li>
<li>src/kalziumgradienttype.cpp <span style="color: grey">(bfcbbd5)</span></li>
<li>src/kalziumnumerationtype.h <span style="color: grey">(61f6658)</span></li>
<li>src/kalziumnumerationtype.cpp <span style="color: grey">(78edd1d)</span></li>
<li>src/kalziumschemetype.h <span style="color: grey">(786641d)</span></li>
<li>src/kalziumschemetype.cpp <span style="color: grey">(65f6a91)</span></li>
<li>src/kalziumunitcombobox.h <span style="color: grey">(fd34ad6)</span></li>
<li>src/kalziumunitcombobox.cpp <span style="color: grey">(ed4e189)</span></li>
<li>src/kalziumutils.h <span style="color: grey">(99e4d97)</span></li>
<li>src/kalziumutils.cpp <span style="color: grey">(b35f729)</span></li>
<li>src/kdeeduglossary.h <span style="color: grey">(5e0071c)</span></li>
<li>src/kdeeduglossary.cpp <span style="color: grey">(84fe531)</span></li>
<li>src/legendwidget.h <span style="color: grey">(9e601d6)</span></li>
<li>src/legendwidget.cpp <span style="color: grey">(521204b)</span></li>
<li>src/main.cpp <span style="color: grey">(62c0166)</span></li>
<li>src/molcalcwidget.h <span style="color: grey">(84260c5)</span></li>
<li>src/molcalcwidget.cpp <span style="color: grey">(907cd6a)</span></li>
<li>src/orbitswidget.h <span style="color: grey">(4bc4dee)</span></li>
<li>src/orbitswidget.cpp <span style="color: grey">(373e7c8)</span></li>
<li>src/psetable/elementitem.h <span style="color: grey">(b805153)</span></li>
<li>src/psetable/elementitem.cpp <span style="color: grey">(db9b199)</span></li>
<li>src/psetable/numerationitem.h <span style="color: grey">(04b9289)</span></li>
<li>src/psetable/numerationitem.cpp <span style="color: grey">(9ff1fc5)</span></li>
<li>src/psetable/periodictablescene.h <span style="color: grey">(c429551)</span></li>
<li>src/psetable/periodictablescene.cpp <span style="color: grey">(8499bb0)</span></li>
<li>src/psetable/periodictablestates.h <span style="color: grey">(a3d77b7)</span></li>
<li>src/psetable/periodictablestates.cpp <span style="color: grey">(22df5d8)</span></li>
<li>src/psetable/periodictableview.h <span style="color: grey">(4460626)</span></li>
<li>src/psetable/periodictableview.cpp <span style="color: grey">(2dc37f0)</span></li>
<li>src/psetable/statemachine.h <span style="color: grey">(7f3a9c0)</span></li>
<li>src/psetable/statemachine.cpp <span style="color: grey">(20b76a7)</span></li>
<li>src/rsdialog.h <span style="color: grey">(d67ae3c)</span></li>
<li>src/rsdialog.cpp <span style="color: grey">(d784968)</span></li>
<li>src/search.h <span style="color: grey">(bf0c8b9)</span></li>
<li>src/search.cpp <span style="color: grey">(aacad93)</span></li>
<li>src/searchwidget.h <span style="color: grey">(5dddcd3)</span></li>
<li>src/searchwidget.cpp <span style="color: grey">(a4db6d8)</span></li>
<li>src/solver/README <span style="color: grey">(cf7a78f)</span></li>
<li>src/solver/calc.ml <span style="color: grey">(745f7c1)</span></li>
<li>src/solver/chem.ml <span style="color: grey">(2e0dd96)</span></li>
<li>src/solver/chemset.ml <span style="color: grey">(d813684)</span></li>
<li>src/solver/datastruct.ml <span style="color: grey">(541ed8c)</span></li>
<li>src/solver/lexer.ml <span style="color: grey">(e82d680)</span></li>
<li>src/solver/lexer.mll <span style="color: grey">(a6a4ab4)</span></li>
<li>src/solver/main.c <span style="color: grey">(d8e5e1b)</span></li>
<li>src/solver/main.ml <span style="color: grey">(f940f1d)</span></li>
<li>src/solver/modwrap.c <span style="color: grey">(84395a3)</span></li>
<li>src/solver/parser.mly <span style="color: grey">(41d91f3)</span></li>
<li>src/spectrumviewimpl.h <span style="color: grey">(bb31de2)</span></li>
<li>src/spectrumviewimpl.cpp <span style="color: grey">(03b7fbd)</span></li>
<li>src/spectrumwidget.h <span style="color: grey">(eb69685)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/nuclearCalculator.h <span style="color: grey">(0092f39)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp <span style="color: grey">(0e5ed5a)</span></li>
<li>plasmoid/applet/psePlasmoid/Molmasscalculator.h <span style="color: grey">(6c50ee2)</span></li>
<li>plasmoid/applet/psePlasmoid/Molmasscalculator.cpp <span style="color: grey">(1c7359d)</span></li>
<li>plasmoid/applet/didyouknow/didyouknow.h <span style="color: grey">(281439d)</span></li>
<li>plasmoid/applet/didyouknow/didyouknow.cpp <span style="color: grey">(6e96fba)</span></li>
<li>plasmoid/applet/gasPlasmoid/gasCalculator.h <span style="color: grey">(6ac9023)</span></li>
<li>plasmoid/applet/gasPlasmoid/gasCalculator.cpp <span style="color: grey">(0b3941a)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/kalziumdataobject.h <span style="color: grey">(e284ce8)</span></li>
<li>plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp <span style="color: grey">(4a07d8e)</span></li>
<li>compoundviewer/kalziumglwidget.h <span style="color: grey">(53e7070)</span></li>
<li>compoundviewer/kalziumglwidget.cpp <span style="color: grey">(ec7d918)</span></li>
<li>compoundviewer/libkdeedu_compoundviewer_export.h <span style="color: grey">(5b0bc7d)</span></li>
<li>compoundviewer/openbabel2wrapper.h <span style="color: grey">(d45cdf2)</span></li>
<li>compoundviewer/openbabel2wrapper.cpp <span style="color: grey">(4a7e0f8)</span></li>
<li>libscience/chemicaldataobject.h <span style="color: grey">(dd5d6d6)</span></li>
<li>libscience/chemicaldataobject.cpp <span style="color: grey">(66214f8)</span></li>
<li>libscience/element.h <span style="color: grey">(d81ec5e)</span></li>
<li>libscience/element.cpp <span style="color: grey">(1d1370d)</span></li>
<li>libscience/elementparser.h <span style="color: grey">(f7459e0)</span></li>
<li>libscience/elementparser.cpp <span style="color: grey">(3a09788)</span></li>
<li>libscience/isotope.h <span style="color: grey">(6565075)</span></li>
<li>libscience/isotope.cpp <span style="color: grey">(3c94ecc)</span></li>
<li>libscience/isotopeparser.h <span style="color: grey">(7e1107d)</span></li>
<li>libscience/isotopeparser.cpp <span style="color: grey">(040b8db)</span></li>
<li>libscience/libkdeedu_science_export.h <span style="color: grey">(e9343e5)</span></li>
<li>libscience/moleculeparser.h <span style="color: grey">(705154f)</span></li>
<li>libscience/moleculeparser.cpp <span style="color: grey">(377e315)</span></li>
<li>libscience/parser.h <span style="color: grey">(2cbfad3)</span></li>
<li>libscience/parser.cpp <span style="color: grey">(223463b)</span></li>
<li>libscience/psetables.h <span style="color: grey">(bdcbcdd)</span></li>
<li>libscience/psetables.cpp <span style="color: grey">(b8e5654)</span></li>
<li>libscience/spectrum.h <span style="color: grey">(14f5c42)</span></li>
<li>libscience/spectrum.cpp <span style="color: grey">(c9e4f27)</span></li>
<li>libscience/spectrumparser.h <span style="color: grey">(00f800a)</span></li>
<li>libscience/spectrumparser.cpp <span style="color: grey">(2209af3)</span></li>
<li>libscience/tests/isotopereadingtest.cpp <span style="color: grey">(1855a4e)</span></li>
<li>libscience/tests/spectrumreadingtests.cpp <span style="color: grey">(4eb582b)</span></li>
<li>libscience/tests/xmlreadingtest.cpp <span style="color: grey">(37f9a8f)</span></li>
<li>plasmoid/applet/bodr/kalzium_plasma.h <span style="color: grey">(975d9d9)</span></li>
<li>plasmoid/applet/bodr/kalzium_plasma.cpp <span style="color: grey">(a4d9912)</span></li>
<li>plasmoid/applet/concentrationPlasmoid/concentrationCalculator.h <span style="color: grey">(586387d)</span></li>
<li>plasmoid/applet/concentrationPlasmoid/concentrationCalculator.cpp <span style="color: grey">(32b38e5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120238/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>