<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119621/">https://git.reviewboard.kde.org/r/119621/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2014, 11:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Line-Line intersection is perfect and simple to implement with the existing model. Other Intersections are a bit challenging since they output more than one object (point) unlike the other commands ( which output just one object).<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
LineConic, Circle-Circle intersections seem fine to me but I have some trouble in understanding whether my approach is correctly assigning the output-label to the obtained intersection points ( while filling the m_objectMap). Please check whether the IntImp parameter I am passing to the IntersectionTypes is correct or not. ConicConic Intersections produce 4-points sometimes and they have been implemented as Line-Conic intersections in Kig. So, we have to find the Radical-Lines of the conics first before finding the intersection-points. Currently , there is an issue that the Radical-lines are also added to the document ( while they should not be ), but this should be simple to take care (If you give the go-ahead to this approach). </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Constrained points are must for Locus. I have implemented them , but the extra-handling required is making things a little ugly.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Locus is under progress...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I ran some basic tests for all the intersection cases which have been implemented. Seem ok. Only issue is with the conic-conic intersection case where we get the additional ConicRadical Lines which should be visible in Kig. However, this should be easy to take care of if this implementation survives.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>geogebra/geogebra.xsl <span style="color: grey">(4150e90)</span></li>
<li>geogebra/geogebratransformer.h <span style="color: grey">(5f36827)</span></li>
<li>geogebra/geogebratransformer.cpp <span style="color: grey">(aee8669)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119621/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>