<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118942/">https://git.reviewboard.kde.org/r/118942/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated July 18, 2014, 6:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Renamed foo to - 'section' and removed the state - 'readingFoo'. Added two vectors as members of the geogebraTransformer class to store names and descriptions of the macros. Moved the geogebra.xsl and geogebra.qrc files from the filters subdirectory to the geogebra subdirectory. However I have not yet checked with the compatibility of the C++11 features against an older compiler version. I installed the gcc version 3.4 but C++11 is not supported bu it. I am checking with some less older versions.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds support for Geogebra's tool files ( .ggt files ) in kig.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To open a tool file, open them from the open-file dialog ( and not from the types-dialog ).<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I tested with a tool which takes 2 points and gives a line , midpoint, and a circle from these two points.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Tested with another tool which took three points and gave a circle, hyperbola and an ellipse from these points.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Only those tools will be supported which contain only the geogebra-objects which are currently supported by kig.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4b2d286)</span></li>
<li>filters/geogebra-filter.h <span style="color: grey">(1b2b416)</span></li>
<li>filters/geogebra-filter.cpp <span style="color: grey">(53c9253)</span></li>
<li>filters/geogebra.qrc <span style="color: grey">(bfe493a)</span></li>
<li>filters/geogebra.xsl <span style="color: grey">(a0809da)</span></li>
<li>geogebra/geogebra-transformer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>geogebra/geogebra-transformer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>geogebra/geogebra.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>geogebra/geogebra.xsl <span style="color: grey">(PRE-CREATION)</span></li>
<li>modes/geogebra_tool_filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>modes/geogebra_tool_filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>modes/typesdialog.cpp <span style="color: grey">(d14d0fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118942/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>