<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119119/">https://git.reviewboard.kde.org/r/119119/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Andreas Xavier.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332596">332596</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Problem: The bug was that if the qstyled KLineEdit answerEdit held focus when the WrittenPracticeWidget was deleted, then a focus event passed to the deleted KLineEdit would be passed to the QStyleSheet and return an invalid pointer to an already deleted QStyle.
Fix: This patch sets the focus to helpLabel before the object is deleted. It does this by calling modeWidgetDestroyed(), which calls objectDestroyed() before the focus changing event will be invalid. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replicated the GUI conditions of the bug by hand, before and after the fix.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/parleymainwindow.cpp <span style="color: grey">(7c688a1)</span></li>
<li>src/practice/abstractwidget.h <span style="color: grey">(e9ef394)</span></li>
<li>src/practice/guifrontend.h <span style="color: grey">(60e6fdc)</span></li>
<li>src/practice/guifrontend.cpp <span style="color: grey">(99fc015)</span></li>
<li>src/practice/practicemainwindow.cpp <span style="color: grey">(31349aa)</span></li>
<li>src/practice/writtenpracticewidget.h <span style="color: grey">(9b25987)</span></li>
<li>src/practice/writtenpracticewidget.cpp <span style="color: grey">(f20ac6d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119119/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>