<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119044/">https://git.reviewboard.kde.org/r/119044/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Aleix Pol Gonzalez.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated July 1, 2014, 3:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated the patch so it builds and runs now. Though the ui only shows a white window. I must be loading the plasma package wrong. Any feedback is helpful though.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kanagram
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to KDE Frameworks and Qt5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Trying to port kanagram to qt5 and frameworks, but it's unable to find sharedkvtmlfiles.h header. It's not getting the includepath needed from the target_link_libraries like I thought it should, maybe something wrong with libkdeedu's Config.cmake file ?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(98903e6ffb7571ab3a9510c806a285418e7b0668)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(de841020cdf9ab67f121186a2f2756f4e5b1e547)</span></li>
<li>src/cmake/FindKanagramEngine.cmake <span style="color: grey">(0922adba8062b2557b077eba535919cb9452015c)</span></li>
<li>src/kanagramenginehelper.h <span style="color: grey">(a329be1a4454b98fc5e8042bf133a7a9d824bdf9)</span></li>
<li>src/kanagramenginehelper.cpp <span style="color: grey">(e16879fd1f43feac24a044d6515a6839d390ad70)</span></li>
<li>src/kanagramgame.cpp <span style="color: grey">(4fc7f4fe4a5e9f54620985e84e325d3bec581dd4)</span></li>
<li>src/kdeclarativemainwindow.h <span style="color: grey">(22ba0c6d7a4168592ad31c7d53da9a9935df1882)</span></li>
<li>src/kdeclarativemainwindow.cpp <span style="color: grey">(fcb7999e8e73521e09d29d7e4f2b943a335bf2d2)</span></li>
<li>src/kdeclarativeview.h <span style="color: grey">(649f78fc5aa04fd7bfcb129a107a3b966bc462fd)</span></li>
<li>src/kdeclarativeview.cpp <span style="color: grey">(432e3e1ae4248b91fb88324292473de17dee4cc4)</span></li>
<li>src/main.cpp <span style="color: grey">(05595cb5aae4b850cb0561b85a6e27a43d9033d1)</span></li>
<li>src/mainsettings.cpp <span style="color: grey">(19eb451385e9d3c6606c2cd4d868f1ade92f83a4)</span></li>
<li>src/mainwindow.h <span style="color: grey">(ffcb04d86e674a44a0a02c4165a0a39a33b66dc2)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(8a217a8c962437c388970efa31ca1a15f63f9b30)</span></li>
<li>src/vocabedit.cpp <span style="color: grey">(f41a6f435c06803628c6a0903ff31865a99f958c)</span></li>
<li>src/vocabsettings.cpp <span style="color: grey">(c331c705f0609547f60d353203d1535d9060e90f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119044/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>