<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118622/">https://git.reviewboard.kde.org/r/118622/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. Thanks a lot for this patch, it's one of those things that we were planning to do after the feature freeze.
Since you said to me that you don't have commit rights, I will commit it for you.</pre>
<br />
<p>- Inge Wallin</p>
<br />
<p>On June 9th, 2014, 7:09 a.m. UTC, Andreas Xavier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By Andreas Xavier.</div>
<p style="color: grey;"><i>Updated June 9, 2014, 7:09 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this is not the correct location for this patch, please inform me and I will submit it elsewhere.
If ingwa is not finished implementing this feature and I am stepping on toes, then please ignore this request.
Otherwise.
The recently implemented useful feature dual-direction training always uses the unknown language for the answer for
the mixed letter practice mode, when the mixed letter hint implies the known language is the answer.
Additionally, for multiple choice all of the incorrect options are in the unknown language
even when the answer is in the known language.
The patch uses currentEntry->languageTo() to select both the correct answer for written answers and the correct options for multiple choice questions.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Played the game to verify both directions worked.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/practice/sessionmanagerbase.cpp <span style="color: grey">(db9e372)</span></li>
<li>src/practice/writtenpracticevalidator.h <span style="color: grey">(0bea4e1)</span></li>
<li>src/practice/writtenpracticevalidator.cpp <span style="color: grey">(c45a40b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118622/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>