<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118068/">https://git.reviewboard.kde.org/r/118068/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu, Amarvir Singh and Andreas Cord-Landwehr.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated May 12, 2014, 1:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here is version 2. All issues pointed out by Andreas are fixed except one that I found out of scope of this patch.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements what we discussed on the mailing list, namely the early training stages before waiting 1 day to train a word again makes sense. It works exactly like in the later stages except:
- The intervals are much shorter (3.5 minutes to 8 hours)
- The intervals are not configurable
- There is no nice animation of boxes/diamonds/whatever.
I opted to use the pregrade element in the updated kvtml libraries rather than the interval element, also like discussed on the mailing list.
I have used this myself in my own language training and it works well and with excellent results I may add.
Work that remains to be done is on this feature:
- Improve statistics. This should be done so that it can also handle double-directed training
- Possibly improve the visualization
I don't think the lack of any of these two invalidates merging already.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lots of testing, including my own language training.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/practice/guifrontend.h <span style="color: grey">(2d2a12b)</span></li>
<li>src/practice/genderbackendmode.cpp <span style="color: grey">(6f7e99e)</span></li>
<li>src/practice/entryfilter.cpp <span style="color: grey">(d0d2e41)</span></li>
<li>src/practice/conjugationbackendmode.cpp <span style="color: grey">(fdc38f4)</span></li>
<li>src/practice/conjugationbackendmode.h <span style="color: grey">(243cf98)</span></li>
<li>src/practice/comparisonbackendmode.cpp <span style="color: grey">(00488ff)</span></li>
<li>src/practice/abstractfrontend.h <span style="color: grey">(b41bdae)</span></li>
<li>src/practice/abstractbackendmode.cpp <span style="color: grey">(19277e1)</span></li>
<li>TODO-PREGRADE <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/practice/abstractbackendmode.h <span style="color: grey">(b804540)</span></li>
<li>src/practice/guifrontend.cpp <span style="color: grey">(e88ff29)</span></li>
<li>src/practice/practice_mainwindow.ui <span style="color: grey">(0a4a9a7)</span></li>
<li>src/practice/practicestatemachine.cpp <span style="color: grey">(35e08e8)</span></li>
<li>src/practice/sessionmanagerfixed.cpp <span style="color: grey">(0ee0035)</span></li>
<li>src/practice/testentry.h <span style="color: grey">(454621b)</span></li>
<li>src/practice/testentry.cpp <span style="color: grey">(1aee0ef)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118068/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>