<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117878/">https://git.reviewboard.kde.org/r/117878/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 8th, 2014, 2:20 p.m. UTC, <b>Alexander Rieder</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this patch looks very good now. (i haven't tested your latest changes yet, but they look ok).
Do you already have commit access for our git repository? If not, and you plan to continue working on this, you can apply for an account, see http://techbase.kde.org/Contribute/Get_a_Contributor_Account for the details. Otherwise I can go ahead and commit this for you.
Thank you very much for this contribution.
Alexander</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks. I've applied for an account today, citing this patch as an evidence. Thanks again for the reviews.</pre>
<br />
<p>- Lucas</p>
<br />
<p>On May 5th, 2014, 7:18 p.m. UTC, Lucas Hermann Negri wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Lucas Hermann Negri.</div>
<p style="color: grey;"><i>Updated May 5, 2014, 7:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implements a luajit backend for Cantor. Implements highlighting, completion, and other features (variable explorer is missing).
Is compatible with Lua science/math libraries like numlua[1] and lna[2].
[1]: https://github.com/carvalho/numlua
[2]: https://bitbucket.org/lucashnegri/lna</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basic testing performed manually. Everything seems to work as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindLuaJIT.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-app-luabackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/CMakeLists.txt <span style="color: grey">(e89d9e6)</span></li>
<li>src/backends/lua/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luabackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luabackend.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luabackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luabackend.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luacompletionobject.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luacompletionobject.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luaexpression.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luaexpression.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luaextensions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luaextensions.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luahelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luahelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luahighlighter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luahighlighter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luasession.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luasession.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/settings.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/settings.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117878/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>