<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117878/">https://git.reviewboard.kde.org/r/117878/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 30th, 2014, 1:46 a.m. UTC, <b>Filipe Saraiva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">More a question Lucas, maybe you missed a FindLuaJIT.cmake file in this patch.</pre>
</blockquote>
<p>On April 30th, 2014, 2:11 p.m. UTC, <b>Lucas Hermann Negri</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The new patch adds the missing FindLuaJIT.cmake, the binary file and also fixes an issue with the string encoding that I missed on the last patch.</pre>
</blockquote>
<p>On April 30th, 2014, 4:06 p.m. UTC, <b>Filipe Saraiva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Lucas,
There is a small error in FindLuaJIT.cmake. You must to change the line 5, see below:
-FIND_PATH (LUAJIT_INCLUDE_DIR lua.h ${LUA_INCLUDE_DIRS} )
+FIND_PATH (LUAJIT_INCLUDE_DIR lua.h ${LUAJIT_INCLUDE_DIRS} )
I am getting an error, Cantor is crashing when I select Lua backend. The KCrash stack message is:
Application: Cantor (cantor), signal: Aborted
Using host libthread_db library "/lib64/libthread_db.so.1".
gobject.pyc: gdb was not built with custom backtrace support, disabling.
[KCrash Handler]
#5 0x00007fbd653f5d39 in raise () from /lib64/libc.so.6
#6 0x00007fbd653f7368 in abort () from /lib64/libc.so.6
#7 0x00007fbd65cee6b5 in __gnu_cxx::__verbose_terminate_handler() () from /lib64/libstdc++.so.6
#8 0x00007fbd65cec826 in __cxxabiv1::__terminate(void (*)()) () from /lib64/libstdc++.so.6
#9 0x00007fbd65cec853 in std::terminate() () from /lib64/libstdc++.so.6
#10 0x00007fbd65cecac6 in __cxa_rethrow () from /lib64/libstdc++.so.6
#11 0x00007fbd668c0ce6 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib64/libQtCore.so.4
#12 0x00007fbd668c5bdb in QCoreApplication::exec() () from /lib64/libQtCore.so.4
#13 0x000000000040a50f in main (argc=1, argv=0x7fffbda6a2d8) at /home/kdevil/kdesrc/kdeedu/cantor/src/main.cpp:89
The terminal output is in http://paste.kde.org/pscsa03im Maybe lines 142 -- 146 can say something.</pre>
</blockquote>
<p>On April 30th, 2014, 5:49 p.m. UTC, <b>Lucas Hermann Negri</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for your review. I've fixed the .cmake. I could not reproduce the crash. Can you generate a more detailed backtrace? I suspect that there is an exception being thrown on LuaSession::login(), but I'm not sure why.
Thanks.</pre>
</blockquote>
<p>On May 2nd, 2014, 8:03 p.m. UTC, <b>Filipe Saraiva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Lucas, I identified where is the problem.
luassesion.cpp - line 42:
luaL_loadstring(m_L, "function print(...) local t={}; for i = 1, select('#',...) do; local a=select(i,...); t[i]=tostring(a); end; table.insert(__cantor, table.concat(t,'\t')) end"); lua_call(m_L, 0, 0);
I wrote a kDebug() message before and after the lua_call(m_L, 0, 0); - only the kDebug() message before the lua_call worked. Then I commented this line, compiled the Cantor and I can run Lua backend without crash.
Maybe does luaL_loadstring have anything strange to my system?
</pre>
</blockquote>
<p>On May 3rd, 2014, 1:37 a.m. UTC, <b>Filipe Saraiva</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice, Patch 3 fixed the problem. Now I will verify your code.
I talked with Alex Rieder and he is reviewing in your code too.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Filipe, thanks for the testing.
I've found out that depending on the version, the ';' after do is invalid (and it is not needed in any case). I've uploaded a new patch, also protecting the calls performed on login.</pre>
<br />
<p>- Lucas</p>
<br />
<p>On May 5th, 2014, 7:18 p.m. UTC, Lucas Hermann Negri wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Lucas Hermann Negri.</div>
<p style="color: grey;"><i>Updated May 5, 2014, 7:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implements a luajit backend for Cantor. Implements highlighting, completion, and other features (variable explorer is missing).
Is compatible with Lua science/math libraries like numlua[1] and lna[2].
[1]: https://github.com/carvalho/numlua
[2]: https://bitbucket.org/lucashnegri/lna</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basic testing performed manually. Everything seems to work as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindLuaJIT.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/hi48-app-luabackend.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/CMakeLists.txt <span style="color: grey">(e89d9e6)</span></li>
<li>src/backends/lua/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luabackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luabackend.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luabackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luabackend.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luacompletionobject.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luacompletionobject.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luaexpression.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luaexpression.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luaextensions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luaextensions.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luahelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luahelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luahighlighter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luahighlighter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luasession.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/luasession.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/settings.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/backends/lua/settings.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117878/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>