<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117878/">https://git.reviewboard.kde.org/r/117878/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Lucas, thanks for your interesting in Cantor.

A binary file (hi48-app-luabackend.png) is missed in your patch. Please, could you create a new patch using --binary option in git diff? Please, see git manual about --binary option + git diff in https://www.kernel.org/pub/software/scm/git/docs/git-diff.html.</pre>
 <br />









<p>- Filipe Saraiva</p>


<br />
<p>On April 29th, 2014, 3:35 p.m. UTC, Lucas Hermann Negri wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Lucas Hermann Negri.</div>


<p style="color: grey;"><i>Updated April 29, 2014, 3:35 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implements a luajit backend for Cantor. Implements highlighting, completion, and other features (variable explorer is missing).

Is compatible with Lua science/math libraries like numlua[1] and lna[2].

[1]: https://github.com/carvalho/numlua
[2]: https://bitbucket.org/lucashnegri/lna</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basic testing performed manually. Everything seems to work as expected.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>icons/hi48-app-luabackend.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/CMakeLists.txt <span style="color: grey">(e89d9e6)</span></li>

 <li>src/backends/lua/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luabackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luabackend.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luabackend.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luabackend.kcfg <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luacompletionobject.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luacompletionobject.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luaexpression.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luaexpression.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luaextensions.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luaextensions.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luahelper.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luahelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luahighlighter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luahighlighter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luasession.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luasession.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/settings.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/settings.ui <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117878/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>