<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116868/">https://git.reviewboard.kde.org/r/116868/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4b851cece19ca2b2ba8a08083ee2f9b72cf82f2f by Inge Wallin to branch KDE/4.13.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 18th, 2014, 6:58 a.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Amarvir Singh.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated March 18, 2014, 6:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes bug 246198 - Making two words synonyms does not mark file as modified.
I fixed it as simply as I could, namely by providing a way for the docker widget to access the document and mark it as modified.
A better but bigger patch would have been to create a class EditorDockerWidget which gives the same access and which would be inherited by all editor docker widgets. That would reduce code duplication a lot but is better done in master.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with some kvtml files and it works as intended.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor/synonymwidget.h <span style="color: grey">(39aa2a0)</span></li>
<li>src/editor/synonymwidget.cpp <span style="color: grey">(e9c67de)</span></li>
<li>src/editor/editor.cpp <span style="color: grey">(334e211)</span></li>
<li>src/editor/editor.h <span style="color: grey">(e24a99c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116868/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>