<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116632/">https://git.reviewboard.kde.org/r/116632/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, and seems to work fine. Do you know if this will break with old versions of maxima? If not (or only very old ones), you can go ahead and ship it.
Do you have commit access?</pre>
<br />
<p>- Alexander Rieder</p>
<br />
<p>On March 6th, 2014, 1:32 p.m. UTC, Maximiliano Curia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Maximiliano Curia.</div>
<p style="color: grey;"><i>Updated March 6, 2014, 1:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
Back in 2009 maxima developers removed the psfile references from the code, and at the end of 2013 re add it, renaming psfile to ps_file with this commit:
commit 0ccd41f22f26400abc7569da4b492e90e234d8b8
Author: Jaime Villate <villate@fe.up.pt>
Date: Thu Dec 19 16:21:19 2013 +0000
Fixes names of plot options and adds some new ones
Names of the new plot options and funcitons now follow the convention of spelled out words, separated by underscores, unless a word has just one letter:
remove_plot_option(name), gnuplot_postamble, color_bar_tics, grid2d, iterations, label, same_xy, same_xyz, title, xbounds, xvar, xtics, xy_scale, ybounds, ytics, yx_r
New options added to save output in SVG, PNG or PDF formats:
png_file, pdf_file, svg_file, gnuplot_png_term_command, gnuplot_pdf_term_command and gnuplot_svg_term_command
This diff simply replaces the psfile occurrences with ps_file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/maxima/maximaexpression.cpp <span style="color: grey">(db44e3b8e769d14a945f6c843f2d6da36291b843)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116632/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>