<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116638/">https://git.reviewboard.kde.org/r/116638/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 6th, 2014, 5:15 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No changes are required in the C++ code?</pre>
</blockquote>
<p>On March 7th, 2014, 12:14 p.m. UTC, <b>Maximiliano Curia</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, that's weird. Oh, I see, the eigen is not even used by kalzium directly, libavogadro requires it, but it doesn't even link against it, so I guess it's all types, definitions and inline functions.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fair enough, let's do this. I'll give the shipit because there doesn't seem to be any Kalzium maintainers around.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On March 6th, 2014, 3:12 p.m. UTC, Maximiliano Curia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Maximiliano Curia.</div>
<p style="color: grey;"><i>Updated March 6, 2014, 3:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
Eigen2 was dropped from the debian archive, so Anton Gladky adapted kalzium to use eigen3, that can be followed in http://bugs.debian.org/728324
Please consider the inclusion of this change.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d7583c32b6497972ce42534423b5f07244fb93f0)</span></li>
<li>KalziumConfigureChecks.cmake <span style="color: grey">(8917d5e95e05150002d01f09955fa405879a8ac4)</span></li>
<li>cmake/modules/FindEigen3.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>compoundviewer/CMakeLists.txt <span style="color: grey">(b2b7e6c6e1b617ab464389266fe83c16748b168d)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(0ada32e60ea66ec5577170574c50d335c8c25f4c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116638/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>