<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115754/">https://git.reviewboard.kde.org/r/115754/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Amarvir Singh.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2014, 9:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331149">331149</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes three issues with the implementation of grades and boxes, which become obvious when using the alternative learning mode (3 consecutive right answers).
These issues are:
1. In alternative learning mode, the next grade box lights up, even though the question hasn't been answered correctly thrice consecutively, only to return back
to the previous grade when the question is asked again.
2. For a new word, that hasn't been learned yet, if the user answers it correctly the first time, ie. he/she knew the word already, the grade should increase from 0 to 2.
(0 to 1 for having learnt the word, and 1 to 2 for correctly answering it).
This would signify that the user knew the word already. But, even though the practice mode shows this increase in grades through the boxes, it doesn't actually
increase the grade twice. The next time this word is seen in practice, it is actually at grade 1. This is actually an effect of issue 3.
3. Parley doesn't increase the grade from 0 to 1 (new to learned) just because it has been seen once, in case the user answered it correctly.
The increase seen is actually due to the "answered correctly" part and not the "this word has been learned" part.
The effect of this issue can been clearly seen in alternative mode. In case the word is answered once correctly, the next occurrence of the same word doesn't have the
grade 1 box lit up. And starting a new session without answering thrice or answering wrong, results in the word being marked as unseen.
This patch fixes these bugs, so that even the alternative learning mode works correctly.
Fixes BUG: #331149</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested, and the patch works successfully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/practice/practicestatemachine.cpp <span style="color: grey">(016370a)</span></li>
<li>src/practice/testentry.h <span style="color: grey">(5519197)</span></li>
<li>src/practice/testentry.cpp <span style="color: grey">(df9716d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115754/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>