<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115758/">https://git.reviewboard.kde.org/r/115758/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115758/diff/2/?file=244178#file244178line173" style="color: black; font-weight: bold; text-decoration: underline;">src/kgeography.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">173</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">QString</span> <span class="n">res</span> <span class="o">=</span> <span class="n">browseFile</span><span class="p">(</span><span class="n">defaultDir</span><span class="p">,</span> <span class="n">initialFile</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why not just pass QString() instead of instantiaing initialFile?
Also it seems you only ever call that function with QString()/QString()?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115758/diff/2/?file=244180#file244180line203" style="color: black; font-weight: bold; text-decoration: underline;">src/kgeographyoptions.ui</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">203</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <property name="text"></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please mark these dummy strings in designer as "no need to translate them"</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115758/diff/2/?file=244184#file244184line20" style="color: black; font-weight: bold; text-decoration: underline;">src/placeasker.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KDebug></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not needed?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115758/diff/2/?file=244185#file244185line315" style="color: black; font-weight: bold; text-decoration: underline;">src/placemapwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void placeMapWidget::mouseMoveEvent(QMouseEvent *e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">315</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">QPoint</span> <span class="n">p</span><span class="p">(</span><span class="n">e</span><span class="o">-></span><span class="n">pos</span><span class="p">().</span><span class="n">x</span><span class="p">()</span><span class="o">-</span><span class="n">p_currentDivisionImage</span><span class="o">-></span><span class="n">width</span><span class="p">()</span><span class="o">/</span><span class="mi">2</span><span class="p">,</span><span class="n">e</span><span class="o">-></span><span class="n">pos</span><span class="p">().</span><span class="n">y</span><span class="p">()</span><span class="o">-</span><span class="n">p_currentDivisionImage</span><span class="o">-></span><span class="n">height</span><span class="p">()</span><span class="o">/</span><span class="mi">2</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">bad merge? This change is already in the if above, no?</pre>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On February 15th, 2014, 1:08 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2014, 1:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=132702">132702</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code to choose the sound file is borrowed from kalarm.
Add phonon to play sounds (can not be easier).
Add the configuration to select the sound files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It only make sounds when selected in the configuration, and the sound file exists.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/placeasker.cpp <span style="color: grey">(d65e030)</span></li>
<li>src/placemapwidget.cpp <span style="color: grey">(0067583)</span></li>
<li>src/divisionflagasker.cpp <span style="color: grey">(361c973)</span></li>
<li>src/flagdivisionasker.h <span style="color: grey">(623a249)</span></li>
<li>src/flagdivisionasker.cpp <span style="color: grey">(34f7711)</span></li>
<li>src/kgeography.h <span style="color: grey">(4506bd0)</span></li>
<li>src/kgeography.cpp <span style="color: grey">(e5e5305)</span></li>
<li>src/kgeography.kcfg <span style="color: grey">(14f5d4f)</span></li>
<li>src/kgeographyoptions.ui <span style="color: grey">(109b077)</span></li>
<li>src/mapasker.h <span style="color: grey">(4e89fe5)</span></li>
<li>src/mapasker.cpp <span style="color: grey">(22e0c24)</span></li>
<li>src/placeasker.h <span style="color: grey">(7d27178)</span></li>
<li>CMakeLists.txt <span style="color: grey">(e7a6d9c)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(9e49f0d)</span></li>
<li>src/askwidget.h <span style="color: grey">(32421b0)</span></li>
<li>src/askwidget.cpp <span style="color: grey">(7f9e3cc)</span></li>
<li>src/boxasker.h <span style="color: grey">(507099f)</span></li>
<li>src/boxasker.cpp <span style="color: grey">(f0a5b60)</span></li>
<li>src/capitaldivisionasker.h <span style="color: grey">(744c43c)</span></li>
<li>src/capitaldivisionasker.cpp <span style="color: grey">(495eb26)</span></li>
<li>src/divisioncapitalasker.h <span style="color: grey">(0246482)</span></li>
<li>src/divisioncapitalasker.cpp <span style="color: grey">(625379b)</span></li>
<li>src/divisionflagasker.h <span style="color: grey">(ffee8c2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115758/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>