<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115549/">https://git.reviewboard.kde.org/r/115549/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not completely comfortable with this patch (at least I would like to hear Frederik's opinion about it).
The patch solves a lot of issues (espacially whitespace, indentation), but at the changed lines a issues remain, e.g., positioning of "&" and "*" operators that is used differently at a lot of places. So my question is: should a single patch solve all coding stile issues, or do we want to have several patches where every patch solves only one specific coding style problem.</pre>
<br />
<p>- Andreas Cord-Landwehr</p>
<br />
<p>On February 12th, 2014, 4:54 p.m. UTC, Amarvir Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Amarvir Singh.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2014, 4:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indentation changes and whitespace changes according to Kdelibs coding style. Mainly made using astyle script. Some XML indentation is done too.
Based on the parent diff, that has been merged.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested. No functional changes at all.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/settings/kgametheme/kgametheme.h <span style="color: grey">(5e06a70)</span></li>
<li>src/settings/kgametheme/kgametheme.cpp <span style="color: grey">(f9a374b)</span></li>
<li>src/settings/kgametheme/kgamethemeselector.h <span style="color: grey">(a95cc89)</span></li>
<li>src/settings/kgametheme/kgamethemeselector.cpp <span style="color: grey">(d89a1fe)</span></li>
<li>src/settings/languageproperties.h <span style="color: grey">(2f5ac49)</span></li>
<li>src/settings/languageproperties.cpp <span style="color: grey">(15a5894)</span></li>
<li>src/settings/languagepropertiespage.h <span style="color: grey">(5c19792)</span></li>
<li>src/settings/languagepropertiespage.cpp <span style="color: grey">(d877f99)</span></li>
<li>src/settings/parleyprefs.cpp <span style="color: grey">(7f4bf47)</span></li>
<li>src/settings/viewoptions.cpp <span style="color: grey">(99b15d7)</span></li>
<li>src/statistics/conjugationoptions.h <span style="color: grey">(2ebb0c3)</span></li>
<li>src/statistics/conjugationoptions.cpp <span style="color: grey">(a2b0f35)</span></li>
<li>src/statistics/lessonstatistics.h <span style="color: grey">(7722feb)</span></li>
<li>src/statistics/lessonstatistics.cpp <span style="color: grey">(41d33f9)</span></li>
<li>src/statistics/statisticsmainwindow.h <span style="color: grey">(3ad22ac)</span></li>
<li>src/statistics/statisticsmainwindow.cpp <span style="color: grey">(e5a63b3)</span></li>
<li>src/statistics/statisticsmodel.cpp <span style="color: grey">(e3791ae)</span></li>
<li>src/vocabulary/basiccontainermodel.h <span style="color: grey">(98999b5)</span></li>
<li>src/vocabulary/basiccontainermodel.cpp <span style="color: grey">(a14a857)</span></li>
<li>src/vocabulary/containermimedata.h <span style="color: grey">(ef71021)</span></li>
<li>src/vocabulary/containermodel.h <span style="color: grey">(4cd5ab3)</span></li>
<li>src/vocabulary/containermodel.cpp <span style="color: grey">(bf91b73)</span></li>
<li>src/vocabulary/containerview.h <span style="color: grey">(92e5810)</span></li>
<li>src/vocabulary/leitnerview.cpp <span style="color: grey">(b87d0a4)</span></li>
<li>src/vocabulary/lessonmodel.h <span style="color: grey">(942dc05)</span></li>
<li>src/vocabulary/lessonmodel.cpp <span style="color: grey">(937d6d4)</span></li>
<li>src/vocabulary/lessonview.h <span style="color: grey">(7ad607f)</span></li>
<li>src/vocabulary/lessonview.cpp <span style="color: grey">(6c6b679)</span></li>
<li>src/vocabulary/vocabularycolumnsdialog.h <span style="color: grey">(10955b5)</span></li>
<li>src/vocabulary/vocabularycolumnsdialog.cpp <span style="color: grey">(524111e)</span></li>
<li>src/vocabulary/vocabularydelegate.h <span style="color: grey">(6bde4db)</span></li>
<li>src/vocabulary/vocabularydelegate.cpp <span style="color: grey">(412814a)</span></li>
<li>src/vocabulary/vocabularyfilter.h <span style="color: grey">(0a8b161)</span></li>
<li>src/vocabulary/vocabularyfilter.cpp <span style="color: grey">(e03f1d7)</span></li>
<li>src/vocabulary/vocabularyheaderview.h <span style="color: grey">(3cdb550)</span></li>
<li>src/vocabulary/vocabularyheaderview.cpp <span style="color: grey">(0f9e39e)</span></li>
<li>src/vocabulary/vocabularymimedata.h <span style="color: grey">(708da60)</span></li>
<li>src/vocabulary/vocabularymimedata.cpp <span style="color: grey">(b960587)</span></li>
<li>src/vocabulary/vocabularymodel.h <span style="color: grey">(f62187e)</span></li>
<li>src/vocabulary/vocabularymodel.cpp <span style="color: grey">(d2a76b2)</span></li>
<li>src/vocabulary/vocabularyview.h <span style="color: grey">(67edc4e)</span></li>
<li>src/vocabulary/vocabularyview.cpp <span style="color: grey">(434f50e)</span></li>
<li>src/vocabulary/wordtypemodel.h <span style="color: grey">(3923492)</span></li>
<li>src/vocabulary/wordtypemodel.cpp <span style="color: grey">(d850c57)</span></li>
<li>src/vocabulary/wordtypeview.h <span style="color: grey">(95b434f)</span></li>
<li>src/vocabulary/wordtypeview.cpp <span style="color: grey">(eef46c5)</span></li>
<li>src/welcomescreen/buttondelegate.h <span style="color: grey">(b3dd213)</span></li>
<li>src/welcomescreen/buttondelegate.cpp <span style="color: grey">(0226d27)</span></li>
<li>src/welcomescreen/welcomescreen.h <span style="color: grey">(aff6179)</span></li>
<li>src/welcomescreen/welcomescreen.cpp <span style="color: grey">(32ffb6f)</span></li>
<li>src/practice/practicestatemachine.h <span style="color: grey">(c35a57a)</span></li>
<li>src/practice/practicestatemachine.cpp <span style="color: grey">(03da990)</span></li>
<li>src/practice/practicesummarycomponent.h <span style="color: grey">(7e33965)</span></li>
<li>src/practice/practicesummarycomponent.cpp <span style="color: grey">(562fc92)</span></li>
<li>src/practice/statustoggle.h <span style="color: grey">(35fe3b7)</span></li>
<li>src/practice/statustoggle.cpp <span style="color: grey">(7265a83)</span></li>
<li>src/practice/statustogglebutton.h <span style="color: grey">(f9c5aeb)</span></li>
<li>src/practice/statustogglebutton.cpp <span style="color: grey">(7411bf5)</span></li>
<li>src/practice/summarybarwidget.h <span style="color: grey">(3b3d5ed)</span></li>
<li>src/practice/summarybarwidget.cpp <span style="color: grey">(1558028)</span></li>
<li>src/practice/testentry.h <span style="color: grey">(1db0754)</span></li>
<li>src/practice/testentry.cpp <span style="color: grey">(e047b9e)</span></li>
<li>src/practice/testentrymanager.h <span style="color: grey">(5b63165)</span></li>
<li>src/practice/testentrymanager.cpp <span style="color: grey">(a6a1eac)</span></li>
<li>src/practice/themedbackgroundrenderer.h <span style="color: grey">(d274dc2)</span></li>
<li>src/practice/themedbackgroundrenderer.cpp <span style="color: grey">(a817248)</span></li>
<li>src/practice/writtenbackendmode.h <span style="color: grey">(251fc02)</span></li>
<li>src/practice/writtenbackendmode.cpp <span style="color: grey">(b23c38f)</span></li>
<li>src/practice/writtenpracticevalidator.h <span style="color: grey">(3ae63ac)</span></li>
<li>src/practice/writtenpracticevalidator.cpp <span style="color: grey">(4fdf59d)</span></li>
<li>src/practice/writtenpracticewidget.h <span style="color: grey">(7573d5b)</span></li>
<li>src/practice/writtenpracticewidget.cpp <span style="color: grey">(05e2a16)</span></li>
<li>src/scripts/script.h <span style="color: grey">(d7c3133)</span></li>
<li>src/scripts/script.cpp <span style="color: grey">(840d60d)</span></li>
<li>src/scripts/scriptdialog.h <span style="color: grey">(2296eec)</span></li>
<li>src/scripts/scriptdialog.cpp <span style="color: grey">(ec2a779)</span></li>
<li>src/scripts/scripting/container.h <span style="color: grey">(1256dbd)</span></li>
<li>src/scripts/scripting/container.cpp <span style="color: grey">(df7fc09)</span></li>
<li>src/scripts/scripting/document.h <span style="color: grey">(1924824)</span></li>
<li>src/scripts/scripting/document.cpp <span style="color: grey">(58f6978)</span></li>
<li>src/scripts/scripting/expression.h <span style="color: grey">(d7af07e)</span></li>
<li>src/scripts/scripting/expression.cpp <span style="color: grey">(5823a76)</span></li>
<li>src/scripts/scripting/identifier.h <span style="color: grey">(ca73083)</span></li>
<li>src/scripts/scripting/identifier.cpp <span style="color: grey">(639f206)</span></li>
<li>src/scripts/scripting/lesson.h <span style="color: grey">(8860e82)</span></li>
<li>src/scripts/scripting/lesson.cpp <span style="color: grey">(5c8ca54)</span></li>
<li>src/scripts/scripting/parley.h <span style="color: grey">(cf0230d)</span></li>
<li>src/scripts/scripting/parley.cpp <span style="color: grey">(7abdf52)</span></li>
<li>src/scripts/scripting/text.h <span style="color: grey">(84daf9f)</span></li>
<li>src/scripts/scripting/text.cpp <span style="color: grey">(b331601)</span></li>
<li>src/scripts/scripting/translation.h <span style="color: grey">(1c6cd8f)</span></li>
<li>src/scripts/scripting/translation.cpp <span style="color: grey">(5b8dd42)</span></li>
<li>src/scripts/scriptmanager.h <span style="color: grey">(1a390e0)</span></li>
<li>src/scripts/scriptmanager.cpp <span style="color: grey">(0e8926a)</span></li>
<li>src/scripts/translator.h <span style="color: grey">(678bb45)</span></li>
<li>src/scripts/translator.cpp <span style="color: grey">(6d461d2)</span></li>
<li>src/settings/documentproperties.cpp <span style="color: grey">(7d0046e)</span></li>
<li>src/settings/generaloptions.cpp <span style="color: grey">(2168da8)</span></li>
<li>src/practice/imagecache.cpp <span style="color: grey">(651ba1a)</span></li>
<li>src/practice/imagewidget.h <span style="color: grey">(561be8f)</span></li>
<li>src/practice/imagewidget.cpp <span style="color: grey">(63b42a4)</span></li>
<li>src/practice/latexrenderer.h <span style="color: grey">(37449b8)</span></li>
<li>src/practice/latexrenderer.cpp <span style="color: grey">(855f956)</span></li>
<li>src/practice/mixedlettersmodewidget.h <span style="color: grey">(8d49285)</span></li>
<li>src/practice/mixedlettersmodewidget.cpp <span style="color: grey">(ff1f190)</span></li>
<li>src/practice/multiplechoicebackendmode.h <span style="color: grey">(c107d0f)</span></li>
<li>src/practice/multiplechoicebackendmode.cpp <span style="color: grey">(9fa6aae)</span></li>
<li>src/practice/multiplechoicedata.h <span style="color: grey">(11b36d9)</span></li>
<li>src/practice/multiplechoicemodewidget.h <span style="color: grey">(b97c1ae)</span></li>
<li>src/practice/multiplechoicemodewidget.cpp <span style="color: grey">(a26eafc)</span></li>
<li>src/practice/practicemainwindow.h <span style="color: grey">(2734541)</span></li>
<li>src/practice/practicemainwindow.cpp <span style="color: grey">(9f23ae9)</span></li>
<li>src/practice/practiceoptions.h <span style="color: grey">(62eb082)</span></li>
<li>src/practice/practiceoptions.cpp <span style="color: grey">(66cd37d)</span></li>
<li>src/editor/multiplechoicewidget.cpp <span style="color: grey">(7b8c7e9)</span></li>
<li>src/editor/summarywordwidget.h <span style="color: grey">(0811667)</span></li>
<li>src/editor/summarywordwidget.cpp <span style="color: grey">(008fcfd)</span></li>
<li>src/editor/synonymwidget.h <span style="color: grey">(eee66fe)</span></li>
<li>src/editor/synonymwidget.cpp <span style="color: grey">(4090aca)</span></li>
<li>src/export/exportdialog.h <span style="color: grey">(6eec6a1)</span></li>
<li>src/export/exportdialog.cpp <span style="color: grey">(f7dc2ce)</span></li>
<li>src/main.cpp <span style="color: grey">(3c578e6)</span></li>
<li>src/modeltest/modeltest.h <span style="color: grey">(18b7081)</span></li>
<li>src/modeltest/modeltest.cpp <span style="color: grey">(b360f67)</span></li>
<li>src/parleyactions.h <span style="color: grey">(880ddd4)</span></li>
<li>src/parleyactions.cpp <span style="color: grey">(8f239fb)</span></li>
<li>src/parleydocument.h <span style="color: grey">(05e8463)</span></li>
<li>src/parleydocument.cpp <span style="color: grey">(606e9e6)</span></li>
<li>src/parleymainwindow.h <span style="color: grey">(554ce25)</span></li>
<li>src/parleymainwindow.cpp <span style="color: grey">(cd26f4f)</span></li>
<li>src/practice/abstractbackendmode.h <span style="color: grey">(55d784b)</span></li>
<li>src/practice/abstractbackendmode.cpp <span style="color: grey">(6dba422)</span></li>
<li>src/practice/abstractfrontend.h <span style="color: grey">(5cff651)</span></li>
<li>src/practice/abstractwidget.h <span style="color: grey">(3156b17)</span></li>
<li>src/practice/answervalidatorold.h <span style="color: grey">(cdfc182)</span></li>
<li>src/practice/answervalidatorold.cpp <span style="color: grey">(1e0dff9)</span></li>
<li>src/practice/audiobutton.h <span style="color: grey">(abebaf4)</span></li>
<li>src/practice/audiobutton.cpp <span style="color: grey">(2aae366)</span></li>
<li>src/practice/boxeswidget.h <span style="color: grey">(272b7ba)</span></li>
<li>src/practice/boxeswidget.cpp <span style="color: grey">(8f4b2b2)</span></li>
<li>src/practice/comparisonbackendmode.h <span style="color: grey">(db3d52b)</span></li>
<li>src/practice/comparisonbackendmode.cpp <span style="color: grey">(2e539f1)</span></li>
<li>src/practice/comparisonmodewidget.h <span style="color: grey">(7307d9c)</span></li>
<li>src/practice/conjugationbackendmode.h <span style="color: grey">(023982f)</span></li>
<li>src/practice/conjugationbackendmode.cpp <span style="color: grey">(78d4f6c)</span></li>
<li>src/practice/conjugationdata.h <span style="color: grey">(d2298be)</span></li>
<li>src/practice/conjugationmodewidget.h <span style="color: grey">(d6e63ee)</span></li>
<li>src/practice/conjugationmodewidget.cpp <span style="color: grey">(4491304)</span></li>
<li>src/practice/entryfilter.h <span style="color: grey">(17640d8)</span></li>
<li>src/practice/entryfilter.cpp <span style="color: grey">(9cde17d)</span></li>
<li>src/practice/examplesentencebackendmode.h <span style="color: grey">(d9472a3)</span></li>
<li>src/practice/examplesentencebackendmode.cpp <span style="color: grey">(1a46ba9)</span></li>
<li>src/practice/flashcardbackendmode.h <span style="color: grey">(b47c1b3)</span></li>
<li>src/practice/flashcardbackendmode.cpp <span style="color: grey">(f0e5bda)</span></li>
<li>src/practice/flashcardmodewidget.h <span style="color: grey">(ea336bb)</span></li>
<li>src/practice/flashcardmodewidget.cpp <span style="color: grey">(a421379)</span></li>
<li>src/practice/genderbackendmode.h <span style="color: grey">(a54c0bf)</span></li>
<li>src/practice/genderbackendmode.cpp <span style="color: grey">(7c9b42b)</span></li>
<li>src/practice/guifrontend.h <span style="color: grey">(3e76a98)</span></li>
<li>src/practice/guifrontend.cpp <span style="color: grey">(6c948be)</span></li>
<li>src/practice/imagecache.h <span style="color: grey">(a4a9719)</span></li>
<li>plasmoid/engine/parley_engine.h <span style="color: grey">(5db00b5)</span></li>
<li>plasmoid/engine/parley_engine.cpp <span style="color: grey">(fd6947e)</span></li>
<li>plasmoid/parley_plasma.h <span style="color: grey">(2c47ccd)</span></li>
<li>plasmoid/parley_plasma.cpp <span style="color: grey">(e9d3a53)</span></li>
<li>scripts_test/main.cpp <span style="color: grey">(e036dc9)</span></li>
<li>scripts_test/scripts.h <span style="color: grey">(5ceed98)</span></li>
<li>scripts_test/scripts.cpp <span style="color: grey">(1ec2dff)</span></li>
<li>scripts_test/translationscript.h <span style="color: grey">(fb02db9)</span></li>
<li>scripts_test/translationscript.cpp <span style="color: grey">(b4fe650)</span></li>
<li>src/configure-practice/blockoptions.cpp <span style="color: grey">(a6b9640)</span></li>
<li>src/configure-practice/configurepracticedialog.cpp <span style="color: grey">(36aa8ec)</span></li>
<li>src/editor/FromToEntryPage.cpp <span style="color: grey">(4b6b474)</span></li>
<li>src/editor/audiowidget.h <span style="color: grey">(4f2389b)</span></li>
<li>src/editor/audiowidget.cpp <span style="color: grey">(4c80a81)</span></li>
<li>src/editor/browserwidget.h <span style="color: grey">(e36c9f0)</span></li>
<li>src/editor/browserwidget.cpp <span style="color: grey">(506e71d)</span></li>
<li>src/editor/comparisonwidget.h <span style="color: grey">(a819e48)</span></li>
<li>src/editor/comparisonwidget.cpp <span style="color: grey">(7589bac)</span></li>
<li>src/editor/conjugationwidget.h <span style="color: grey">(fbb0751)</span></li>
<li>src/editor/conjugationwidget.cpp <span style="color: grey">(76f20e1)</span></li>
<li>src/editor/declensionwidget.h <span style="color: grey">(d0931bf)</span></li>
<li>src/editor/declensionwidget.cpp <span style="color: grey">(5c03f3e)</span></li>
<li>src/editor/editor.h <span style="color: grey">(2497938)</span></li>
<li>src/editor/editor.cpp <span style="color: grey">(f3787a3)</span></li>
<li>src/editor/imagechooserwidget.h <span style="color: grey">(b62ebb6)</span></li>
<li>src/editor/imagechooserwidget.cpp <span style="color: grey">(a4e3f86)</span></li>
<li>src/editor/inflectionwidget.h <span style="color: grey">(bde55bb)</span></li>
<li>src/editor/inflectionwidget.cpp <span style="color: grey">(0f643a0)</span></li>
<li>src/editor/latexwidget.h <span style="color: grey">(e281ca5)</span></li>
<li>src/editor/latexwidget.cpp <span style="color: grey">(46f81d6)</span></li>
<li>src/editor/multiplechoicewidget.h <span style="color: grey">(15c87b2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115549/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>