<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115601/">https://git.reviewboard.kde.org/r/115601/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115601/diff/2/?file=242803#file242803line225" style="color: black; font-weight: bold; text-decoration: underline;">src/editor/editor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void EditorWindow::initDockWidgets()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">225</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">this</span><span class="o">-></span><span class="n">tabifyDockWidget</span><span class="p">(</span><span class="n">comparisonDock</span><span class="p">,</span><span class="n">inflectionDock</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"this->" is usually frowned upon amongst C++ coders, just don't put it there.</pre>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On February 11th, 2014, 7:40 p.m. UTC, Amarvir Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Amarvir Singh.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2014, 7:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes the bug that caused widgets in the editor to leak out of the bottom of the screen, if multiple widgets were selected in view, making them inaccessible.
The bug didn't allow the screen to be resized either as the dock widgets could not be made smaller.
This made it an annoying bug, as it didn't allow the user to simply resize the window to access the cutoff widgets. They had to be closed, and the window had to be minimized-maximized
to restructure the dock widgets.
Steps to reproduce:
1. Go to editor mode.
2. View->add multiple widgets (eg synonyms, antonyms, image, latex, etc.)
3. The widgets start leaking out even in a Full HD screen, and some, hence, become inaccessible.
4. Try resizing window (decreasing size from the top), doesnt work, as QDockWidgets take a defined space.
Expected Result:
Widgets should not be cutoff, and resizing should be possible.
This commit makes each widget scrollable so that they can be reduced in size, to allow the window to be made smaller. Also they are tabbed together, to ensure widgets don't leak out,
even for lower resolutions, and it also ensures that they remain accessible.
PS: To properly check for the changes in the dockwidgets after the patch, be sure to not use the configuration saved, rename it or delete it, or just rename kdehome directory. This is because dockwidget positions and layout is saved. Then continue adding all widgets.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested, from 1920x1080 to 800x600 resolutions. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor/editor.cpp <span style="color: grey">(f3787a3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115601/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>