<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115449/">https://git.reviewboard.kde.org/r/115449/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Additional notes:
Please make sure that during practice the colors are not used or working (I'm not sure how that works at the moment, but I have a faint memory that written practice indicates how well you know the word. Probably I'm wrong though).
Check with dark themes (the editor).</pre>
<br />
<p>- Frederik Gladhorn</p>
<br />
<p>On February 6th, 2014, 11:55 p.m. UTC, Amarvir Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Andreas Cord-Landwehr.</div>
<div>By Amarvir Singh.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2014, 11:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=266368">266368</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=328279">328279</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This closes the mentioned bug, as it removes the gradient in learning statistics and uses solid color.
It also makes it even more intuitive for the user, as it uses a single color for all the grades with different alpha values, increasing as grades increase. Thus darker shades mean higher grades.
Also the default grade colors have been changed to be the same, except grade 0.
Fixes BUG:#266368
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the default button, and tested for all grades. Still intuitive and working.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/vocabulary/vocabularymodel.cpp <span style="color: grey">(e8c7afb)</span></li>
<li>src/settings/parley.kcfg <span style="color: grey">(34bfd98)</span></li>
<li>src/settings/viewoptions.cpp <span style="color: grey">(7b475e0)</span></li>
<li>src/settings/viewoptionsbase.ui <span style="color: grey">(a5755f0)</span></li>
<li>src/statistics/lessonstatistics.cpp <span style="color: grey">(e09cff8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115449/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>