<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113817/">http://git.reviewboard.kde.org/r/113817/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 13th, 2013, 5:14 p.m. UTC, <b>Alexander Rieder</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think "languageHighlighting" is not the best term to use. In my opinion it would be better to use highlightingLanguage. (or maybe just reuse HighlightingMode from KTextEditor? ). Other than that, code wise the change looks fine.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks Alex, I will change the function name to "highlightingMode" (I think it is more interesting) and will push the code tonight.</pre>
<br />
<p>- Filipe</p>
<br />
<p>On November 12th, 2013, 1:39 p.m. UTC, Filipe Saraiva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Edu and Alexander Rieder.</div>
<div>By Filipe Saraiva.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2013, 1:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In currently Cantor version, the user must choose the syntax highlighting changing the option in a kpart menu - it is hide from user.
This patch allow syntax highlighting in script extension when the script widget is launched by user.
I ported Octave, Sage, R, and Maxima backends to support it too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with Octave, Sage, R, and Maxima backends.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/octave/octaveextensions.cpp <span style="color: grey">(534e69e)</span></li>
<li>src/backends/sage/sageextensions.h <span style="color: grey">(5022c69)</span></li>
<li>src/backends/sage/sageextensions.cpp <span style="color: grey">(9efc856)</span></li>
<li>src/cantor_part.cpp <span style="color: grey">(7aad304)</span></li>
<li>src/lib/extension.h <span style="color: grey">(3c5085d)</span></li>
<li>src/scripteditorwidget.h <span style="color: grey">(2ca672d)</span></li>
<li>src/scripteditorwidget.cpp <span style="color: grey">(03684aa)</span></li>
<li>src/backends/R/rextensions.h <span style="color: grey">(39d5f1b)</span></li>
<li>src/backends/R/rextensions.cpp <span style="color: grey">(a036220)</span></li>
<li>src/backends/maxima/maximaextensions.h <span style="color: grey">(34afc2a)</span></li>
<li>src/backends/maxima/maximaextensions.cpp <span style="color: grey">(211c8cb)</span></li>
<li>src/backends/octave/octaveextensions.h <span style="color: grey">(5dae826)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113817/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>